Merge pull request #32622 from hashicorp/b-aws_pipes_pipe-update-error

r/aws_pipes_pipe: Prevent `ValidationException` errors on Update
hashicorp · Jul 20, 2023 · 5bd43a0 · 5bd43a0
2 parents 2c47b30 + 89361d4
commit 5bd43a0
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 6 deletions.
diff --git a/.changelog/32622.txt b/.changelog/32622.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+resource/aws_pipes_pipe: Fix `ValidationException` errors when updating pipe
+```
diff --git a/internal/service/pipes/pipe.go b/internal/service/pipes/pipe.go
@@ -242,16 +242,22 @@ func resourcePipeUpdate(ctx context.Context, d *schema.ResourceData, meta interf
  input.Enrichment = aws.String(d.Get("enrichment").(string))
  }
 
- if v, ok := d.GetOk("enrichment_parameters"); ok && len(v.([]interface{})) > 0 && v.([]interface{})[0] != nil {
- input.EnrichmentParameters = expandPipeEnrichmentParameters(v.([]interface{})[0].(map[string]interface{}))
+ if d.HasChange("enrichment_parameters") {
+ if v, ok := d.GetOk("enrichment_parameters"); ok && len(v.([]interface{})) > 0 && v.([]interface{})[0] != nil {
+ input.EnrichmentParameters = expandPipeEnrichmentParameters(v.([]interface{})[0].(map[string]interface{}))
+ }
  }
 
- if v, ok := d.GetOk("source_parameters"); ok && len(v.([]interface{})) > 0 && v.([]interface{})[0] != nil {
- input.SourceParameters = expandUpdatePipeSourceParameters(v.([]interface{})[0].(map[string]interface{}))
+ if d.HasChange("source_parameters") {
+ if v, ok := d.GetOk("source_parameters"); ok && len(v.([]interface{})) > 0 && v.([]interface{})[0] != nil {
+ input.SourceParameters = expandUpdatePipeSourceParameters(v.([]interface{})[0].(map[string]interface{}))
+ }
  }
 
- if v, ok := d.GetOk("target_parameters"); ok && len(v.([]interface{})) > 0 && v.([]interface{})[0] != nil {
- input.TargetParameters = expandPipeTargetParameters(v.([]interface{})[0].(map[string]interface{}))
+ if d.HasChange("target_parameters") {
+ if v, ok := d.GetOk("target_parameters"); ok && len(v.([]interface{})) > 0 && v.([]interface{})[0] != nil {
+ input.TargetParameters = expandPipeTargetParameters(v.([]interface{})[0].(map[string]interface{}))
+ }
  }
 
  output, err := conn.UpdatePipe(ctx, input)