Skip to content

Commit

Permalink
d/aws_s3_bucket_object: Refactor to use keyvaluetags package.
Browse files Browse the repository at this point in the history
  • Loading branch information
ewbankkit committed Feb 12, 2020
1 parent dba51fc commit 6f1e848
Showing 1 changed file with 8 additions and 7 deletions.
15 changes: 8 additions & 7 deletions aws/data_source_aws_s3_bucket_object.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import (
"github.com/aws/aws-sdk-go/aws"
"github.com/aws/aws-sdk-go/service/s3"
"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
"github.com/terraform-providers/terraform-provider-aws/aws/internal/keyvaluetags"
)

func dataSourceAwsS3BucketObject() *schema.Resource {
Expand Down Expand Up @@ -218,15 +219,15 @@ func dataSourceAwsS3BucketObjectRead(d *schema.ResourceData, meta interface{}) e
uniqueId, contentType)
}

tagResp, err := conn.GetObjectTagging(
&s3.GetObjectTaggingInput{
Bucket: aws.String(bucket),
Key: aws.String(key),
})
tags, err := keyvaluetags.S3ObjectListTags(conn, bucket, key)

if err != nil {
return err
return fmt.Errorf("error listing tags for S3 Bucket (%s) Object (%s): %s", bucket, key, err)
}

if err := d.Set("tags", tags.IgnoreAws().Map()); err != nil {
return fmt.Errorf("error setting tags: %s", err)
}
d.Set("tags", tagsToMapS3(tagResp.TagSet))

return nil
}
Expand Down

0 comments on commit 6f1e848

Please sign in to comment.