Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type to aws_sfn_state_machine #11348

Closed
grahamhar opened this issue Dec 18, 2019 · 4 comments · Fixed by #12249
Closed

Add type to aws_sfn_state_machine #11348

grahamhar opened this issue Dec 18, 2019 · 4 comments · Fixed by #12249
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/sfn Issues and PRs that pertain to the sfn service.
Milestone

Comments

@grahamhar
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Following the introduction of express step functions as described in this blog post and documented here can support be added to the existing resource for this new capability.

New or Affected Resource(s)

  • aws_sfn_state_machine

Potential Terraform Configuration

type would default to Standard to make this a non breaking change.

resource "aws_sfn_state_machine" "sfn_state_machine" {
  name     = "my-state-machine"
  role_arn = aws_iam_role.iam_for_sfn.arn
  type     = "Express"
  definition = <<EOF
{
  "Comment": "A Hello World example of the Amazon States Language using an AWS Lambda Function",
  "StartAt": "HelloWorld",
  "States": {
    "HelloWorld": {
      "Type": "Task",
      "Resource": aws_lambda_function.lambda.arn,
      "End": true
    }
  }
}
EOF
}
@grahamhar grahamhar added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 18, 2019
@ghost ghost added the service/sfn Issues and PRs that pertain to the sfn service. label Dec 18, 2019
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 18, 2019
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Dec 18, 2019
@rockycore
Copy link
Contributor

For Type and Logging here is another PR: #11570)
The former PR does not cover the relevant Logging Configuration for EXPRESS Workflows.

@breathingdust
Copy link
Member

Hi all! 👋 Just wanted to direct you to our public roadmap for this quarter (Nov-Jan) in which this item has been mentioned.

Due to the significant community interest in support for this feature, we will be looking at merging existing contributions soon.

We appreciate all the contributions and feedback thus far.

Look out for support in the provider soon!

@ghost
Copy link

ghost commented Feb 5, 2021

This has been released in version 3.27.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 7, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/sfn Issues and PRs that pertain to the sfn service.
Projects
None yet
4 participants