Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support modifying the association of a subnet with a network ACL #12364

Closed
wandrew26 opened this issue Mar 12, 2020 · 2 comments · Fixed by #18807
Closed

Support modifying the association of a subnet with a network ACL #12364

wandrew26 opened this issue Mar 12, 2020 · 2 comments · Fixed by #18807
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Milestone

Comments

@wandrew26
Copy link

wandrew26 commented Mar 12, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

In case you have some additional ACLs (which isn't set as the default ACL) and you create a new subnet, you have no possibility to define which ACL should be used. It will use the default ACL as standard.
Currently there is no way to modify the default ACL association of a subnet.
I think we could create an aws_subnet_network_acl_association resource to solve this problem.
Only parameters needed are subnet_id and network_acl_id.
We could get the current associated ACL with "DescribeNetworkAcls" API call filtering for the subnet id. To replace it with the new ACL id the API call "ReplaceNetworkAclAssociation" should be used.

New or Affected Resource(s)

  • aws_subnet_network_acl_association

Potential Terraform Configuration

resource "aws_subnet" "public" {
  #...
}

resource "aws_network_acl" "public" {
  #...
}

resource "aws_subnet_network_acl_association" "this" {
  subnet_id      = aws_subnet.public.id
  network_acl_id = aws_network_acl.public.id
}

References

@wandrew26 wandrew26 added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 12, 2020
@ghost ghost added the service/ec2 Issues and PRs that pertain to the ec2 service. label Mar 12, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 12, 2020
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 22, 2021
@github-actions github-actions bot added this to the v4.0.0 milestone Feb 8, 2022
@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants