Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"NonOverridableArguments" missing from aws_glue_job resource #13117

Closed
twnbay78 opened this issue Apr 30, 2020 · 2 comments · Fixed by #14793
Closed

"NonOverridableArguments" missing from aws_glue_job resource #13117

twnbay78 opened this issue Apr 30, 2020 · 2 comments · Fixed by #14793
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/glue Issues and PRs that pertain to the glue service.
Milestone

Comments

@twnbay78
Copy link

Problem

The AWS Glue "create_job" and "update_job" API's provide a parameter of type map called "NonOverridableArguments." We have recently encountered an error in PROD where important job arguments that were meant to be non-overridable were overridden by the developers writing the Glue jobs, which resulted in a failure of an ETL workflow after several hours of a job running. The reason developers were able to override the parameters is because the aws_glue_job resource (defined here: https://www.terraform.io/docs/providers/aws/r/glue_job.html) does not provide an option to give non-overridable arguments (as shown here: https://docs.aws.amazon.com/glue/latest/dg/aws-glue-api-jobs-job.html)

Our temporary solution

As a (hopefully) very temporary solution, we have modified our glue-job module to include an optional local-exec provisioner which executes a boto3 script updating the Glue job with the "NonOverridableArguments" map after the glue job has been created.

Please support this parameter!!

@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 30, 2020
@DrFaust92 DrFaust92 added service/glue Issues and PRs that pertain to the glue service. enhancement Requests to existing resources that expand the functionality or scope. labels May 21, 2020
@DrFaust92 DrFaust92 removed the needs-triage Waiting for first response or review from a maintainer. label Aug 23, 2020
@DrFaust92 DrFaust92 self-assigned this Aug 23, 2020
@breathingdust breathingdust added this to the v3.8.0 milestone Sep 22, 2020
@ghost
Copy link

ghost commented Sep 24, 2020

This has been released in version 3.8.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Oct 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 23, 2020
@DrFaust92 DrFaust92 removed their assignment Mar 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/glue Issues and PRs that pertain to the glue service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants