Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_elastictranscoder_preset: Prevent empty configuration block panics #14092

Merged
merged 1 commit into from
Jul 31, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jul 8, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #14087

Release note for CHANGELOG:

* resource/aws_elastictranscoder_preset: Prevent empty configuration block panics

Previously:

=== CONT  TestAccAWSElasticTranscoderPreset_AudioCodecOptions_empty
panic: interface conversion: interface {} is nil, not map[string]interface {}

goroutine 378 [running]:
github.com/terraform-providers/terraform-provider-aws/aws.expandETAudioCodecOptions(0xc000fb9880, 0xc0028af590)
  /Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_elastic_transcoder_preset.go:434 +0x458
github.com/terraform-providers/terraform-provider-aws/aws.expandETAudioParams(0xc000fb9880, 0xc0027d5708)
  /Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_elastic_transcoder_preset.go:423 +0x2a0
github.com/terraform-providers/terraform-provider-aws/aws.resourceAwsElasticTranscoderPresetCreate(0xc000fb9880, 0x66543e0, 0xc002660000, 0x2, 0xbbdb620)
  /Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_elastic_transcoder_preset.go:326 +0x6c

Output from acceptance testing:

--- PASS: TestAccAWSElasticTranscoderPreset_disappears (13.09s)
--- PASS: TestAccAWSElasticTranscoderPreset_AudioCodecOptions_empty (18.51s)
--- PASS: TestAccAWSElasticTranscoderPreset_Description (18.51s)
--- PASS: TestAccAWSElasticTranscoderPreset_basic (18.98s)
--- PASS: TestAccAWSElasticTranscoderPreset_Full (34.69s)

…lock panics

Reference: #14087

Previously:

```
=== CONT  TestAccAWSElasticTranscoderPreset_AudioCodecOptions_empty
panic: interface conversion: interface {} is nil, not map[string]interface {}

goroutine 378 [running]:
github.com/terraform-providers/terraform-provider-aws/aws.expandETAudioCodecOptions(0xc000fb9880, 0xc0028af590)
  /Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_elastic_transcoder_preset.go:434 +0x458
github.com/terraform-providers/terraform-provider-aws/aws.expandETAudioParams(0xc000fb9880, 0xc0027d5708)
  /Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_elastic_transcoder_preset.go:423 +0x2a0
github.com/terraform-providers/terraform-provider-aws/aws.resourceAwsElasticTranscoderPresetCreate(0xc000fb9880, 0x66543e0, 0xc002660000, 0x2, 0xbbdb620)
  /Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_elastic_transcoder_preset.go:326 +0x6c
```

Output from acceptance testing:

```
--- PASS: TestAccAWSElasticTranscoderPreset_disappears (13.09s)
--- PASS: TestAccAWSElasticTranscoderPreset_AudioCodecOptions_empty (18.51s)
--- PASS: TestAccAWSElasticTranscoderPreset_Description (18.51s)
--- PASS: TestAccAWSElasticTranscoderPreset_basic (18.98s)
--- PASS: TestAccAWSElasticTranscoderPreset_Full (34.69s)
```
@bflad bflad added bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. labels Jul 8, 2020
@bflad bflad requested a review from a team July 8, 2020 13:35
@ghost ghost added size/S Managed by automation to categorize the size of a PR. service/elastic-transcoder tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 8, 2020
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Output of acceptance tests:

--- PASS: TestAccAWSElasticTranscoderPreset_disappears (13.74s)
--- PASS: TestAccAWSElasticTranscoderPreset_basic (17.51s)
--- PASS: TestAccAWSElasticTranscoderPreset_AudioCodecOptions_empty (17.51s)
--- PASS: TestAccAWSElasticTranscoderPreset_Description (20.23s)
--- PASS: TestAccAWSElasticTranscoderPreset_Full (31.79s)

@bflad bflad added this to the v3.1.0 milestone Jul 14, 2020
@bflad bflad merged commit c6b2e16 into master Jul 31, 2020
@bflad bflad deleted the b-aws_elastictranscoder_preset-config-block-panics branch July 31, 2020 02:26
bflad added a commit that referenced this pull request Jul 31, 2020
@ghost
Copy link

ghost commented Aug 7, 2020

This has been released in version 3.1.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Aug 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_elastictranscoder_preset -> Error: rpc error: code = Unavailable desc = transport is closing
2 participants