Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve ordering in aws_fsx_lustre_file_system's network_interface_ids #14314

Conversation

mtpdt
Copy link
Contributor

@mtpdt mtpdt commented Jul 23, 2020

As explained in FSX lustre's documentation, the first network_interface_id is important and the primary one. So use a schema.TypeList instead of schema.TypeSet to preserve the ordering of this resource.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #12181

Release note for CHANGELOG:

Change `aws_fsx_lustre_file_system's`'s `network_interface_ids` to `TypeList` to preserve ordering.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSFsxLustreFileSystem_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSFsxLustreFileSystem_basic -timeout 120m
=== RUN   TestAccAWSFsxLustreFileSystem_basic
=== PAUSE TestAccAWSFsxLustreFileSystem_basic
=== CONT  TestAccAWSFsxLustreFileSystem_basic
--- PASS: TestAccAWSFsxLustreFileSystem_basic (496.35s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	496.407s

@mtpdt mtpdt changed the title Change aws_fsx_lustre_file_system's network_interface_ids to TypeList… Preserve ordering in aws_fsx_lustre_file_system's network_interface_ids Jul 23, 2020
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/fsx Issues and PRs that pertain to the fsx service. needs-triage Waiting for first response or review from a maintainer. labels Jul 23, 2020
@mtpdt mtpdt marked this pull request as ready for review July 23, 2020 14:41
@mtpdt mtpdt requested a review from a team July 23, 2020 14:41
@DrFaust92 DrFaust92 self-assigned this Jul 24, 2020
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Aug 1, 2020
@ewbankkit
Copy link
Contributor

Closes #14444.

@mtpdt
Copy link
Contributor Author

mtpdt commented Aug 1, 2020

@DrFaust92 is there a way to test this? The IDs returned from amazon are unique autogenerated uids, so it's a bit hard to test.

Let me know if additional work is needed on this PR.

@DrFaust92 DrFaust92 requested review from DrFaust92 and removed request for a team August 1, 2020 18:39
Copy link
Collaborator

@DrFaust92 DrFaust92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, LGTM. Thanks @mtpdt.

--- PASS: TestAccAWSFsxLustreFileSystem_basic (527.66s)

@DrFaust92
Copy link
Collaborator

@mtpdt. can we also add something to the docs as well to make users aware of this?

@mtpdt mtpdt force-pushed the b-aws_fsx_lustre_file_system-network_ordering branch from 06bfe23 to 2bdc0eb Compare August 2, 2020 20:43
@ghost ghost added the documentation Introduces or discusses updates to documentation. label Aug 2, 2020
@mtpdt
Copy link
Contributor Author

mtpdt commented Aug 2, 2020

@DrFaust92 done, documentation added

Copy link
Collaborator

@DrFaust92 DrFaust92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 🚀 🚀

@mtpdt
Copy link
Contributor Author

mtpdt commented Aug 17, 2020

@DrFaust92 any next steps needed on my part, or can you merge this in?

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Verified acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSFsxLustreFileSystem_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSFsxLustreFileSystem_basic -timeout 120m
=== RUN   TestAccAWSFsxLustreFileSystem_basic
=== PAUSE TestAccAWSFsxLustreFileSystem_basic
=== CONT  TestAccAWSFsxLustreFileSystem_basic
--- PASS: TestAccAWSFsxLustreFileSystem_basic (431.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	431.057s

@breathingdust
Copy link
Member

LGTM 🚀 Thanks @mtpdt for the implementation!

Verified acceptance tests:

make testacc TESTARGS='-run=TestAccAWSFsxLustreFileSystem_basic'
\==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSFsxLustreFileSystem_basic -timeout 120m
=== RUN   TestAccAWSFsxLustreFileSystem_basic
=== PAUSE TestAccAWSFsxLustreFileSystem_basic
=== CONT  TestAccAWSFsxLustreFileSystem_basic
--- PASS: TestAccAWSFsxLustreFileSystem_basic (491.03s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	494.501s

@breathingdust breathingdust added this to the v3.8.0 milestone Sep 18, 2020
@breathingdust breathingdust merged commit 37284de into hashicorp:master Sep 18, 2020
breathingdust added a commit that referenced this pull request Sep 18, 2020
@ghost
Copy link

ghost commented Sep 24, 2020

This has been released in version 3.8.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Oct 19, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 19, 2020
@mtpdt mtpdt deleted the b-aws_fsx_lustre_file_system-network_ordering branch January 4, 2021 19:04
@DrFaust92 DrFaust92 removed their assignment Jun 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/fsx Issues and PRs that pertain to the fsx service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants