Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource aws_secretsmanager_resource_policy #14618

Closed
ribeiroh opened this issue Aug 13, 2020 · 2 comments · Fixed by #14468
Closed

New resource aws_secretsmanager_resource_policy #14618

ribeiroh opened this issue Aug 13, 2020 · 2 comments · Fixed by #14468
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/secretsmanager Issues and PRs that pertain to the secretsmanager service.

Comments

@ribeiroh
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

It would be interesting to have the ability to decouple the creation of a Secrets Manager from the definition of its resource policy. This is useful if you need to "inject" the policy from a separate module, especially when that happens after the secret already exists.

New or Affected Resource(s)

  • aws_secretsmanager_resource_policy

Potential Terraform Configuration

resource "aws_secretsmanager_secret" "example" {
  name = "example"
}

resource "aws_secretsmanager_resource_policy" "example_policy {
  secret_arn = aws_secretsmanager_secret.example.arn
  block_public_policy = true
  policy = <JSON policy>
}

References

@ribeiroh ribeiroh added the enhancement Requests to existing resources that expand the functionality or scope. label Aug 13, 2020
@ghost ghost added the service/secretsmanager Issues and PRs that pertain to the secretsmanager service. label Aug 13, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Aug 13, 2020
@DrFaust92
Copy link
Collaborator

will be added in #14468

ill add block_public_policy argument as well

@DrFaust92 DrFaust92 removed the needs-triage Waiting for first response or review from a maintainer. label Aug 13, 2020
@ghost
Copy link

ghost commented Dec 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/secretsmanager Issues and PRs that pertain to the secretsmanager service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants