Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/provider: StorageGateway SMB File Share Test Fail (GovCloud) #16172

Closed
breathingdust opened this issue Nov 13, 2020 · 2 comments
Closed

tests/provider: StorageGateway SMB File Share Test Fail (GovCloud) #16172

breathingdust opened this issue Nov 13, 2020 · 2 comments
Labels
bug Addresses a defect in current functionality. partition/aws-us-gov Pertains to the aws-us-gov partition. service/storagegateway Issues and PRs that pertain to the storagegateway service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Comments

@breathingdust
Copy link
Member

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform CLI and Terraform AWS Provider Version

Affected Resource(s)

  • aws_storagegateway_smb_file_share

Terraform Configuration Files

resource "aws_storagegateway_smb_file_share" "test" {
  authentication = "ActiveDirectory"
  gateway_arn    = aws_storagegateway_gateway.test.arn
  location_arn   = aws_s3_bucket.test.arn
  role_arn       = aws_iam_role.test.arn
}

Expected Behavior

Tests should pass

Actual Behavior

Tests fail as resources are creating Simple AD which is not available in GovCloud regions. Managed AD is supported, it could be possible to change the tests to use Managed AD.

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSStorageGatewaySmbFileShare_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSStorageGatewaySmbFileShare_ -timeout 120m
=== RUN   TestAccAWSStorageGatewaySmbFileShare_Authentication_ActiveDirectory
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_Authentication_ActiveDirectory
=== RUN   TestAccAWSStorageGatewaySmbFileShare_Authentication_GuestAccess
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_Authentication_GuestAccess
=== RUN   TestAccAWSStorageGatewaySmbFileShare_DefaultStorageClass
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_DefaultStorageClass
=== RUN   TestAccAWSStorageGatewaySmbFileShare_FileShareName
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_FileShareName
=== RUN   TestAccAWSStorageGatewaySmbFileShare_Tags
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_Tags
=== RUN   TestAccAWSStorageGatewaySmbFileShare_GuessMIMETypeEnabled
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_GuessMIMETypeEnabled
=== RUN   TestAccAWSStorageGatewaySmbFileShare_InvalidUserList
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_InvalidUserList
=== RUN   TestAccAWSStorageGatewaySmbFileShare_KMSEncrypted
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_KMSEncrypted
=== RUN   TestAccAWSStorageGatewaySmbFileShare_KMSKeyArn
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_KMSKeyArn
=== RUN   TestAccAWSStorageGatewaySmbFileShare_ObjectACL
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_ObjectACL
=== RUN   TestAccAWSStorageGatewaySmbFileShare_ReadOnly
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_ReadOnly
=== RUN   TestAccAWSStorageGatewaySmbFileShare_RequesterPays
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_RequesterPays
=== RUN   TestAccAWSStorageGatewaySmbFileShare_ValidUserList
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_ValidUserList
=== RUN   TestAccAWSStorageGatewaySmbFileShare_smb_acl
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_smb_acl
=== RUN   TestAccAWSStorageGatewaySmbFileShare_audit
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_audit
=== RUN   TestAccAWSStorageGatewaySmbFileShare_cacheAttributes
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_cacheAttributes
=== RUN   TestAccAWSStorageGatewaySmbFileShare_caseSensitivity
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_caseSensitivity
=== RUN   TestAccAWSStorageGatewaySmbFileShare_disappears
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_disappears
=== RUN   TestAccAWSStorageGatewaySmbFileShare_AdminUserList
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_AdminUserList
=== CONT  TestAccAWSStorageGatewaySmbFileShare_Authentication_ActiveDirectory
=== CONT  TestAccAWSStorageGatewaySmbFileShare_caseSensitivity
=== CONT  TestAccAWSStorageGatewaySmbFileShare_GuessMIMETypeEnabled
=== CONT  TestAccAWSStorageGatewaySmbFileShare_KMSKeyArn
=== CONT  TestAccAWSStorageGatewaySmbFileShare_cacheAttributes
=== CONT  TestAccAWSStorageGatewaySmbFileShare_audit
=== CONT  TestAccAWSStorageGatewaySmbFileShare_smb_acl
=== CONT  TestAccAWSStorageGatewaySmbFileShare_ValidUserList
=== CONT  TestAccAWSStorageGatewaySmbFileShare_RequesterPays
=== CONT  TestAccAWSStorageGatewaySmbFileShare_ReadOnly
=== CONT  TestAccAWSStorageGatewaySmbFileShare_ObjectACL
=== CONT  TestAccAWSStorageGatewaySmbFileShare_AdminUserList
=== CONT  TestAccAWSStorageGatewaySmbFileShare_DefaultStorageClass
=== CONT  TestAccAWSStorageGatewaySmbFileShare_Tags
=== CONT  TestAccAWSStorageGatewaySmbFileShare_KMSEncrypted
=== CONT  TestAccAWSStorageGatewaySmbFileShare_InvalidUserList
=== CONT  TestAccAWSStorageGatewaySmbFileShare_FileShareName
=== CONT  TestAccAWSStorageGatewaySmbFileShare_disappears
=== CONT  TestAccAWSStorageGatewaySmbFileShare_Authentication_GuestAccess
=== CONT  TestAccAWSStorageGatewaySmbFileShare_AdminUserList
    resource_aws_storagegateway_smb_file_share_test.go:689: Step 1/4 error: Error running apply: 2020/11/12 16:23:45 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.10.0

        Error: ClientException: Simple AD directory creation is currently not supported in this region. : RequestId: c95b8a4e-1de9-4dfa-b5a5-f4224023f714 : RequestId: c95b8a4e-1de9-4dfa-b5a5-f4224023f714
        {
          RespMetadata: {
            StatusCode: 400,
            RequestID: "c95b8a4e-1de9-4dfa-b5a5-f4224023f714"
          },
          Message_: "Simple AD directory creation is currently not supported in this region. : RequestId: c95b8a4e-1de9-4dfa-b5a5-f4224023f714 : RequestId: c95b8a4e-1de9-4dfa-b5a5-f4224023f714",
          RequestId: "c95b8a4e-1de9-4dfa-b5a5-f4224023f714"
        }


=== CONT  TestAccAWSStorageGatewaySmbFileShare_ValidUserList
    resource_aws_storagegateway_smb_file_share_test.go:469: Step 1/4 error: Error running apply: 2020/11/12 16:23:46 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.10.0

        Error: ClientException: Simple AD directory creation is currently not supported in this region. : RequestId: 043a6dd8-26d7-417e-bb07-e343192f752c : RequestId: 043a6dd8-26d7-417e-bb07-e343192f752c
        {
          RespMetadata: {
            StatusCode: 400,
            RequestID: "043a6dd8-26d7-417e-bb07-e343192f752c"
          },
          Message_: "Simple AD directory creation is currently not supported in this region. : RequestId: 043a6dd8-26d7-417e-bb07-e343192f752c : RequestId: 043a6dd8-26d7-417e-bb07-e343192f752c",
          RequestId: "043a6dd8-26d7-417e-bb07-e343192f752c"
        }


=== CONT  TestAccAWSStorageGatewaySmbFileShare_InvalidUserList
    resource_aws_storagegateway_smb_file_share_test.go:256: Step 1/4 error: Error running apply: 2020/11/12 16:23:46 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.10.0

        Error: ClientException: Simple AD directory creation is currently not supported in this region. : RequestId: 5051a458-63bd-4ea3-a1b1-8cbfc9ebddb3 : RequestId: 5051a458-63bd-4ea3-a1b1-8cbfc9ebddb3
        {
          RespMetadata: {
            StatusCode: 400,
            RequestID: "5051a458-63bd-4ea3-a1b1-8cbfc9ebddb3"
          },
          Message_: "Simple AD directory creation is currently not supported in this region. : RequestId: 5051a458-63bd-4ea3-a1b1-8cbfc9ebddb3 : RequestId: 5051a458-63bd-4ea3-a1b1-8cbfc9ebddb3",
          RequestId: "5051a458-63bd-4ea3-a1b1-8cbfc9ebddb3"
        }


=== CONT  TestAccAWSStorageGatewaySmbFileShare_smb_acl
    resource_aws_storagegateway_smb_file_share_test.go:509: Step 1/4 error: Error running apply: 2020/11/12 16:23:45 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.10.0

        Error: ClientException: Simple AD directory creation is currently not supported in this region. : RequestId: 3e30cdad-f224-49c8-b5eb-6e567c36114a : RequestId: 3e30cdad-f224-49c8-b5eb-6e567c36114a
        {
          RespMetadata: {
            StatusCode: 400,
            RequestID: "3e30cdad-f224-49c8-b5eb-6e567c36114a"
          },
          Message_: "Simple AD directory creation is currently not supported in this region. : RequestId: 3e30cdad-f224-49c8-b5eb-6e567c36114a : RequestId: 3e30cdad-f224-49c8-b5eb-6e567c36114a",
          RequestId: "3e30cdad-f224-49c8-b5eb-6e567c36114a"
        }


=== CONT  TestAccAWSStorageGatewaySmbFileShare_Authentication_ActiveDirectory
    resource_aws_storagegateway_smb_file_share_test.go:23: Step 1/2 error: Error running apply: 2020/11/12 16:23:46 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.10.0

        Error: ClientException: Simple AD directory creation is currently not supported in this region. : RequestId: 561db9c9-1289-4f05-95f7-7b3af64d8aad : RequestId: 561db9c9-1289-4f05-95f7-7b3af64d8aad
        {
          RespMetadata: {
            StatusCode: 400,
            RequestID: "561db9c9-1289-4f05-95f7-7b3af64d8aad"
          },
          Message_: "Simple AD directory creation is currently not supported in this region. : RequestId: 561db9c9-1289-4f05-95f7-7b3af64d8aad : RequestId: 561db9c9-1289-4f05-95f7-7b3af64d8aad",
          RequestId: "561db9c9-1289-4f05-95f7-7b3af64d8aad"
        }


^CFAIL	github.com/terraform-providers/terraform-provider-aws/aws	34.620s
make: *** [testacc] Error 1

Steps to Reproduce

  1. make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSStorageGatewaySmbFileShare_'

Important Factoids

References
@breathingdust breathingdust added bug Addresses a defect in current functionality. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/storagegateway Issues and PRs that pertain to the storagegateway service. partition/aws-us-gov Pertains to the aws-us-gov partition. labels Nov 13, 2020
@breathingdust breathingdust mentioned this issue Nov 13, 2020
Merged
This was referenced Nov 26, 2020
Merged
Merged
@bflad bflad mentioned this issue Feb 3, 2021
Closed
@breathingdust breathingdust mentioned this issue Mar 17, 2021
Merged
@ewbankkit
Copy link
Contributor

These are now correctly skipping:

=== CONT  TestAccAWSStorageGatewaySmbFileShare_Authentication_ActiveDirectory
    provider_test.go:1147: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        2021/07/20 11:12:42 [DEBUG] Using modified User-Agent: Terraform/0.12.31 HashiCorp-terraform-exec/0.14.0
        
        Error: ClientException: Simple AD directory creation is currently not supported in this region. : RequestId: 2b29bbf1-70d8-4a40-a6d8-d3e3f09e7c49 : RequestId: 2b29bbf1-70d8-4a40-a6d8-d3e3f09e7c49
        {
          RespMetadata: {
            StatusCode: 400,
            RequestID: "2b29bbf1-70d8-4a40-a6d8-d3e3f09e7c49"
          },
          Message_: "Simple AD directory creation is currently not supported in this region. : RequestId: 2b29bbf1-70d8-4a40-a6d8-d3e3f09e7c49 : RequestId: 2b29bbf1-70d8-4a40-a6d8-d3e3f09e7c49",
          RequestId: "2b29bbf1-70d8-4a40-a6d8-d3e3f09e7c49"
        }
        
          on terraform_plugin_test.tf line 116, in resource "aws_directory_service_directory" "test":
         116: resource "aws_directory_service_directory" "test" {
        
        
=== CONT  TestAccAWSStorageGatewaySmbFileShare_AdminUserList
    provider_test.go:1147: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        2021/07/20 11:12:42 [DEBUG] Using modified User-Agent: Terraform/0.12.31 HashiCorp-terraform-exec/0.14.0
        
        Error: ClientException: Simple AD directory creation is currently not supported in this region. : RequestId: 3d484f20-ebd0-4bc6-a53e-7c09dc080a51 : RequestId: 3d484f20-ebd0-4bc6-a53e-7c09dc080a51
        {
          RespMetadata: {
            StatusCode: 400,
            RequestID: "3d484f20-ebd0-4bc6-a53e-7c09dc080a51"
          },
          Message_: "Simple AD directory creation is currently not supported in this region. : RequestId: 3d484f20-ebd0-4bc6-a53e-7c09dc080a51 : RequestId: 3d484f20-ebd0-4bc6-a53e-7c09dc080a51",
          RequestId: "3d484f20-ebd0-4bc6-a53e-7c09dc080a51"
        }
        
          on terraform_plugin_test.tf line 116, in resource "aws_directory_service_directory" "test":
         116: resource "aws_directory_service_directory" "test" {
        
        
=== CONT  TestAccAWSStorageGatewaySmbFileShare_ValidUserList
    provider_test.go:1147: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        2021/07/20 11:12:43 [DEBUG] Using modified User-Agent: Terraform/0.12.31 HashiCorp-terraform-exec/0.14.0
        
        Error: ClientException: Simple AD directory creation is currently not supported in this region. : RequestId: 68a94ccc-7312-4a54-91d5-42f79f9b5748 : RequestId: 68a94ccc-7312-4a54-91d5-42f79f9b5748
        {
          RespMetadata: {
            StatusCode: 400,
            RequestID: "68a94ccc-7312-4a54-91d5-42f79f9b5748"
          },
          Message_: "Simple AD directory creation is currently not supported in this region. : RequestId: 68a94ccc-7312-4a54-91d5-42f79f9b5748 : RequestId: 68a94ccc-7312-4a54-91d5-42f79f9b5748",
          RequestId: "68a94ccc-7312-4a54-91d5-42f79f9b5748"
        }
        
          on terraform_plugin_test.tf line 116, in resource "aws_directory_service_directory" "test":
         116: resource "aws_directory_service_directory" "test" {
        
        
=== CONT  TestAccAWSStorageGatewaySmbFileShare_smb_acl
    provider_test.go:1147: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        2021/07/20 11:12:41 [DEBUG] Using modified User-Agent: Terraform/0.12.31 HashiCorp-terraform-exec/0.14.0
        
        Error: ClientException: Simple AD directory creation is currently not supported in this region. : RequestId: 6a90650c-b2d6-4b68-ac9b-eb188bacf1dd : RequestId: 6a90650c-b2d6-4b68-ac9b-eb188bacf1dd
        {
          RespMetadata: {
            StatusCode: 400,
            RequestID: "6a90650c-b2d6-4b68-ac9b-eb188bacf1dd"
          },
          Message_: "Simple AD directory creation is currently not supported in this region. : RequestId: 6a90650c-b2d6-4b68-ac9b-eb188bacf1dd : RequestId: 6a90650c-b2d6-4b68-ac9b-eb188bacf1dd",
          RequestId: "6a90650c-b2d6-4b68-ac9b-eb188bacf1dd"
        }
        
          on terraform_plugin_test.tf line 116, in resource "aws_directory_service_directory" "test":
         116: resource "aws_directory_service_directory" "test" {
        
        
=== CONT  TestAccAWSStorageGatewaySmbFileShare_InvalidUserList
    provider_test.go:1147: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        2021/07/20 11:12:43 [DEBUG] Using modified User-Agent: Terraform/0.12.31 HashiCorp-terraform-exec/0.14.0
        
        Error: ClientException: Simple AD directory creation is currently not supported in this region. : RequestId: bdb1868d-7c2d-4ac9-a339-d94d73b13f00 : RequestId: bdb1868d-7c2d-4ac9-a339-d94d73b13f00
        {
          RespMetadata: {
            StatusCode: 400,
            RequestID: "bdb1868d-7c2d-4ac9-a339-d94d73b13f00"
          },
          Message_: "Simple AD directory creation is currently not supported in this region. : RequestId: bdb1868d-7c2d-4ac9-a339-d94d73b13f00 : RequestId: bdb1868d-7c2d-4ac9-a339-d94d73b13f00",
          RequestId: "bdb1868d-7c2d-4ac9-a339-d94d73b13f00"
        }
        
          on terraform_plugin_test.tf line 116, in resource "aws_directory_service_directory" "test":
         116: resource "aws_directory_service_directory" "test" {
        
        
--- SKIP: TestAccAWSStorageGatewaySmbFileShare_Authentication_ActiveDirectory (46.40s)
--- SKIP: TestAccAWSStorageGatewaySmbFileShare_AdminUserList (50.34s)
--- SKIP: TestAccAWSStorageGatewaySmbFileShare_ValidUserList (50.88s)
--- SKIP: TestAccAWSStorageGatewaySmbFileShare_smb_acl (51.27s)
--- SKIP: TestAccAWSStorageGatewaySmbFileShare_InvalidUserList (55.12s)

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. partition/aws-us-gov Pertains to the aws-us-gov partition. service/storagegateway Issues and PRs that pertain to the storagegateway service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@breathingdust @ewbankkit