Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service/ec2: Use paginated functions in plural COIP and Local Gateway data sources #16669

Merged
merged 1 commit into from
Dec 16, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Dec 9, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16659

Release note for CHANGELOG:

* data-source/aws_ec2_coip_pools: Ensure all results from large environments are returned
* data-source/aws_ec2_local_gateways: Ensure all results from large environments are returned
* data-source/aws_ec2_local_gateway_route_tables: Ensure all results from large environments are returned
* data-source/aws_ec2_local_gateway_virtual_interface_groups: Ensure all results from large environments are returned

Output from acceptance testing in OTL account:

--- PASS: TestAccDataSourceAwsEc2CoipPools_basic (12.05s)
--- PASS: TestAccDataSourceAwsEc2CoipPools_Filter (12.75s)

--- PASS: TestAccDataSourceAwsEc2LocalGateways_basic (12.35s)

--- PASS: TestAccDataSourceAwsEc2LocalGatewayRouteTables_basic (13.36s)
--- PASS: TestAccDataSourceAwsEc2LocalGatewayRouteTables_Filter (13.35s)

--- PASS: TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroups_basic (19.33s)
--- PASS: TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroups_Filter (13.43s)
--- PASS: TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroups_Tags (19.72s)

@bflad bflad added the bug Addresses a defect in current functionality. label Dec 9, 2020
@bflad bflad requested a review from a team as a code owner December 9, 2020 15:16
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. labels Dec 9, 2020
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiice Pages 🙌 Looks great 🚀

@bflad bflad added this to the v3.22.0 milestone Dec 16, 2020
@bflad bflad merged commit 6ef340c into master Dec 16, 2020
@bflad bflad deleted the b-outposts-paginators branch December 16, 2020 21:16
bflad added a commit that referenced this pull request Dec 16, 2020
@ghost
Copy link

ghost commented Dec 18, 2020

This has been released in version 3.22.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jan 16, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data.aws_ec2_coip_pools.all_coip_pools.pool_ids is set of string with 63 elements
2 participants