r/sagemaker_image_version - new resource

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #14453

Release note for CHANGELOG:

resource_aws_sagemaker_image - fix catching image not found on read error
resource_aws_sagemaker_image_version - new resource

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSagemakerImage'
--- PASS: TestAccAWSSagemakerImage_disappears (110.02s)
--- PASS: TestAccAWSSagemakerImage_basic (110.20s)
--- PASS: TestAccAWSSagemakerImage_description (170.08s)
--- PASS: TestAccAWSSagemakerImage_tags (175.43s)
--- PASS: TestAccAWSSagemakerImage_displayName (177.31s)

--- PASS: TestAccAWSSagemakerImageVersion_disappears_image (113.48s)
--- PASS: TestAccAWSSagemakerImageVersion_disappears (120.02s)
--- PASS: TestAccAWSSagemakerImageVersion_basic (120.24s)

[ewbankkit]

Verified acceptance tests:

$ SAGEMAKER_IMAGE_VERSION_BASE_IMAGE=123456789012.dkr.ecr.us-west-2.amazonaws.com/smstudio-custom:r make testacc TEST=./aws TESTARGS='-run=TestAccAWSSagemakerImageVersion_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerImageVersion_ -timeout 120m
=== RUN   TestAccAWSSagemakerImageVersion_basic
=== PAUSE TestAccAWSSagemakerImageVersion_basic
=== RUN   TestAccAWSSagemakerImageVersion_disappears
=== PAUSE TestAccAWSSagemakerImageVersion_disappears
=== RUN   TestAccAWSSagemakerImageVersion_disappears_image
=== PAUSE TestAccAWSSagemakerImageVersion_disappears_image
=== CONT  TestAccAWSSagemakerImageVersion_basic
=== CONT  TestAccAWSSagemakerImageVersion_disappears_image
=== CONT  TestAccAWSSagemakerImageVersion_disappears
--- PASS: TestAccAWSSagemakerImageVersion_disappears (79.53s)
--- PASS: TestAccAWSSagemakerImageVersion_disappears_image (79.93s)
--- PASS: TestAccAWSSagemakerImageVersion_basic (82.12s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	82.204s

[DrFaust92]

removed update func:

--- PASS: TestAccAWSSagemakerImageVersion_disappears_image (111.36s)
--- PASS: TestAccAWSSagemakerImageVersion_disappears (115.11s)
--- PASS: TestAccAWSSagemakerImageVersion_basic (121.58s)

[ewbankkit]

LGTM.

$ SAGEMAKER_IMAGE_VERSION_BASE_IMAGE=123456789012.dkr.ecr.us-west-2.amazonaws.com/smstudio-custom:r make testacc TEST=./aws TESTARGS='-run=TestAccAWSSagemakerImageVersion_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerImageVersion_ -timeout 120m
=== RUN   TestAccAWSSagemakerImageVersion_basic
=== PAUSE TestAccAWSSagemakerImageVersion_basic
=== RUN   TestAccAWSSagemakerImageVersion_disappears
=== PAUSE TestAccAWSSagemakerImageVersion_disappears
=== RUN   TestAccAWSSagemakerImageVersion_disappears_image
=== PAUSE TestAccAWSSagemakerImageVersion_disappears_image
=== CONT  TestAccAWSSagemakerImageVersion_basic
=== CONT  TestAccAWSSagemakerImageVersion_disappears_image
=== CONT  TestAccAWSSagemakerImageVersion_disappears
--- PASS: TestAccAWSSagemakerImageVersion_disappears_image (79.56s)
--- PASS: TestAccAWSSagemakerImageVersion_disappears (80.94s)
--- PASS: TestAccAWSSagemakerImageVersion_basic (88.03s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	88.101s

[breathingdust]

LGTM 🚀 Thanks @DrFaust92!

Verified Acceptance Tests in Commercial (us-west-2)

--- PASS: TestAccAWSSagemakerImage_basic (83.76s)
--- PASS: TestAccAWSSagemakerImage_disappears (94.06s)
--- PASS: TestAccAWSSagemakerImage_displayName (111.35s)
--- PASS: TestAccAWSSagemakerImage_description (112.63s)
--- PASS: TestAccAWSSagemakerImage_tags (113.64s)

SAGEMAKER_IMAGE_VERSION_BASE_IMAGE=1234567890.dkr.ecr.us-east-1.amazonaws.com/smtest:r make testacc TEST=./aws TESTARGS='-run=TestAccAWSSagemakerImageVersion_'

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerImageVersion_ -timeout 120m
=== RUN   TestAccAWSSagemakerImageVersion_basic
=== PAUSE TestAccAWSSagemakerImageVersion_basic
=== RUN   TestAccAWSSagemakerImageVersion_disappears
=== PAUSE TestAccAWSSagemakerImageVersion_disappears
=== RUN   TestAccAWSSagemakerImageVersion_disappears_image
=== PAUSE TestAccAWSSagemakerImageVersion_disappears_image
=== CONT  TestAccAWSSagemakerImageVersion_basic
=== CONT  TestAccAWSSagemakerImageVersion_disappears_image
=== CONT  TestAccAWSSagemakerImageVersion_disappears
--- PASS: TestAccAWSSagemakerImageVersion_disappears_image (86.24s)
--- PASS: TestAccAWSSagemakerImageVersion_disappears (86.71s)
--- PASS: TestAccAWSSagemakerImageVersion_basic (87.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	88.845s

As this is part of SageMaker Studio this is not expected to work in GovCloud, however we will need to detect and skip Studio features when running the acceptance tests in that partition. I will link an issue back here which will track that work.

[ghost]

This has been released in version 3.25.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!