aws_cloudwatch_log_metric_filter pattern character limit incorrect

[michaelmcguinness]

Terraform Version

0.10.7

Affected Resource(s)

aws_cloudwatch_log_metric_filter

Issue

The pattern argument is restricted to 512 characters. I believe this should be 1024 characters as per the documentation here: http://docs.aws.amazon.com/AmazonCloudWatchLogs/latest/APIReference/API_PutMetricFilter.html

Manual configuration confirms that patterns can be greater than 512 characters.

Terraform Code

	return &schema.Resource{
		Create: resourceAwsCloudWatchLogMetricFilterUpdate,
		Read:   resourceAwsCloudWatchLogMetricFilterRead,
		Update: resourceAwsCloudWatchLogMetricFilterUpdate,
		Delete: resourceAwsCloudWatchLogMetricFilterDelete,

		Schema: map[string]*schema.Schema{
			"name": &schema.Schema{
				Type:         schema.TypeString,
				Required:     true,
				ForceNew:     true,
				ValidateFunc: validateLogMetricFilterName,
			},

			"pattern": &schema.Schema{
				Type:         schema.TypeString,
				Required:     true,
				ValidateFunc: validateMaxLength(512),
				StateFunc: func(v interface{}) string {
					s, ok := v.(string)
					if !ok {
						return ""
					}
					return strings.TrimSpace(s)
				},
			},

[atsushi-ishibashi]

Fixed #2107

[Ninir]

Thanks for the ping @atsushi-ishibashi :)

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!