Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_vpc_endpoint_route_table_association: Handle read-after-create eventual consistency #18465

Merged
merged 1 commit into from
Apr 2, 2021
Merged

resource/aws_vpc_endpoint_route_table_association: Handle read-after-create eventual consistency #18465

merged 1 commit into from
Apr 2, 2021

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Mar 29, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12449
Reference: #16796

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSVpcEndpointRouteTableAssociation_basic (36.76s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSVpcEndpointRouteTableAssociation_basic (40.65s)

@bflad
resource/aws_vpc_endpoint_route_table_association: Handle read-after-…
4c40745 
…create eventual consistency

Reference: #12449
Reference: #16796

Output from acceptance testing in AWS Commercial:

```
--- PASS: TestAccAWSVpcEndpointRouteTableAssociation_basic (36.76s)
```

Output from acceptance testing in AWS GovCloud (US):

```
--- PASS: TestAccAWSVpcEndpointRouteTableAssociation_basic (40.65s)
```
@bflad bflad added the bug Addresses a defect in current functionality. label Mar 29, 2021
@bflad bflad requested a review from a team as a code owner March 29, 2021 18:57
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. labels Mar 29, 2021
@ewbankkit ewbankkit mentioned this pull request Mar 31, 2021
Merged
@YakDriver YakDriver self-assigned this Apr 1, 2021
YakDriver
YakDriver approved these changes Apr 1, 2021
View reviewed changes
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Underbar! 🎉

Acceptance tests (GovCloud):

--- PASS: TestAccAWSVpcEndpointRouteTableAssociation_basic (41.17s)

Acceptance tests (commercial):

--- PASS: TestAccAWSVpcEndpointRouteTableAssociation_basic (35.53s)

@bflad bflad merged commit d46f920 into main Apr 2, 2021
@bflad bflad deleted the b-aws_vpc_endpoint_route_table_association-IsNewResource branch April 2, 2021 00:56
bflad added a commit that referenced this pull request Apr 2, 2021
@bflad
Update CHANGELOG for #18465
ee5b385
@ghost
Copy link

ghost commented May 2, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators May 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@YakDriver YakDriver YakDriver approved these changes

Assignees

@YakDriver YakDriver

Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provider produced inconsistent result after apply - aws_vpc_endpoint_route_table_association.s3_vpc_endpoint
2 participants
@bflad @YakDriver