r/aws_lakeformation_permissions: don't throw no permissions found #18505

jackbatzner · 2021-03-31T16:02:19Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #18446
Closes #17633
Closes #19063
Closes #19064

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSLakeFormation_serial'

--- PASS: TestAccAWSLakeFormation_serial (488.77s)
    --- PASS: TestAccAWSLakeFormation_serial/DataSourcePermissions (171.09s)
        --- PASS: TestAccAWSLakeFormation_serial/DataSourcePermissions/tableWithColumnsDataSource (39.37s)
        --- PASS: TestAccAWSLakeFormation_serial/DataSourcePermissions/basicDataSource (36.57s)
        --- PASS: TestAccAWSLakeFormation_serial/DataSourcePermissions/dataLocationDataSource (35.27s)
        --- PASS: TestAccAWSLakeFormation_serial/DataSourcePermissions/databaseDataSource (28.64s)
        --- PASS: TestAccAWSLakeFormation_serial/DataSourcePermissions/tableDataSource (31.24s)
    --- PASS: TestAccAWSLakeFormation_serial/DataLakeSettings (75.14s)
        --- PASS: TestAccAWSLakeFormation_serial/DataLakeSettings/dataSource (17.86s)
        --- PASS: TestAccAWSLakeFormation_serial/DataLakeSettings/basic (17.49s)
        --- PASS: TestAccAWSLakeFormation_serial/DataLakeSettings/disappears (20.21s)
        --- PASS: TestAccAWSLakeFormation_serial/DataLakeSettings/withoutCatalogId (19.58s)
    --- PASS: TestAccAWSLakeFormation_serial/Permissions (134.94s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/dataLocation (28.30s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/database (26.42s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/selectPermissions (27.54s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/wildcardPermissions (27.31s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/basic (25.38s)
    --- PASS: TestAccAWSLakeFormation_serial/TablePermissions (107.60s)
        --- PASS: TestAccAWSLakeFormation_serial/TablePermissions/tableName (28.13s)
        --- PASS: TestAccAWSLakeFormation_serial/TablePermissions/tableWildcard (25.02s)
        --- PASS: TestAccAWSLakeFormation_serial/TablePermissions/tableWithColumns (26.94s)
        --- PASS: TestAccAWSLakeFormation_serial/TablePermissions/tableWithColumnsAndTable (27.51s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       492.418s
...

jackbatzner · 2021-03-31T16:03:10Z

Reproduced bug with wildcardPermissions test

=== RUN   TestAccAWSLakeFormation_serial/Permissions/wildcardPermissions
    resource_aws_lakeformation_permissions_test.go:246: Step 1/1 error: Error running apply: exit status 1
        
        Error: error reading Lake Formation permissions: no permissions found
        
          on terraform_plugin_test.tf line 56, in resource "aws_lakeformation_permissions" "test":
          56: resource "aws_lakeformation_permissions" "test" {

YakDriver · 2021-04-29T19:38:09Z

Additional Principals	Perm Delete/Revoke
Related #16848 (Issue) Related #16916 Related #18034 (Issue) Related #18374	Related #17633 (Issue) Related #18446 (Issue) Related #18505 Related #19063 (Issue) Related #19064 (Issue)

YakDriver

Looks great! 🎉

Output from acceptance tests (us-west-2):

--- PASS: TestAccAWSLakeFormation_serial (444.71s)
    --- PASS: TestAccAWSLakeFormation_serial/TablePermissions (202.75s)
        --- PASS: TestAccAWSLakeFormation_serial/TablePermissions/implicitTablePermissions (33.20s)
        --- PASS: TestAccAWSLakeFormation_serial/TablePermissions/selectPermissions (25.30s)
        --- PASS: TestAccAWSLakeFormation_serial/TablePermissions/tableName (25.13s)
        --- PASS: TestAccAWSLakeFormation_serial/TablePermissions/tableWildcard (21.92s)
        --- PASS: TestAccAWSLakeFormation_serial/TablePermissions/tableWildcardPermissions (24.59s)
        --- PASS: TestAccAWSLakeFormation_serial/TablePermissions/tableWithColumns (24.64s)
        --- PASS: TestAccAWSLakeFormation_serial/TablePermissions/columnWildcardPermissions (24.67s)
        --- PASS: TestAccAWSLakeFormation_serial/TablePermissions/implicitTableWithColumnsPermissions (23.30s)
    --- PASS: TestAccAWSLakeFormation_serial/DataSourcePermissions (130.47s)
        --- PASS: TestAccAWSLakeFormation_serial/DataSourcePermissions/basicDataSource (22.09s)
        --- PASS: TestAccAWSLakeFormation_serial/DataSourcePermissions/dataLocationDataSource (26.89s)
        --- PASS: TestAccAWSLakeFormation_serial/DataSourcePermissions/databaseDataSource (26.44s)
        --- PASS: TestAccAWSLakeFormation_serial/DataSourcePermissions/tableDataSource (28.89s)
        --- PASS: TestAccAWSLakeFormation_serial/DataSourcePermissions/tableWithColumnsDataSource (26.15s)
    --- PASS: TestAccAWSLakeFormation_serial/DataLakeSettings (44.09s)
        --- PASS: TestAccAWSLakeFormation_serial/DataLakeSettings/basic (10.74s)
        --- PASS: TestAccAWSLakeFormation_serial/DataLakeSettings/disappears (10.75s)
        --- PASS: TestAccAWSLakeFormation_serial/DataLakeSettings/withoutCatalogId (10.53s)
        --- PASS: TestAccAWSLakeFormation_serial/DataLakeSettings/dataSource (12.07s)
    --- PASS: TestAccAWSLakeFormation_serial/BasicPermissions (67.40s)
        --- PASS: TestAccAWSLakeFormation_serial/BasicPermissions/basic (21.02s)
        --- PASS: TestAccAWSLakeFormation_serial/BasicPermissions/dataLocation (24.79s)
        --- PASS: TestAccAWSLakeFormation_serial/BasicPermissions/database (21.59s)

Output from acceptance tests (GovCloud):

--- PASS: TestAccAWSLakeFormation_serial (471.33s)
    --- PASS: TestAccAWSLakeFormation_serial/TablePermissions (200.00s)
        --- PASS: TestAccAWSLakeFormation_serial/TablePermissions/tableWildcardPermissions (24.89s)
        --- PASS: TestAccAWSLakeFormation_serial/TablePermissions/tableWithColumns (23.65s)
        --- PASS: TestAccAWSLakeFormation_serial/TablePermissions/columnWildcardPermissions (23.82s)
        --- PASS: TestAccAWSLakeFormation_serial/TablePermissions/implicitTableWithColumnsPermissions (29.06s)
        --- PASS: TestAccAWSLakeFormation_serial/TablePermissions/implicitTablePermissions (24.46s)
        --- PASS: TestAccAWSLakeFormation_serial/TablePermissions/selectPermissions (23.46s)
        --- PASS: TestAccAWSLakeFormation_serial/TablePermissions/tableName (23.63s)
        --- PASS: TestAccAWSLakeFormation_serial/TablePermissions/tableWildcard (27.03s)
    --- PASS: TestAccAWSLakeFormation_serial/DataSourcePermissions (138.36s)
        --- PASS: TestAccAWSLakeFormation_serial/DataSourcePermissions/dataLocationDataSource (27.26s)
        --- PASS: TestAccAWSLakeFormation_serial/DataSourcePermissions/databaseDataSource (31.00s)
        --- PASS: TestAccAWSLakeFormation_serial/DataSourcePermissions/tableDataSource (27.45s)
        --- PASS: TestAccAWSLakeFormation_serial/DataSourcePermissions/tableWithColumnsDataSource (24.61s)
        --- PASS: TestAccAWSLakeFormation_serial/DataSourcePermissions/basicDataSource (28.04s)
    --- PASS: TestAccAWSLakeFormation_serial/DataLakeSettings (60.18s)
        --- PASS: TestAccAWSLakeFormation_serial/DataLakeSettings/withoutCatalogId (14.57s)
        --- PASS: TestAccAWSLakeFormation_serial/DataLakeSettings/dataSource (15.98s)
        --- PASS: TestAccAWSLakeFormation_serial/DataLakeSettings/basic (14.66s)
        --- PASS: TestAccAWSLakeFormation_serial/DataLakeSettings/disappears (14.97s)
    --- PASS: TestAccAWSLakeFormation_serial/BasicPermissions (72.79s)
        --- PASS: TestAccAWSLakeFormation_serial/BasicPermissions/basic (22.55s)
        --- PASS: TestAccAWSLakeFormation_serial/BasicPermissions/dataLocation (27.54s)
        --- PASS: TestAccAWSLakeFormation_serial/BasicPermissions/database (22.70s)

ghost · 2021-05-07T00:07:31Z

This has been released in version 3.39.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

github-actions · 2021-06-06T02:34:06Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

jackbatzner requested a review from a team as a code owner March 31, 2021 16:02

ghost added size/M Managed by automation to categorize the size of a PR. service/lakeformation Issues and PRs that pertain to the lakeformation service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 31, 2021

github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 31, 2021

jackbatzner changed the title ~~[WIP] r/aws_lakeformation_permissions: don't throw no permissions found~~ r/aws_lakeformation_permissions: don't throw no permissions found Mar 31, 2021

jackbatzner mentioned this pull request Apr 27, 2021

aws_lakeformation_permissions tries to revoke non-existent permissions #17633

Closed

YakDriver self-assigned this Apr 28, 2021

This was referenced Apr 29, 2021

Support AWS account IDs as valid lakeformation principals #18374

Closed

Support for SAML/AD principals in aws_lakeformation_permissions #16848

Closed

aws_lakeformation_permissions throwing "no permissions found" for wildcard table #18446

Closed

YakDriver added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 29, 2021

YakDriver mentioned this pull request Apr 29, 2021

Lakeformation permission for external account access fails validation #18034

Closed

YakDriver force-pushed the b-aws_lakeformation_permissions-no-perms-found branch from 9f549e5 to 1e428d8 Compare April 29, 2021 21:34

Brunhil and others added 3 commits May 4, 2021 19:20

Write test to confirm bug hashicorp#18446

8ddc68b

Don't throw error when no permissions exist

d97c697

utils: Add slice comparison helpers

68dee8e

YakDriver added 8 commits May 4, 2021 19:20

tests/utils: Test slice comparison helpers

35b253f

docs/r/lakeformation_permissions: Revise docs

dc9cb7d

tests/lakeformation: Add new tests

f21b343

tests/r/lakeformation_permissions: Rework tests

1b20778

r/lakeformation_permissions: Rework permissions

3140172

ds/lakeformation_permissions: Revise for permissions rework

1f0971e

tests/ds/lakeformation_permissions: Test permissions rework

fafb6f8

r/lakeformation_permissions: Update changelog

1c677ea

YakDriver force-pushed the b-aws_lakeformation_permissions-no-perms-found branch from 4677cf8 to 1c677ea Compare May 4, 2021 23:24

tests/r/lakeformation_permissions: Lint

36fc0cd

YakDriver added this to the v3.39.0 milestone May 4, 2021

tests/r/lakeformation_permissions: Lint

2110ac9

YakDriver approved these changes May 4, 2021

View reviewed changes

YakDriver merged commit b15be48 into hashicorp:main May 5, 2021

ewbankkit mentioned this pull request May 25, 2021

aws_lakeformation_permissions plugin crashes with transport error in 0.15.4 #19518

Closed

github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

r/aws_lakeformation_permissions: don't throw no permissions found #18505

r/aws_lakeformation_permissions: don't throw no permissions found #18505

jackbatzner commented Mar 31, 2021 •

edited by YakDriver

Loading

jackbatzner commented Mar 31, 2021

YakDriver commented Apr 29, 2021 •

edited

Loading

YakDriver left a comment

ghost commented May 7, 2021

github-actions bot commented Jun 6, 2021

r/aws_lakeformation_permissions: don't throw no permissions found #18505

r/aws_lakeformation_permissions: don't throw no permissions found #18505

Conversation

jackbatzner commented Mar 31, 2021 • edited by YakDriver Loading

Community Note

jackbatzner commented Mar 31, 2021

YakDriver commented Apr 29, 2021 • edited Loading

YakDriver left a comment

Choose a reason for hiding this comment

ghost commented May 7, 2021

github-actions bot commented Jun 6, 2021

jackbatzner commented Mar 31, 2021 •

edited by YakDriver

Loading

YakDriver commented Apr 29, 2021 •

edited

Loading