resource/aws_s3_bucket: Lifecycle Rule Eventual Consistency

[bflad]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The TestAccAWSS3Bucket_LifecycleBasic acceptance test is particularly flaky in AWS GovCloud (US), but typically fine in AWS Commercial. Example errors:

=== CONT  TestAccAWSS3Bucket_LifecycleBasic
    resource_aws_s3_bucket_test.go:1267: Step 3/4 error: Check failed: Check 5/14 error: aws_s3_bucket.bucket: Attribute 'lifecycle_rule.0.noncurrent_version_expiration.0.days' not found
--- FAIL: TestAccAWSS3Bucket_LifecycleBasic (45.47s)

=== CONT  TestAccAWSS3Bucket_LifecycleBasic
    resource_aws_s3_bucket_test.go:1267: Step 4/4 error: After applying this test step, the plan was not empty.
        stdout:


        An execution plan has been generated and is shown below.
        Resource actions are indicated with the following symbols:
          ~ update in-place

        Terraform will perform the following actions:

          # aws_s3_bucket.bucket will be updated in-place
          ~ resource "aws_s3_bucket" "bucket" {
                id                          = "tf-test-bucket-2465403739993944642"
                tags                        = {}
                # (9 unchanged attributes hidden)

              - lifecycle_rule {
                  - abort_incomplete_multipart_upload_days = 0 -> null
                  - enabled                                = true -> null
                  - id                                     = "id1" -> null
                  - prefix                                 = "path1/" -> null
                  - tags                                   = {} -> null

                  - noncurrent_version_expiration {
                      - days = 365 -> null
                    }

                  - noncurrent_version_transition {
                      - days          = 30 -> null
                      - storage_class = "STANDARD_IA" -> null
                    }
                  - noncurrent_version_transition {
                      - days          = 60 -> null
                      - storage_class = "GLACIER" -> null
                    }
                }
              - lifecycle_rule {
                  - abort_incomplete_multipart_upload_days = 0 -> null
                  - enabled                                = false -> null
                  - id                                     = "id2" -> null
                  - prefix                                 = "path2/" -> null
                  - tags                                   = {} -> null

                  - noncurrent_version_expiration {
                      - days = 365 -> null
                    }
                }
              - lifecycle_rule {
                  - abort_incomplete_multipart_upload_days = 0 -> null
                  - enabled                                = true -> null
                  - id                                     = "id3" -> null
                  - prefix                                 = "path3/" -> null
                  - tags                                   = {} -> null

                  - noncurrent_version_transition {
                      - days          = 0 -> null
                      - storage_class = "GLACIER" -> null
                    }
                }

                # (1 unchanged block hidden)
            }

        Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccAWSS3Bucket_LifecycleBasic (73.04s)

If it was a simple attribute type, it could likely be mitigated with an attribute waiter, but the TypeSet usage likely complicates this issue since the comparison operations may not align well if the configuration and state values canonicalize differently.

Affected Resource(s)

• aws_s3_bucket

References

• resource/aws_s3_bucket: Add d.IsNewResource() checks before removing from state #18488 (review)

[github-actions]

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.