tests/resource/aws_sfn_state_machine: Consistent Update Test Failures

[bflad]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The following acceptance testing fails consistently:

=== CONT  TestAccAWSSfnStateMachine_standardUpdate
resource_aws_sfn_state_machine_test.go:104: Step 2/2 error: Check failed: Check 5/7 error: aws_sfn_state_machine.foo: Attribute 'definition' didn't match ".*\\\"MaxAttempts\\\": 10.*", got "{\n  \"Comment\": \"A Hello World example of the Amazon States Language using an AWS Lambda Function with STANDARD State Machine\",\n  \"StartAt\": \"HelloWorld\",\n  \"States\": {\n    \"HelloWorld\": {\n      \"Type\": \"Task\",\n      \"Resource\": \"arn:aws:lambda:us-west-2:*******:function:sfn-x9wed6g89w\",\n      \"Retry\": [\n        {\n          \"ErrorEquals\": [\"States.ALL\"],\n          \"IntervalSeconds\": 5,\n          \"MaxAttempts\": 5,\n          \"BackoffRate\": 8.0\n        }\n      ],\n      \"End\": true\n    }\n  }\n}\n"
--- FAIL: TestAccAWSSfnStateMachine_standardUpdate (67.36s)

=== CONT  TestAccAWSSfnStateMachine_createUpdate
resource_aws_sfn_state_machine_test.go:21: Step 3/3 error: Check failed: Check 6/7 error: aws_sfn_state_machine.test: Attribute 'definition' didn't match ".*\\\"MaxAttempts\\\": 10.*", got "{\n  \"Comment\": \"A Hello World example of the Amazon States Language using an AWS Lambda Function\",\n  \"StartAt\": \"HelloWorld\",\n  \"States\": {\n    \"HelloWorld\": {\n      \"Type\": \"Task\",\n      \"Resource\": \"arn:aws:lambda:us-west-2:*******:function:tf-acc-test-6443416242939935176\",\n      \"Retry\": [\n        {\n          \"ErrorEquals\": [\n            \"States.ALL\"\n          ],\n          \"IntervalSeconds\": 5,\n          \"MaxAttempts\": 5,\n          \"BackoffRate\": 8\n        }\n      ],\n      \"End\": true\n    }\n  }\n}\n"
--- FAIL: TestAccAWSSfnStateMachine_createUpdate (84.29s)

=== CONT  TestAccAWSSfnStateMachine_expressUpdate
resource_aws_sfn_state_machine_test.go:65: Step 2/2 error: Check failed: Check 5/7 error: aws_sfn_state_machine.foo: Attribute 'definition' didn't match ".*\\\"MaxAttempts\\\": 10.*", got "{\n  \"Comment\": \"A Hello World example of the Amazon States Language using an AWS Lambda Function with EXPRESS State Machine\",\n  \"StartAt\": \"HelloWorld\",\n  \"States\": {\n    \"HelloWorld\": {\n      \"Type\": \"Task\",\n      \"Resource\": \"arn:aws:lambda:us-west-2:*******:function:sfn-fc7q9f7z80\",\n      \"Retry\": [\n        {\n          \"ErrorEquals\": [\"States.ALL\"],\n          \"IntervalSeconds\": 5,\n          \"MaxAttempts\": 5,\n          \"BackoffRate\": 8.0\n        }\n      ],\n      \"End\": true\n    }\n  }\n}\n"
--- FAIL: TestAccAWSSfnStateMachine_expressUpdate (132.07s)

There are a few things to check:

• Test checks match the test configuration
• The resource properly calls the API to update
• If the resource updates need an API status waiter or Terraform attribute waiter

Affected Resource

• aws_sfn_state_machine

References

Potentially related:

• Chaning definition of aws_sfn_state_machine doesn't update the state machine in AWS #12506

[ewbankkit]

Related:

• tests/resource/aws_sfn_state_machine: TestAccAWSSfnStateMachine_expressLoggingConfiguration Configuration Error #18614

I will (attempt to) address this while merging #15434.

[ghost]

This has been released in version 3.39.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.