Removes plan-time validation for automatic_failover_enabled

[gdavison]

The plan-time validation also depends on whether the parameter group used enables Redis cluster mode, that is, setting the parameter cluster-enabled to yes. If so, automatic_failover_enabled must be true, otherwise, the replication group must have at least two clusters.

By disabling plan-time validation, we allow the AWS API to perform the correct validation.

Closes #18522

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSElasticacheReplicationGroup_'

--- PASS: TestAccAWSElasticacheReplicationGroup_Validation_NoNodeType (69.27s)
--- PASS: TestAccAWSElasticacheReplicationGroup_basic (875.31s)
--- PASS: TestAccAWSElasticacheReplicationGroup_clusteringAndCacheNodesCausesError (7.18s)
--- PASS: TestAccAWSElasticacheReplicationGroup_enableSnapshotting (936.69s)
--- PASS: TestAccAWSElasticacheReplicationGroup_Validation_GlobalReplicationGroupIdAndNodeType (957.94s)
--- PASS: TestAccAWSElasticacheReplicationGroup_tags (994.14s)
--- PASS: TestAccAWSElasticacheReplicationGroup_useCmkKmsKeyId (1147.09s)
--- PASS: TestAccAWSElasticacheReplicationGroup_enableAuthTokenTransitEncryption (1148.37s)
--- PASS: TestAccAWSElasticacheReplicationGroup_enableAtRestEncryption (1209.74s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_RemoveMemberCluster_AtTargetSize (1369.61s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_RemoveMemberCluster_ScaleDown (1400.00s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MultiAZEnabled (1607.28s)
--- PASS: TestAccAWSElasticacheReplicationGroup_FinalSnapshot (1707.20s)
--- PASS: TestAccAWSElasticacheReplicationGroup_Validation_multiAz_NoAutomaticFailover (9.34s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Failover_AutoFailoverDisabled (1829.12s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_NoChange (2134.73s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Basic (2179.75s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_SingleNode (1350.87s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_NonClusteredParameterGroup (1121.13s)
--- FAIL: TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_Full (2348.58s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_AddMemberCluster (2413.39s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_Basic (1100.41s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateReplicasPerNodeGroup (1686.20s)
--- PASS: TestAccAWSElasticacheReplicationGroup_multiAzInVpc (915.66s)
--- PASS: TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_disappears (2756.72s)
--- PASS: TestAccAWSElasticacheReplicationGroup_updateDescription (1182.39s)
--- PASS: TestAccAWSElasticacheReplicationGroup_updateParameterGroup (1390.26s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Failover_AutoFailoverEnabled (2919.97s)
--- PASS: TestAccAWSElasticacheReplicationGroup_vpc (876.68s)
--- PASS: TestAccAWSElasticacheReplicationGroup_updateMaintenanceWindow (1095.95s)
--- FAIL: TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_Basic (3239.27s)
--- PASS: TestAccAWSElasticacheReplicationGroup_Uppercase (1005.35s)
--- PASS: TestAccAWSElasticacheReplicationGroup_disappears (1229.63s)
--- PASS: TestAccAWSElasticacheReplicationGroup_redisClusterInVpc2 (3532.91s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroupsAndReplicasPerNodeGroup_ScaleUp (2658.64s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroupsAndReplicasPerNodeGroup_ScaleDown (2788.05s)
--- PASS: TestAccAWSElasticacheReplicationGroup_updateNodeSize (2354.06s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroups_ScaleUp (3088.55s)
--- PASS: TestAccAWSElasticacheReplicationGroup_multiAzNotInVpc (2000.41s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroups_ScaleDown (3590.34s)

The test failures TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_Full and TestAccAWSElasticacheReplicationGroup_GlobalReplicationGroupId_Basic are related to #18625

[bflad]

Looks good to me 🚀

[ghost]

This has been released in version 3.36.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!