Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_route53_resolver_firewall_rule: Add new resource #18712

Merged
merged 5 commits into from
Apr 29, 2021

Conversation

gazoakley
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #18520

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSRoute53ResolverFirewallRule_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRoute53ResolverFirewallRule_ -timeout 180m
=== RUN   TestAccAWSRoute53ResolverFirewallRule_basic
=== PAUSE TestAccAWSRoute53ResolverFirewallRule_basic
=== RUN   TestAccAWSRoute53ResolverFirewallRule_block
=== PAUSE TestAccAWSRoute53ResolverFirewallRule_block
=== RUN   TestAccAWSRoute53ResolverFirewallRule_blockOverride
=== PAUSE TestAccAWSRoute53ResolverFirewallRule_blockOverride
=== RUN   TestAccAWSRoute53ResolverFirewallRule_disappears
=== PAUSE TestAccAWSRoute53ResolverFirewallRule_disappears
=== CONT  TestAccAWSRoute53ResolverFirewallRule_basic
=== CONT  TestAccAWSRoute53ResolverFirewallRule_disappears
=== CONT  TestAccAWSRoute53ResolverFirewallRule_block
=== CONT  TestAccAWSRoute53ResolverFirewallRule_blockOverride
--- PASS: TestAccAWSRoute53ResolverFirewallRule_disappears (96.17s)
--- PASS: TestAccAWSRoute53ResolverFirewallRule_block (98.79s)
--- PASS: TestAccAWSRoute53ResolverFirewallRule_blockOverride (99.04s)
--- PASS: TestAccAWSRoute53ResolverFirewallRule_basic (99.51s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	103.330s

@gazoakley gazoakley requested a review from a team as a code owner April 9, 2021 16:20
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/route53resolver Issues and PRs that pertain to the route53resolver service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 9, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 9, 2021
@gazoakley gazoakley force-pushed the f-route53resolver-firewall-rule branch from 7ca02d7 to 23c6ac9 Compare April 9, 2021 16:33
@gazoakley
Copy link
Contributor Author

Based on #18558 - will rebase if necessary after review

@gazoakley gazoakley force-pushed the f-route53resolver-firewall-rule branch 2 times, most recently from 402607b to 08476a3 Compare April 10, 2021 21:01
@gazoakley gazoakley force-pushed the f-route53resolver-firewall-rule branch from 08476a3 to 34f0f80 Compare April 11, 2021 13:13
@gazoakley gazoakley force-pushed the f-route53resolver-firewall-rule branch from 34f0f80 to aef3605 Compare April 16, 2021 07:20
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. and removed size/XXL Managed by automation to categorize the size of a PR. labels Apr 16, 2021
@gazoakley
Copy link
Contributor Author

Hi @ewbankkit - was about to make those same changes myself 😄 . The sweeper also needs fixing - I'll take a look at that shortly

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute53ResolverFirewallRule_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRoute53ResolverFirewallRule_ -timeout 180m
=== RUN   TestAccAWSRoute53ResolverFirewallRule_basic
=== PAUSE TestAccAWSRoute53ResolverFirewallRule_basic
=== RUN   TestAccAWSRoute53ResolverFirewallRule_block
=== PAUSE TestAccAWSRoute53ResolverFirewallRule_block
=== RUN   TestAccAWSRoute53ResolverFirewallRule_blockOverride
=== PAUSE TestAccAWSRoute53ResolverFirewallRule_blockOverride
=== RUN   TestAccAWSRoute53ResolverFirewallRule_disappears
=== PAUSE TestAccAWSRoute53ResolverFirewallRule_disappears
=== CONT  TestAccAWSRoute53ResolverFirewallRule_basic
=== CONT  TestAccAWSRoute53ResolverFirewallRule_disappears
=== CONT  TestAccAWSRoute53ResolverFirewallRule_blockOverride
=== CONT  TestAccAWSRoute53ResolverFirewallRule_block
--- PASS: TestAccAWSRoute53ResolverFirewallRule_disappears (76.91s)
--- PASS: TestAccAWSRoute53ResolverFirewallRule_block (78.08s)
--- PASS: TestAccAWSRoute53ResolverFirewallRule_basic (79.02s)
--- PASS: TestAccAWSRoute53ResolverFirewallRule_blockOverride (79.29s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	79.384s

@ewbankkit ewbankkit self-assigned this Apr 16, 2021
@YakDriver YakDriver removed the needs-triage Waiting for first response or review from a maintainer. label Apr 16, 2021
@ewbankkit ewbankkit merged commit 33d2908 into hashicorp:main Apr 29, 2021
@github-actions github-actions bot added this to the v3.38.0 milestone Apr 29, 2021
@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 3.38.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/route53resolver Issues and PRs that pertain to the route53resolver service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants