Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement AWS App Runner resources #19432

Merged
merged 15 commits into from
May 19, 2021
Merged

Implement AWS App Runner resources #19432

merged 15 commits into from
May 19, 2021

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented May 18, 2021 •
edited
Loading

Implements AWS App Runner resources:

  • aws_apprunner_auto_scaling_configuration_version
  • aws_apprunner_connection
  • aws_apprunner_custom_domain_association
  • aws_apprunner_service

Announcement: https://aws.amazon.com/about-aws/whats-new/2021/05/aws-announces-aws-app-runner/
Service Documentation: https://aws.amazon.com/apprunner/

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAwsAppRunner'

--- FAIL: TestAccAwsAppRunnerService_ImageRepository_InstanceConfiguration (31.27s)
--- PASS: TestAccAwsAppRunnerAutoScalingConfigurationVersion_disappears (37.45s)
--- PASS: TestAccAwsAppRunnerConnection_disappears (38.78s)
--- PASS: TestAccAwsAppRunnerAutoScalingConfigurationVersion_basic (43.53s)
--- PASS: TestAccAwsAppRunnerConnection_basic (45.61s)
--- PASS: TestAccAwsAppRunnerAutoScalingConfigurationVersion_MultipleVersions (61.09s)
--- PASS: TestAccAwsAppRunnerAutoScalingConfigurationVersion_UpdateMultipleVersions (62.41s)
--- PASS: TestAccAwsAppRunnerAutoScalingConfigurationVersion_tags (70.82s)
--- PASS: TestAccAwsAppRunnerAutoScalingConfigurationVersion_complex (71.33s)
--- PASS: TestAccAwsAppRunnerConnection_tags (71.99s)
--- PASS: TestAccAwsAppRunnerService_disappears (253.70s)
--- PASS: TestAccAwsAppRunnerService_ImageRepository_basic (254.63s)
--- PASS: TestAccAwsAppRunnerCustomDomainAssociation_disappears (327.42s)
--- PASS: TestAccAwsAppRunnerService_ImageRepository_AutoScalingConfiguration (328.62s)
--- PASS: TestAccAwsAppRunnerCustomDomainAssociation_basic (337.52s)
--- PASS: TestAccAwsAppRunnerService_tags (344.55s)
--- PASS: TestAccAwsAppRunnerService_ImageRepository_EncryptionConfiguration (535.77s)
--- PASS: TestAccAwsAppRunnerService_ImageRepository_HealthCheckConfiguration (595.87s)

anGie44 and others added 10 commits May 11, 2021 00:27
@anGie44
add service client without SDK
38d4262
@anGie44
Merge pull request #345 from hashicorp/f-apprunner-client
f6fdcbb 
provider: add AppRunner service client and tagging support
@anGie44
resource/apprunner_auto_scaling_configuration_version (#360)
bbe13a9 
* add auto scaling config version resource

* CR/linter updates
@anGie44 @ewbankkit
resource/apprunner_connection: new resource (#354)
46b348d 
* apprunner connection resource

* Update finder method name to ConnectionSummaryByName

Co-authored-by: Kit Ewbank <[email protected]>

* Update finder usage ConnectionSummaryByName

Co-authored-by: Kit Ewbank <[email protected]>

* Update aws/resource_aws_apprunner_connection.go

Co-authored-by: Kit Ewbank <[email protected]>

* Update finder usage to ConnectionSummaryByName

Co-authored-by: Kit Ewbank <[email protected]>

* Update aws/resource_aws_apprunner_connection.go

Co-authored-by: Kit Ewbank <[email protected]>

* Update finder method name to ConnectionSummaryByName

Co-authored-by: Kit Ewbank <[email protected]>

* Update finder method name to ConnectionSummaryByName

Co-authored-by: Kit Ewbank <[email protected]>

* update to new sweeper method usage

* add precheck for govcloud

* semgrep fix

Co-authored-by: Kit Ewbank <[email protected]>
@anGie44
resource/apprunner_custom_domain_association: new resource (#359)
a73f88f 
* add custom domain association resource

* CR/linter updates
@anGie44
resource/apprunner_service: new resource (#361)
de83fe7 
* new resource: apprunner_service

* cleanup tests and documentation

* update timeouts and add PreCheck

* additional tests

* CR/linter updates

* update to new sweeper method usage

* linting fix

* gofmt

* updates after testing service

* update auto_scaling_version resource with new defaults
@anGie44
additional updates from acctest errors
162b2c6
@anGie44
Merge branch 'main' into f-apprunner-service-resources
eddf7fb
@anGie44
format website docs
ff305f3
@anGie44
Merge branch 'main' into f-apprunner-service-resources
75e19a1
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 18, 2021
@gdavison gdavison marked this pull request as ready for review May 18, 2021 23:58
@gdavison gdavison requested a review from a team as a code owner May 18, 2021 23:58
@gdavison gdavison merged commit 6089203 into main May 19, 2021
@gdavison gdavison deleted the f-apprunner-service-resources branch May 19, 2021 00:44
@github-actions github-actions bot added this to the v3.41.0 milestone May 19, 2021
github-actions bot pushed a commit that referenced this pull request May 19, 2021
Update CHANGELOG.md for #19432
a938dfa
@ghost
Copy link

ghost commented May 19, 2021

This has been released in version 3.41.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ewbankkit ewbankkit mentioned this pull request May 19, 2021
Closed
ewbankkit added a commit that referenced this pull request May 20, 2021
@ewbankkit
Add AppRunner service to PR labeler (#19432).
d2dc2d1
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 left review comments

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.41.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gdavison @anGie44