Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_emrcontainers_job_template - new resource #31399

Merged
merged 4 commits into from
May 30, 2023

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented May 13, 2023

Description

tags are force new for what i assume is an internal api issue:

  | Error: updating tags for EMR Containers Job Template (arn:aws:emr-containers:***:***:jobtemplates/***): tagging resource (arn:aws:emr-containers:***:***:jobtemplates/***): BadRequestException: Invalid input resource arn
  | \tstatus code: 400, request id: ***

also docs are very specific towards the cluster resource:

Screenshot 2023-05-13 at 22 59 52

Relations

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccEMRContainersJobTemplate_  PKG=emrcontainers
--- PASS: TestAccEMRContainersJobTemplate_disappears (35.49s)
--- PASS: TestAccEMRContainersJobTemplate_tags (37.00s)
--- PASS: TestAccEMRContainersJobTemplate_basic (40.97s)

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/emrcontainers Issues and PRs that pertain to the emrcontainers service. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels May 13, 2023
@DrFaust92 DrFaust92 added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels May 13, 2023
@DrFaust92 DrFaust92 marked this pull request as ready for review May 15, 2023 19:24
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEMRContainersJobTemplate_' PKG=emrcontainers ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/emrcontainers/... -v -count 1 -parallel 3  -run=TestAccEMRContainersJobTemplate_ -timeout 180m
=== RUN   TestAccEMRContainersJobTemplate_basic
=== PAUSE TestAccEMRContainersJobTemplate_basic
=== RUN   TestAccEMRContainersJobTemplate_disappears
=== PAUSE TestAccEMRContainersJobTemplate_disappears
=== RUN   TestAccEMRContainersJobTemplate_tags
=== PAUSE TestAccEMRContainersJobTemplate_tags
=== CONT  TestAccEMRContainersJobTemplate_basic
=== CONT  TestAccEMRContainersJobTemplate_tags
=== CONT  TestAccEMRContainersJobTemplate_disappears
--- PASS: TestAccEMRContainersJobTemplate_disappears (20.93s)
--- PASS: TestAccEMRContainersJobTemplate_tags (25.48s)
--- PASS: TestAccEMRContainersJobTemplate_basic (28.43s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/emrcontainers	33.957s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit added this to the v5.1.0 milestone May 19, 2023
@ewbankkit ewbankkit merged commit 78e5097 into hashicorp:main May 30, 2023
@github-actions
Copy link

github-actions bot commented Jun 1, 2023

This functionality has been released in v5.1.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jul 2, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. service/emrcontainers Issues and PRs that pertain to the emrcontainers service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants