Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new resources to support AS2 #32203

Merged
merged 27 commits into from
Jun 28, 2023

Conversation

meetreks
Copy link
Contributor

@meetreks meetreks commented Jun 24, 2023

Description

This PR covers adding 4 new resources as part of the AWS transfer family. The 4 new resources are as follows.
aws_transfer_as2_profile
aws_transfer_as2_certificate
aws_transfer_as2_agreement
aws_transfer_as2_connector

Please follow this link for more documentation - https://docs.aws.amazon.com/transfer/latest/userguide/API_CreateProfile.html

Relations

Closes #29406.
Relates #31273.
Relates #27689.

References

Output from Acceptance Testing

:~/terraform-provider-aws (f-aws_transfer_as2_profile) $ make testacc PKG=transfer TESTS=TestAccConnector_basic
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transfer/... -v -count 1 -parallel 20 -run='TestAccConnector_basic'  -timeout 180m
=== RUN   TestAccConnector_basic
--- PASS: TestAccConnector_basic (29.26s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/transfer   29.380s
:~/terraform-provider-aws (f-aws_transfer_as2_profile) $ 

...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/transfer Issues and PRs that pertain to the transfer service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. partner Contribution from a partner. needs-triage Waiting for first response or review from a maintainer. labels Jun 24, 2023
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 26, 2023
@ewbankkit ewbankkit self-assigned this Jun 28, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccTransferCertificate_' PKG=transfer ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transfer/... -v -count 1 -parallel 2  -run=TestAccTransferCertificate_ -timeout 180m
=== RUN   TestAccTransferCertificate_basic
=== PAUSE TestAccTransferCertificate_basic
=== RUN   TestAccTransferCertificate_certificate
=== PAUSE TestAccTransferCertificate_certificate
=== RUN   TestAccTransferCertificate_certificateChain
=== PAUSE TestAccTransferCertificate_certificateChain
=== RUN   TestAccTransferCertificate_certificateKey
=== PAUSE TestAccTransferCertificate_certificateKey
=== RUN   TestAccTransferCertificate_disappears
=== PAUSE TestAccTransferCertificate_disappears
=== RUN   TestAccTransferCertificate_tags
=== PAUSE TestAccTransferCertificate_tags
=== RUN   TestAccTransferCertificate_description
=== PAUSE TestAccTransferCertificate_description
=== CONT  TestAccTransferCertificate_basic
=== CONT  TestAccTransferCertificate_disappears
--- PASS: TestAccTransferCertificate_disappears (61.99s)
=== CONT  TestAccTransferCertificate_description
--- PASS: TestAccTransferCertificate_basic (85.54s)
=== CONT  TestAccTransferCertificate_tags
--- PASS: TestAccTransferCertificate_description (91.52s)
=== CONT  TestAccTransferCertificate_certificateChain
--- PASS: TestAccTransferCertificate_tags (118.30s)
=== CONT  TestAccTransferCertificate_certificateKey
--- PASS: TestAccTransferCertificate_certificateChain (55.12s)
=== CONT  TestAccTransferCertificate_certificate
--- PASS: TestAccTransferCertificate_certificateKey (62.13s)
--- PASS: TestAccTransferCertificate_certificate (60.52s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transfer	288.622s
% make testacc TESTARGS='-run=TestAccTransferProfile_' PKG=transfer ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transfer/... -v -count 1 -parallel 2  -run=TestAccTransferProfile_ -timeout 180m
=== RUN   TestAccTransferProfile_basic
=== PAUSE TestAccTransferProfile_basic
=== RUN   TestAccTransferProfile_certificateIDs
=== PAUSE TestAccTransferProfile_certificateIDs
=== RUN   TestAccTransferProfile_disappears
=== PAUSE TestAccTransferProfile_disappears
=== RUN   TestAccTransferProfile_tags
=== PAUSE TestAccTransferProfile_tags
=== CONT  TestAccTransferProfile_basic
=== CONT  TestAccTransferProfile_tags
--- PASS: TestAccTransferProfile_basic (27.54s)
=== CONT  TestAccTransferProfile_disappears
--- PASS: TestAccTransferProfile_disappears (18.58s)
=== CONT  TestAccTransferProfile_certificateIDs
--- PASS: TestAccTransferProfile_tags (61.19s)
--- PASS: TestAccTransferProfile_certificateIDs (22.52s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transfer	83.140s
% make testacc TESTARGS='-run=TestAccTransfer_serial/Agreement$$' PKG=transfer
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transfer/... -v -count 1 -parallel 20  -run=TestAccTransfer_serial/Agreement$ -timeout 180m
=== RUN   TestAccTransfer_serial
=== PAUSE TestAccTransfer_serial
=== CONT  TestAccTransfer_serial
=== RUN   TestAccTransfer_serial/Agreement
=== RUN   TestAccTransfer_serial/Agreement/disappears
=== RUN   TestAccTransfer_serial/Agreement/tags
=== RUN   TestAccTransfer_serial/Agreement/basic
--- PASS: TestAccTransfer_serial (722.52s)
    --- PASS: TestAccTransfer_serial/Agreement (722.52s)
        --- PASS: TestAccTransfer_serial/Agreement/disappears (184.50s)
        --- PASS: TestAccTransfer_serial/Agreement/tags (336.46s)
        --- PASS: TestAccTransfer_serial/Agreement/basic (201.57s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transfer	728.460s
% make testacc TESTARGS='-run=TestAccTransferConnector_' PKG=transfer ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transfer/... -v -count 1 -parallel 2  -run=TestAccTransferConnector_ -timeout 180m
=== RUN   TestAccTransferConnector_basic
--- PASS: TestAccTransferConnector_basic (34.67s)
=== RUN   TestAccTransferConnector_disappears
--- PASS: TestAccTransferConnector_disappears (17.42s)
=== RUN   TestAccTransferConnector_tags
--- PASS: TestAccTransferConnector_tags (50.68s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transfer	108.598s

@ewbankkit
Copy link
Contributor

@meetreks Thanks for the contribution 🎉 👏.
I renamed the resources aws_transfer_as2_xyz to aws_transfer_xyz to match the underlying AWS API.

@meetreks
Copy link
Contributor Author

@meetreks Thanks for the contribution 🎉 👏. I renamed the resources aws_transfer_as2_xyz to aws_transfer_xyz to match the underlying AWS API.

Thanks @ewbankkit , the help is immense and great. Many thanks.

@ewbankkit ewbankkit merged commit cba5669 into hashicorp:main Jun 28, 2023
@github-actions github-actions bot added this to the v5.6.0 milestone Jun 28, 2023
@github-actions
Copy link

This functionality has been released in v5.6.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. partner Contribution from a partner. service/transfer Issues and PRs that pertain to the transfer service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Resource]: AWS Transfer AS2 Profiles, Certificates, Connectors, and Agreements
3 participants