Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_medialive_channel: fix flatten/expand/docs vpc settings for a channel. #33558

Merged

Conversation

gbw
Copy link
Contributor

@gbw gbw commented Sep 21, 2023

Description

Changes the VPC config settings to use sets instead of lists where appropriate and updates to use flatten/expand functions.

Relations

Closes #33556, closes #33554

References

Output from Acceptance Testing

I lack permissions to test this.

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/medialive Issues and PRs that pertain to the medialive service. labels Sep 21, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Sep 21, 2023
@gbw gbw force-pushed the b-medialive_channel_vpc_subnet_ids_fix branch from ca9fa3f to f7fbbf1 Compare September 21, 2023 02:34
@gbw gbw force-pushed the b-medialive_channel_vpc_subnet_ids_fix branch from f7fbbf1 to 76ee1af Compare September 21, 2023 02:55
@gbw gbw marked this pull request as ready for review September 21, 2023 03:10
@evelynhathaway
Copy link

I cloned and used this as my local provider. I've confirmed to fix my reported issue #33556! Thanks @gbw

@gbw gbw changed the title r/aws_medialive_channel: fix flatten/expand vpc settings for a channel. r/aws_medialive_channel: fix flatten/expand/docs vpc settings for a channel. Sep 23, 2023
@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. and removed size/XS Managed by automation to categorize the size of a PR. labels Sep 23, 2023
@evelynhathaway
Copy link

Thanks for adding documentation! This also now fixes #33554

@johnsonaj johnsonaj added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 5, 2023
@johnsonaj johnsonaj self-assigned this Oct 5, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 5, 2023
@johnsonaj johnsonaj added bug Addresses a defect in current functionality. and removed enhancement Requests to existing resources that expand the functionality or scope. labels Oct 5, 2023
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

$ make testacc TESTARGS='-run=TestAccMediaLiveChannel_' PKG=medialive

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/medialive/... -v -count 1 -parallel 20  -run=TestAccMediaLiveChannel_ -timeout 360m
--- PASS: TestAccMediaLiveChannel_M2TS_settings (89.68s)
--- PASS: TestAccMediaLiveChannel_disappears (97.54s)
--- PASS: TestAccMediaLiveChannel_basic (101.38s)
--- PASS: TestAccMediaLiveChannel_updateTags (126.62s)
--- PASS: TestAccMediaLiveChannel_MsSmooth_outputSettings (156.98s)
--- PASS: TestAccMediaLiveChannel_AudioDescriptions_codecSettings (169.75s)
--- PASS: TestAccMediaLiveChannel_VideoDescriptions_CodecSettings_h265Settings (170.94s)
--- PASS: TestAccMediaLiveChannel_status (189.85s)
--- PASS: TestAccMediaLiveChannel_update (202.73s)
--- PASS: TestAccMediaLiveChannel_hls (219.73s)
--- PASS: TestAccMediaLiveChannel_VideoDescriptions_CodecSettings_h264Settings (243.53s)
--- PASS: TestAccMediaLiveChannel_captionDescriptions (243.71s)
--- PASS: TestAccMediaLiveChannel_UDP_outputSettings (264.25s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/medialive	267.509s

@johnsonaj
Copy link
Contributor

@gbw thank you for the contribution! 🎉

@johnsonaj johnsonaj merged commit e6acbbe into hashicorp:main Oct 5, 2023
38 checks passed
@github-actions github-actions bot added this to the v5.20.0 milestone Oct 5, 2023
@github-actions github-actions bot removed the bug Addresses a defect in current functionality. label Oct 6, 2023
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

This functionality has been released in v5.20.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@gbw gbw deleted the b-medialive_channel_vpc_subnet_ids_fix branch October 21, 2023 22:58
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2023
@justinretzolk justinretzolk added the bug Addresses a defect in current functionality. label Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/medialive Issues and PRs that pertain to the medialive service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
4 participants