-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add additional tgw route filter 🌽 #33765
fix: add additional tgw route filter 🌽 #33765
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccTransitGateway_serial/^Route$$' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccTransitGateway_serial/^Route$ -timeout 360m
=== RUN TestAccTransitGateway_serial
=== PAUSE TestAccTransitGateway_serial
=== CONT TestAccTransitGateway_serial
=== RUN TestAccTransitGateway_serial/Route
=== RUN TestAccTransitGateway_serial/Route/basic
=== RUN TestAccTransitGateway_serial/Route/basicIpv6
=== RUN TestAccTransitGateway_serial/Route/blackhole
=== RUN TestAccTransitGateway_serial/Route/disappears
=== RUN TestAccTransitGateway_serial/Route/disappearsTransitGatewayAttachment
--- PASS: TestAccTransitGateway_serial (1097.03s)
--- PASS: TestAccTransitGateway_serial/Route (1097.03s)
--- PASS: TestAccTransitGateway_serial/Route/basic (261.18s)
--- PASS: TestAccTransitGateway_serial/Route/basicIpv6 (239.70s)
--- PASS: TestAccTransitGateway_serial/Route/blackhole (206.57s)
--- PASS: TestAccTransitGateway_serial/Route/disappears (187.75s)
--- PASS: TestAccTransitGateway_serial/Route/disappearsTransitGatewayAttachment (201.83s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 1102.643s
@b-diggity Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.20.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
fixing the transit gateway route search function by adding an additional filter. when more than 1,000 routes are present in a route table and the filter matches ore than 1,000 routes, the list is truncated. as noted in the linked issue, terraform will try to start recreating routes if they aren't returned
Relations
closes #33762
References
https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_SearchTransitGatewayRoutes.html
https:/hashicorp/terraform-provider-aws/blob/main/internal/service/ec2/find.go#L4600
Output from Acceptance Testing
NOTE: I need help with testing this from the admins/maintainers. I validated the filter works as desired via the AWS CLI