r/aws_autoscaling_group Instance maintenance policy enhancement

[sasidhar-aws]

Description

Adds the instance_maintenance_policy (optional) argument to aws_autoscaling_group

Relations

Closes #34427

References

https://aws.amazon.com/about-aws/whats-new/2023/11/amazon-ec2-auto-scaling-ec2-instance-replacement/

Output from Acceptance Testing

make testacc TESTS=TestAccAutoScalingGroup_withInstanceMaintenancePolicy  PKG=autoscaling
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 20 -run='TestAccAutoScalingGroup_withInstanceMaintenancePolicy'  -timeout 360m
=== RUN   TestAccAutoScalingGroup_withInstanceMaintenancePolicyAfterCreation
=== PAUSE TestAccAutoScalingGroup_withInstanceMaintenancePolicyAfterCreation
=== RUN   TestAccAutoScalingGroup_withInstanceMaintenancePolicyAtCreation
=== PAUSE TestAccAutoScalingGroup_withInstanceMaintenancePolicyAtCreation
=== RUN   TestAccAutoScalingGroup_withInstanceMaintenancePolicyNegativeValues
=== PAUSE TestAccAutoScalingGroup_withInstanceMaintenancePolicyNegativeValues
=== CONT  TestAccAutoScalingGroup_withInstanceMaintenancePolicyAfterCreation
=== CONT  TestAccAutoScalingGroup_withInstanceMaintenancePolicyNegativeValues
=== CONT  TestAccAutoScalingGroup_withInstanceMaintenancePolicyAtCreation
--- PASS: TestAccAutoScalingGroup_withInstanceMaintenancePolicyNegativeValues (59.65s)
--- PASS: TestAccAutoScalingGroup_withInstanceMaintenancePolicyAtCreation (235.74s)
--- PASS: TestAccAutoScalingGroup_withInstanceMaintenancePolicyAfterCreation (350.43s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling	355.546s



make testacc TESTS=TestAccAutoScalingGroupDataSource_basic  PKG=autoscaling
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 20 -run='TestAccAutoScalingGroupDataSource_basic'  -timeout 360m
=== RUN   TestAccAutoScalingGroupDataSource_basic
=== PAUSE TestAccAutoScalingGroupDataSource_basic
=== CONT  TestAccAutoScalingGroupDataSource_basic
--- PASS: TestAccAutoScalingGroupDataSource_basic (42.53s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling	47.669s
...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAutoScalingGroupDataSource_basic\|TestAccAutoScalingGroup_withInstanceMaintenance\|TestAccAutoScalingGroup_basic\|TestAccAutoScalingGroupDataSource_launchTemplate' PKG=autoscaling ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 2  -run=TestAccAutoScalingGroupDataSource_basic\|TestAccAutoScalingGroup_withInstanceMaintenance\|TestAccAutoScalingGroup_basic\|TestAccAutoScalingGroupDataSource_launchTemplate -timeout 360m
=== RUN   TestAccAutoScalingGroupDataSource_basic
=== PAUSE TestAccAutoScalingGroupDataSource_basic
=== RUN   TestAccAutoScalingGroupDataSource_launchTemplate
=== PAUSE TestAccAutoScalingGroupDataSource_launchTemplate
=== RUN   TestAccAutoScalingGroup_basic
=== PAUSE TestAccAutoScalingGroup_basic
=== RUN   TestAccAutoScalingGroup_withInstanceMaintenancePolicyAfterCreation
=== PAUSE TestAccAutoScalingGroup_withInstanceMaintenancePolicyAfterCreation
=== RUN   TestAccAutoScalingGroup_withInstanceMaintenancePolicyAtCreation
=== PAUSE TestAccAutoScalingGroup_withInstanceMaintenancePolicyAtCreation
=== RUN   TestAccAutoScalingGroup_withInstanceMaintenancePolicyNegativeValues
=== PAUSE TestAccAutoScalingGroup_withInstanceMaintenancePolicyNegativeValues
=== CONT  TestAccAutoScalingGroupDataSource_basic
=== CONT  TestAccAutoScalingGroup_withInstanceMaintenancePolicyAfterCreation
--- PASS: TestAccAutoScalingGroupDataSource_basic (73.58s)
=== CONT  TestAccAutoScalingGroup_basic
--- PASS: TestAccAutoScalingGroup_basic (76.68s)
=== CONT  TestAccAutoScalingGroupDataSource_launchTemplate
--- PASS: TestAccAutoScalingGroupDataSource_launchTemplate (59.24s)
=== CONT  TestAccAutoScalingGroup_withInstanceMaintenancePolicyNegativeValues
--- PASS: TestAccAutoScalingGroup_withInstanceMaintenancePolicyNegativeValues (107.27s)
=== CONT  TestAccAutoScalingGroup_withInstanceMaintenancePolicyAtCreation
--- PASS: TestAccAutoScalingGroup_withInstanceMaintenancePolicyAfterCreation (459.97s)
--- PASS: TestAccAutoScalingGroup_withInstanceMaintenancePolicyAtCreation (317.94s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling	640.127s

[ewbankkit]

@sasidhar-aws Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.26.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.