-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
f/aws_codepipeline add support for pipeline_type and variable #34841
f/aws_codepipeline add support for pipeline_type and variable #34841
Conversation
resource/aws_codepipeline: Add pipeline_type, variable attribute
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @neruneruo 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
Can we get a review of this PR? My team and I really want to start using V2 CodePipelines in Terraform. |
Thank you for your response!! Is there anything I should do? |
Hello, |
Would be great to have this reviewed and merged. I have a workaround with a local-exec provisioner for the time being but it's just adding noise to the plan diffs. |
… && go mod tidy'.
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
…put.Webhook.AuthenticationConfiguration' error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccCodePipelineCustomActionType_' PKG=codepipeline
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/codepipeline/... -v -count 1 -parallel 20 -run=TestAccCodePipelineCustomActionType_ -timeout 360m
=== RUN TestAccCodePipelineCustomActionType_basic
=== PAUSE TestAccCodePipelineCustomActionType_basic
=== RUN TestAccCodePipelineCustomActionType_disappears
=== PAUSE TestAccCodePipelineCustomActionType_disappears
=== RUN TestAccCodePipelineCustomActionType_tags
=== PAUSE TestAccCodePipelineCustomActionType_tags
=== RUN TestAccCodePipelineCustomActionType_allAttributes
=== PAUSE TestAccCodePipelineCustomActionType_allAttributes
=== CONT TestAccCodePipelineCustomActionType_basic
=== CONT TestAccCodePipelineCustomActionType_tags
=== CONT TestAccCodePipelineCustomActionType_disappears
=== CONT TestAccCodePipelineCustomActionType_allAttributes
--- PASS: TestAccCodePipelineCustomActionType_disappears (23.59s)
--- PASS: TestAccCodePipelineCustomActionType_basic (27.22s)
--- PASS: TestAccCodePipelineCustomActionType_allAttributes (27.27s)
--- PASS: TestAccCodePipelineCustomActionType_tags (49.15s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/codepipeline 54.595s
% make testacc TESTARGS='-run=TestAccCodePipeline_' PKG=codepipeline ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/codepipeline/... -v -count 1 -parallel 2 -run=TestAccCodePipeline_ -timeout 360m
=== RUN TestAccCodePipeline_basic
=== PAUSE TestAccCodePipeline_basic
=== RUN TestAccCodePipeline_disappears
=== PAUSE TestAccCodePipeline_disappears
=== RUN TestAccCodePipeline_emptyStageArtifacts
=== PAUSE TestAccCodePipeline_emptyStageArtifacts
=== RUN TestAccCodePipeline_deployWithServiceRole
=== PAUSE TestAccCodePipeline_deployWithServiceRole
=== RUN TestAccCodePipeline_tags
=== PAUSE TestAccCodePipeline_tags
=== RUN TestAccCodePipeline_MultiRegion_basic
=== PAUSE TestAccCodePipeline_MultiRegion_basic
=== RUN TestAccCodePipeline_MultiRegion_update
=== PAUSE TestAccCodePipeline_MultiRegion_update
=== RUN TestAccCodePipeline_MultiRegion_convertSingleRegion
=== PAUSE TestAccCodePipeline_MultiRegion_convertSingleRegion
=== RUN TestAccCodePipeline_withNamespace
=== PAUSE TestAccCodePipeline_withNamespace
=== RUN TestAccCodePipeline_withGitHubV1SourceAction
acctest.go:2457: Environment variable GITHUB_TOKEN is not set, skipping test
--- SKIP: TestAccCodePipeline_withGitHubV1SourceAction (0.00s)
=== RUN TestAccCodePipeline_ecr
=== PAUSE TestAccCodePipeline_ecr
=== RUN TestAccCodePipeline_pipelinetype
=== PAUSE TestAccCodePipeline_pipelinetype
=== CONT TestAccCodePipeline_basic
=== CONT TestAccCodePipeline_MultiRegion_update
--- PASS: TestAccCodePipeline_basic (58.45s)
=== CONT TestAccCodePipeline_withNamespace
--- PASS: TestAccCodePipeline_MultiRegion_update (61.47s)
=== CONT TestAccCodePipeline_MultiRegion_convertSingleRegion
--- PASS: TestAccCodePipeline_withNamespace (28.64s)
=== CONT TestAccCodePipeline_deployWithServiceRole
=== NAME TestAccCodePipeline_MultiRegion_convertSingleRegion
codepipeline_test.go:384: Step 3/4 error: Error running apply: exit status 1
Error: region cannot be set for a single-region CodePipeline
with aws_codepipeline.test,
on terraform_plugin_test.tf line 75, in resource "aws_codepipeline" "test":
75: resource "aws_codepipeline" "test" {
--- PASS: TestAccCodePipeline_deployWithServiceRole (33.52s)
=== CONT TestAccCodePipeline_MultiRegion_basic
--- FAIL: TestAccCodePipeline_MultiRegion_convertSingleRegion (64.49s)
=== CONT TestAccCodePipeline_tags
--- PASS: TestAccCodePipeline_MultiRegion_basic (38.01s)
=== CONT TestAccCodePipeline_pipelinetype
--- PASS: TestAccCodePipeline_tags (68.50s)
=== CONT TestAccCodePipeline_emptyStageArtifacts
--- PASS: TestAccCodePipeline_emptyStageArtifacts (30.48s)
=== CONT TestAccCodePipeline_disappears
--- PASS: TestAccCodePipeline_pipelinetype (75.29s)
=== CONT TestAccCodePipeline_ecr
--- PASS: TestAccCodePipeline_disappears (27.63s)
--- PASS: TestAccCodePipeline_ecr (29.92s)
FAIL
FAIL github.com/hashicorp/terraform-provider-aws/internal/service/codepipeline 269.755s
FAIL
make: *** [testacc] Error 1
Failure is unrelated to this change (it's happening in CI).
% GITHUB_TOKEN=******** make testacc TESTARGS='-run=TestAccCodePipeline_withGitHubV1SourceAction' PKG=codepipeline
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/codepipeline/... -v -count 1 -parallel 20 -run=TestAccCodePipeline_withGitHubV1SourceAction -timeout 360m
=== RUN TestAccCodePipeline_withGitHubV1SourceAction
=== PAUSE TestAccCodePipeline_withGitHubV1SourceAction
=== CONT TestAccCodePipeline_withGitHubV1SourceAction
--- PASS: TestAccCodePipeline_withGitHubV1SourceAction (47.49s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/codepipeline 52.900s
% GITHUB_TOKEN=******** make testacc TESTARGS='-run=TestAccCodePipelineWebhook_' PKG=codepipeline ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/codepipeline/... -v -count 1 -parallel 2 -run=TestAccCodePipelineWebhook_ -timeout 360m
=== RUN TestAccCodePipelineWebhook_basic
--- PASS: TestAccCodePipelineWebhook_basic (57.83s)
=== RUN TestAccCodePipelineWebhook_ipAuth
--- PASS: TestAccCodePipelineWebhook_ipAuth (31.33s)
=== RUN TestAccCodePipelineWebhook_unauthenticated
--- PASS: TestAccCodePipelineWebhook_unauthenticated (27.11s)
=== RUN TestAccCodePipelineWebhook_tags
--- PASS: TestAccCodePipelineWebhook_tags (57.87s)
=== RUN TestAccCodePipelineWebhook_disappears
--- PASS: TestAccCodePipelineWebhook_disappears (25.73s)
=== RUN TestAccCodePipelineWebhook_UpdateAuthentication_secretToken
--- PASS: TestAccCodePipelineWebhook_UpdateAuthentication_secretToken (41.24s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/codepipeline 246.783s
@neruneruo Thanks for the contribution 🎉 👏. |
@ewbankkit |
This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
resource/aws_codepipeline: Add pipeline_type, variable attribute
Description
Add attributes: pipeline_type, variable
Relations
Closes #34122
References
Output from Acceptance Testing
An error occurred at TestAccCodePipeline_MultiRegion_convertSingleRegion.
But this error was originally occurring.
New test name is TestAccCodePipeline_pipelinetype.