Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rekognition collection resource #35407

Merged
merged 11 commits into from
Feb 1, 2024
Merged

Add Rekognition collection resource #35407

merged 11 commits into from
Feb 1, 2024

Conversation

bruceharrison1984
Copy link
Contributor

@bruceharrison1984 bruceharrison1984 commented Jan 19, 2024

The is a resubmission of a PR that was already merged. The previous PR #35331 resource got clobbered due to the way I split the branches, so it was merged but the resource didn't make it into main.

This just adds back the missing resources.

Closes #26053
Relates #31889

% make testacc TESTS=TestAccRekognition PKG=rekognition
...

@bruceharrison1984 bruceharrison1984 marked this pull request as ready for review January 19, 2024 21:23
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/rekognition Issues and PRs that pertain to the rekognition service. and removed size/XL Managed by automation to categorize the size of a PR. labels Jan 19, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 19, 2024
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. labels Jan 19, 2024
@justinretzolk justinretzolk added new-resource Introduces a new resource. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 22, 2024
@johnsonaj johnsonaj self-assigned this Jan 31, 2024
@github-actions github-actions bot added the generators Relates to code generators. label Jan 31, 2024
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

make testacc TESTARGS="-run=TestAccRekognitionCollection_" PKG=rekognition | filter-test
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rekognition/... -v -count 1 -parallel 20  -run=TestAccRekognitionCollection_ -timeout 360m
--- PASS: TestAccRekognitionCollection_disappears (10.63s)
--- PASS: TestAccRekognitionCollection_basic (12.58s)
--- PASS: TestAccRekognitionCollection_tags (23.31s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rekognition	30.237s

@johnsonaj
Copy link
Contributor

@bruceharrison1984 thank you for the contribution! 🎉

@johnsonaj johnsonaj merged commit 1a503f1 into hashicorp:main Feb 1, 2024
53 checks passed
@github-actions github-actions bot added this to the v5.35.0 milestone Feb 1, 2024
Copy link

github-actions bot commented Feb 2, 2024

This functionality has been released in v5.35.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Mar 4, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/rekognition Issues and PRs that pertain to the rekognition service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants