Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_lakeformation_data_cells_filter: new resource #36264

Merged
merged 25 commits into from
Mar 11, 2024

Conversation

johnsonaj
Copy link
Contributor

@johnsonaj johnsonaj commented Mar 8, 2024

Description

Relations

Closes #27677

References

Output from Acceptance Testing

% make testacc TESTARGS="-run=TestAccLakeFormation_serial/PermissionsBasic/" PKG=lakeformation

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lakeformation/... -v -count 1 -parallel 20  -run=TestAccLakeFormation_serial/PermissionsBasic/ -timeout 360m
--- PASS: TestAccLakeFormation_serial (283.77s)
    --- PASS: TestAccLakeFormation_serial/PermissionsBasic (283.77s)
        --- PASS: TestAccLakeFormation_serial/PermissionsBasic/dataCellsFilter (21.34s)
        --- PASS: TestAccLakeFormation_serial/PermissionsBasic/dataLocation (20.81s)
        --- PASS: TestAccLakeFormation_serial/PermissionsBasic/lfTag (18.59s)
        --- PASS: TestAccLakeFormation_serial/PermissionsBasic/lfTagPolicy (20.20s)
        --- PASS: TestAccLakeFormation_serial/PermissionsBasic/lfTagPolicyMultiple (19.19s)
        --- PASS: TestAccLakeFormation_serial/PermissionsBasic/databaseIAMAllowed (41.38s)
        --- PASS: TestAccLakeFormation_serial/PermissionsBasic/database (19.37s)
        --- PASS: TestAccLakeFormation_serial/PermissionsBasic/databaseMultiple (19.51s)
        --- PASS: TestAccLakeFormation_serial/PermissionsBasic/disappears (84.82s)
        --- PASS: TestAccLakeFormation_serial/PermissionsBasic/basic (18.54s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lakeformation	287.810s
% make testacc TESTARGS="-run=TestAccLakeFormation_serial/DataCellsFilter/" PKG=lakeformation

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lakeformation/... -v -count 1 -parallel 20  -run=TestAccLakeFormation_serial/DataCellsFilter/ -timeout 360m
--- PASS: TestAccLakeFormation_serial (41.38s)
    --- PASS: TestAccLakeFormation_serial/DataCellsFilter (41.38s)
        --- PASS: TestAccLakeFormation_serial/DataCellsFilter/basic (15.63s)
        --- PASS: TestAccLakeFormation_serial/DataCellsFilter/columnWildcard (12.43s)
        --- PASS: TestAccLakeFormation_serial/DataCellsFilter/disappears (13.32s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lakeformation	45.606s
% make testacc TESTARGS="-run=TestAccLakeFormation_serial/PermissionsDataSource/" PKG=lakeformation
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lakeformation/... -v -count 1 -parallel 20  -run=TestAccLakeFormation_serial/PermissionsDataSource/ -timeout 360m
    permissions_data_source_test.go:73: Error running post-test destroy, there may be dangling resources: exit status 1

        Error: deregistering Lake Formation Resource (arn:aws:s3:::tf-acc-test-2469101957358460689): InvalidInputException: Must manually delete service-linked role to deregister last S3 location.

--- FAIL: TestAccLakeFormation_serial (165.31s)
    --- FAIL: TestAccLakeFormation_serial/PermissionsDataSource (165.31s)
        --- PASS: TestAccLakeFormation_serial/PermissionsDataSource/lfTagPolicy (20.18s)
        --- PASS: TestAccLakeFormation_serial/PermissionsDataSource/table (21.67s)
        --- PASS: TestAccLakeFormation_serial/PermissionsDataSource/tableWithColumns (21.32s)
        --- PASS: TestAccLakeFormation_serial/PermissionsDataSource/basic (18.92s)
        --- PASS: TestAccLakeFormation_serial/PermissionsDataSource/dataCellsFilter (21.99s)
        --- PASS: TestAccLakeFormation_serial/PermissionsDataSource/database (20.41s)
        --- FAIL: TestAccLakeFormation_serial/PermissionsDataSource/dataLocation (21.28s)
        --- PASS: TestAccLakeFormation_serial/PermissionsDataSource/lfTag (19.56s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/lakeformation	169.386s
FAIL
make: *** [testacc] Error 1

Test failure not related to the PR

Copy link

github-actions bot commented Mar 8, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/lakeformation Issues and PRs that pertain to the lakeformation service. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. labels Mar 8, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Mar 8, 2024
Copy link

github-actions bot commented Mar 8, 2024

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

@johnsonaj johnsonaj added the new-resource Introduces a new resource. label Mar 8, 2024
@johnsonaj johnsonaj force-pushed the f-lakeformation_data_cell_filters branch from d4fa919 to 79b3952 Compare March 9, 2024 00:33
@johnsonaj johnsonaj added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 9, 2024
@johnsonaj johnsonaj marked this pull request as ready for review March 9, 2024 01:10
@johnsonaj johnsonaj force-pushed the f-lakeformation_data_cell_filters branch from 3fbec33 to e0e724e Compare March 11, 2024 13:59
@johnsonaj johnsonaj merged commit e006687 into main Mar 11, 2024
51 checks passed
@johnsonaj johnsonaj deleted the f-lakeformation_data_cell_filters branch March 11, 2024 18:02
@github-actions github-actions bot added this to the v5.41.0 milestone Mar 11, 2024
github-actions bot pushed a commit that referenced this pull request Mar 11, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Mar 14, 2024
Copy link

This functionality has been released in v5.41.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. generators Relates to code generators. new-resource Introduces a new resource. service/lakeformation Issues and PRs that pertain to the lakeformation service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Support lakeformation data filters
1 participant