Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add af-south-1 registry id for sagemaker prebuilt ECR image data source #36803

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

GuusDeGraeve
Copy link
Contributor

@GuusDeGraeve GuusDeGraeve commented Apr 9, 2024

Description

The prebuiltECRImageIDByRegion_deepLearning map is missing the account-id / registry-id for the af-south-1 (South Africa) region. This PR adds that missing account-id to ensure we avoid below error on af-south-1:

Planning failed. Terraform encountered an error while generating this plan.

╷
│ Error: no registry ID available for region (af-south-1) and repository (huggingface-pytorch-inference)
│ 
│   with data.aws_sagemaker_prebuilt_ecr_image.deploy_image[0],
│   on main.tf line 29, in data "aws_sagemaker_prebuilt_ecr_image" "deploy_image":
│   29: data "aws_sagemaker_prebuilt_ecr_image" "deploy_image" {
│ 
╵
exit status 1

References

https://docs.aws.amazon.com/sagemaker/latest/dg-ecr-paths/ecr-af-south-1.html#huggingface-af-south-1.title
https:/aws/deep-learning-containers/blob/master/available_images.md

Output from Acceptance Testing

% make testacc TESTS=TestAccSageMakerPrebuiltECRImageDataSource_basic PKG=sagemaker
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/sagemaker/... -v -count 1 -parallel 20 -run='TestAccSageMakerPrebuiltECRImageDataSource_basic'  -timeout 360m
=== RUN   TestAccSageMakerPrebuiltECRImageDataSource_basic
=== PAUSE TestAccSageMakerPrebuiltECRImageDataSource_basic
=== CONT  TestAccSageMakerPrebuiltECRImageDataSource_basic
--- PASS: TestAccSageMakerPrebuiltECRImageDataSource_basic (9.37s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker  13.078s
% make testacc TESTS=TestAccSageMakerPrebuiltECRImageDataSource_region PKG=sagemaker
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/sagemaker/... -v -count 1 -parallel 20 -run='TestAccSageMakerPrebuiltECRImageDataSource_region'  -timeout 360m
=== RUN   TestAccSageMakerPrebuiltECRImageDataSource_region
=== PAUSE TestAccSageMakerPrebuiltECRImageDataSource_region
=== CONT  TestAccSageMakerPrebuiltECRImageDataSource_region
--- PASS: TestAccSageMakerPrebuiltECRImageDataSource_region (9.11s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker  12.690s

Copy link

github-actions bot commented Apr 9, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/sagemaker Issues and PRs that pertain to the sagemaker service. size/XS Managed by automation to categorize the size of a PR. labels Apr 9, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 9, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @GuusDeGraeve 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Apr 9, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Apr 9, 2024
@ewbankkit
Copy link
Contributor

@GuusDeGraeve Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit d292adc into hashicorp:main Apr 9, 2024
42 checks passed
@github-actions github-actions bot added this to the v5.45.0 milestone Apr 9, 2024
Copy link

This functionality has been released in v5.45.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants