Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Data Source]: aws_describe_connector #38213

Merged
merged 9 commits into from
Jul 2, 2024

Conversation

ThomasZalewski
Copy link
Contributor

Description

This datasource will allow practitioners to read the description of an existing AWS Transfer Family Connector with a terraform datasource.

Relations

Closes #37675

References

https://docs.aws.amazon.com/transfer/latest/userguide/API_DescribeConnector.html

Output from Acceptance Testing

make testacc TESTS=TestAccTransferConnectorDataSource_basic PKG=transfer
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/transfer/... -v -count 1 -parallel 20 -run='TestAccTransferConnectorDataSource_basic'  -timeout 360m
=== RUN   TestAccTransferConnectorDataSource_basic
=== PAUSE TestAccTransferConnectorDataSource_basic
=== CONT  TestAccTransferConnectorDataSource_basic
--- PASS: TestAccTransferConnectorDataSource_basic (9.59s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/transfer   14.303s```

@ThomasZalewski ThomasZalewski requested a review from a team as a code owner July 1, 2024 21:10
Copy link

github-actions bot commented Jul 1, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/transfer Issues and PRs that pertain to the transfer service. generators Relates to code generators. labels Jul 1, 2024
Copy link

github-actions bot commented Jul 1, 2024

Hey @ThomasZalewski 👋 Thank you very much for your contribution! At times, our maintainers need to make direct edits to pull requests in order to help get it ready to be merged. Your current settings do not allow maintainers to make such edits. To help facilitate this, update your pull request to allow such edits as described in GitHub's Allowing changes to a pull request branch created from a fork documentation. (If you're using a fork owned by an organization, your organization may not allow you to change this setting. If that is the case, let us know.)

@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jul 1, 2024
@johnsonaj johnsonaj added the new-data-source Introduces a new data source. label Jul 2, 2024
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good; just a few small comments.

@johnsonaj
Copy link
Contributor

% make testacc TESTS=TestAccTransferConnectorDataSource_basic PKG=transfer

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/transfer/... -v -count 1 -parallel 20 -run='TestAccTransferConnectorDataSource_basic'  -timeout 360m
=== RUN   TestAccTransferConnectorDataSource_basic
=== PAUSE TestAccTransferConnectorDataSource_basic
=== CONT  TestAccTransferConnectorDataSource_basic
--- PASS: TestAccTransferConnectorDataSource_basic (12.74s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transfer	18.423s

Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Jul 2, 2024
@ThomasZalewski ThomasZalewski merged commit c177b54 into main Jul 2, 2024
45 checks passed
@ThomasZalewski ThomasZalewski deleted the f/describe-connector-data-source branch July 2, 2024 15:30
@github-actions github-actions bot added this to the v5.57.0 milestone Jul 2, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Jul 2, 2024
Copy link

github-actions bot commented Jul 5, 2024

This functionality has been released in v5.57.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Aug 8, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-data-source Introduces a new data source. service/transfer Issues and PRs that pertain to the transfer service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Data Source]: DataSource for aws_transfer_connector
3 participants