bootstrap_cluster_creator_admin_permissions value fix when access_config is not provided at eks cluster creation

[sasidhar-aws]

Description

Setting bootstrap_cluster_creator_admin_permissions on an existing cluster should have no effect. Parameter value was set to false when value is not provided, due to which cluster is forced to recreate when access_config block is provided after cluster creation. This PR updated the value to true, when bootstrap_cluster_creator_admin_permissions parameter is not set initially.

Relations

Closes #35824.
Closes #36259.
Relates #35037.

References

Output from Acceptance Testing

make testacc TESTS=TestAccEKSCluster_AccessConfig PKG=eks
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/eks/... -v -count 1 -parallel 20 -run='TestAccEKSCluster_AccessConfig'  -timeout 360m
=== RUN   TestAccEKSCluster_AccessConfig_create
=== PAUSE TestAccEKSCluster_AccessConfig_create
=== RUN   TestAccEKSCluster_AccessConfig_update
=== PAUSE TestAccEKSCluster_AccessConfig_update
=== CONT  TestAccEKSCluster_AccessConfig_create
=== CONT  TestAccEKSCluster_AccessConfig_update
--- PASS: TestAccEKSCluster_AccessConfig_create (689.67s)
--- PASS: TestAccEKSCluster_AccessConfig_update (867.16s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/eks	882.832s

make testacc TESTS=TestAccEKSClusterDataSource_basic PKG=eks                                                                
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/eks/... -v -count 1 -parallel 20 -run='TestAccEKSClusterDataSource_basic'  -timeout 360m
=== RUN   TestAccEKSClusterDataSource_basic
=== PAUSE TestAccEKSClusterDataSource_basic
=== CONT  TestAccEKSClusterDataSource_basic
--- PASS: TestAccEKSClusterDataSource_basic (436.31s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/eks	461.797s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEKSCluster_AccessConfig_update' PKG=eks
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/eks/... -v -count 1 -parallel 20  -run=TestAccEKSCluster_AccessConfig_update -timeout 360m
=== RUN   TestAccEKSCluster_AccessConfig_update
=== PAUSE TestAccEKSCluster_AccessConfig_update
=== CONT  TestAccEKSCluster_AccessConfig_update
--- PASS: TestAccEKSCluster_AccessConfig_update (716.23s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/eks	721.050s

% make testacc TESTARGS='-run=TestAccEKSCluster_AccessConfig_create\|TestAccEKSAccessEntry_\|TestAccEKSCluster_basic\|TestAccEKSClusterDataSource_basic' PKG=eks ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/eks/... -v -count 1 -parallel 3  -run=TestAccEKSCluster_AccessConfig_create\|TestAccEKSAccessEntry_\|TestAccEKSCluster_basic\|TestAccEKSClusterDataSource_basic -timeout 360m
=== RUN   TestAccEKSAccessEntry_basic
=== PAUSE TestAccEKSAccessEntry_basic
=== RUN   TestAccEKSAccessEntry_disappears
=== PAUSE TestAccEKSAccessEntry_disappears
=== RUN   TestAccEKSAccessEntry_Disappears_cluster
=== PAUSE TestAccEKSAccessEntry_Disappears_cluster
=== RUN   TestAccEKSAccessEntry_tags
=== PAUSE TestAccEKSAccessEntry_tags
=== RUN   TestAccEKSAccessEntry_type
=== PAUSE TestAccEKSAccessEntry_type
=== RUN   TestAccEKSAccessEntry_username
=== PAUSE TestAccEKSAccessEntry_username
=== RUN   TestAccEKSAccessEntry_eventualConsistency
=== PAUSE TestAccEKSAccessEntry_eventualConsistency
=== RUN   TestAccEKSClusterDataSource_basic
=== PAUSE TestAccEKSClusterDataSource_basic
=== RUN   TestAccEKSCluster_basic
=== PAUSE TestAccEKSCluster_basic
=== RUN   TestAccEKSCluster_AccessConfig_create
=== PAUSE TestAccEKSCluster_AccessConfig_create
=== CONT  TestAccEKSAccessEntry_basic
=== CONT  TestAccEKSAccessEntry_username
=== CONT  TestAccEKSCluster_basic
--- PASS: TestAccEKSAccessEntry_basic (557.71s)
=== CONT  TestAccEKSCluster_AccessConfig_create
--- PASS: TestAccEKSCluster_basic (562.20s)
=== CONT  TestAccEKSClusterDataSource_basic
--- PASS: TestAccEKSAccessEntry_username (673.22s)
=== CONT  TestAccEKSAccessEntry_tags
--- PASS: TestAccEKSCluster_AccessConfig_create (590.29s)
=== CONT  TestAccEKSAccessEntry_type
--- PASS: TestAccEKSClusterDataSource_basic (708.71s)
=== CONT  TestAccEKSAccessEntry_Disappears_cluster
=== CONT  TestAccEKSAccessEntry_disappears
--- PASS: TestAccEKSAccessEntry_tags (630.85s)
--- PASS: TestAccEKSAccessEntry_type (590.09s)
=== CONT  TestAccEKSAccessEntry_eventualConsistency
--- PASS: TestAccEKSAccessEntry_Disappears_cluster (553.25s)
--- PASS: TestAccEKSAccessEntry_disappears (572.01s)
--- PASS: TestAccEKSAccessEntry_eventualConsistency (724.01s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/eks	2466.829s

[ewbankkit]

@sasidhar-aws Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.58.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.