Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add aws_cloudwatch_log_account_policy resource #38328

Merged

Conversation

chrisbrowning
Copy link
Contributor

Description

Adds the aws_cloudwatch_log_account_policy resource, which can create account-level subscription filters and/or data protection policies.

Relations

Closes #35278

References

Output from Acceptance Testing

%make testacc TESTS=TestAccLogsAccountPolicy PKG=logs
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/logs/... -v -count 1 -parallel 20 -run='TestAccLogsAccountPolicy'  -timeout 360m
=== RUN   TestAccLogsAccountPolicy_basicSubscriptionFilter
=== PAUSE TestAccLogsAccountPolicy_basicSubscriptionFilter
=== RUN   TestAccLogsAccountPolicy_basicDataProtection
=== PAUSE TestAccLogsAccountPolicy_basicDataProtection
=== RUN   TestAccLogsAccountPolicy_disappears
=== PAUSE TestAccLogsAccountPolicy_disappears
=== RUN   TestAccLogsAccountPolicy_selectionCriteria
=== PAUSE TestAccLogsAccountPolicy_selectionCriteria
=== CONT  TestAccLogsAccountPolicy_basicSubscriptionFilter
=== CONT  TestAccLogsAccountPolicy_selectionCriteria
=== CONT  TestAccLogsAccountPolicy_basicDataProtection
=== CONT  TestAccLogsAccountPolicy_disappears
--- PASS: TestAccLogsAccountPolicy_basicDataProtection (36.02s)
--- PASS: TestAccLogsAccountPolicy_selectionCriteria (52.52s)
--- PASS: TestAccLogsAccountPolicy_disappears (55.53s)
--- PASS: TestAccLogsAccountPolicy_basicSubscriptionFilter (71.03s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/logs	71.387s

...

@chrisbrowning chrisbrowning requested a review from a team as a code owner July 11, 2024 05:10
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@terraform-aws-provider terraform-aws-provider bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/logs Issues and PRs that pertain to the logs service. size/XL Managed by automation to categorize the size of a PR. labels Jul 11, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @chrisbrowning 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ewbankkit ewbankkit added the new-resource Introduces a new resource. label Jul 11, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccLogsAccountPolicy_' PKG=logs ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/logs/... -v -count 1 -parallel 3  -run=TestAccLogsAccountPolicy_ -timeout 360m
=== RUN   TestAccLogsAccountPolicy_basicSubscriptionFilter
=== PAUSE TestAccLogsAccountPolicy_basicSubscriptionFilter
=== RUN   TestAccLogsAccountPolicy_basicDataProtection
=== PAUSE TestAccLogsAccountPolicy_basicDataProtection
=== RUN   TestAccLogsAccountPolicy_disappears
=== PAUSE TestAccLogsAccountPolicy_disappears
=== RUN   TestAccLogsAccountPolicy_selectionCriteria
=== PAUSE TestAccLogsAccountPolicy_selectionCriteria
=== CONT  TestAccLogsAccountPolicy_basicSubscriptionFilter
=== CONT  TestAccLogsAccountPolicy_disappears
=== CONT  TestAccLogsAccountPolicy_selectionCriteria
--- PASS: TestAccLogsAccountPolicy_disappears (11.99s)
=== CONT  TestAccLogsAccountPolicy_basicDataProtection
--- PASS: TestAccLogsAccountPolicy_basicDataProtection (10.97s)
--- PASS: TestAccLogsAccountPolicy_basicSubscriptionFilter (27.06s)
--- PASS: TestAccLogsAccountPolicy_selectionCriteria (38.83s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/logs	43.828s

@ewbankkit
Copy link
Contributor

@chrisbrowning Thanks for the contribution 🎉 👏.

Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@ewbankkit ewbankkit merged commit cd31961 into hashicorp:main Jul 11, 2024
11 checks passed
@github-actions github-actions bot added this to the v5.58.0 milestone Jul 11, 2024
Copy link

This functionality has been released in v5.58.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. service/logs Issues and PRs that pertain to the logs service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Amazon CloudWatch Logs account level subscription filter
2 participants