Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] aws_batch_job_definition: add extra nil checks #38716

Merged
merged 3 commits into from
Aug 7, 2024

Conversation

aristosvo
Copy link
Contributor

@aristosvo aristosvo commented Aug 6, 2024

Description

Extra nil check in the aws_batch_job_definition resource

Relations

Closes #38710
Closes #38684
Closes #37349
Closes #37422

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=batch

...

Copy link

github-actions bot commented Aug 6, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/batch Issues and PRs that pertain to the batch service. needs-triage Waiting for first response or review from a maintainer. labels Aug 6, 2024
@aristosvo aristosvo marked this pull request as ready for review August 7, 2024 12:23
@aristosvo aristosvo requested a review from a team as a code owner August 7, 2024 12:23
@jar-b jar-b added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 7, 2024
@jar-b jar-b self-assigned this Aug 7, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 7, 2024
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=batch TESTS=TestAccBatchJobDefinition_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/batch/... -v -count 1 -parallel 20 -run='TestAccBatchJobDefinition_'  -timeout 360m

--- PASS: TestAccBatchJobDefinition_createTypeMultiNodeWithContainerProperties (18.67s)
=== CONT  TestAccBatchJobDefinition_EKSProperties_imagePullSecrets
--- PASS: TestAccBatchJobDefinition_createTypeContainerWithNodeProperties (19.39s)
=== CONT  TestAccBatchJobDefinition_EKSProperties_update
--- PASS: TestAccBatchJobDefinition_ContainerProperties_EmptyField (43.63s)
=== CONT  TestAccBatchJobDefinition_EKSProperties_basic
--- PASS: TestAccBatchJobDefinition_schedulingPriority (43.93s)
=== CONT  TestAccBatchJobDefinition_NodeProperties_advanced
=== CONT  TestAccBatchJobDefinition_NodeProperties_basic
--- PASS: TestAccBatchJobDefinition_basic (44.13s)
--- PASS: TestAccBatchJobDefinition_tags_DefaultTags_nullOverlappingResourceTag (51.75s)
=== CONT  TestAccBatchJobDefinition_PlatformCapabilities_fargate
--- PASS: TestAccBatchJobDefinition_tags_DefaultTags_emptyResourceTag (52.26s)
=== CONT  TestAccBatchJobDefinition_propagateTags
--- PASS: TestAccBatchJobDefinition_tags_DefaultTags_emptyProviderOnlyTag (52.29s)
=== CONT  TestAccBatchJobDefinition_ContainerProperties_minorUpdate
--- PASS: TestAccBatchJobDefinition_EKSProperties_imagePullSecrets (34.98s)
=== CONT  TestAccBatchJobDefinition_ContainerProperties_advanced
--- PASS: TestAccBatchJobDefinition_tags_DefaultTags_updateToResourceOnly (73.71s)
=== CONT  TestAccBatchJobDefinition_tags_ComputedTag_OnCreate
--- PASS: TestAccBatchJobDefinition_EKSProperties_update (56.55s)
=== CONT  TestAccBatchJobDefinition_PlatformCapabilities_ec2
--- PASS: TestAccBatchJobDefinition_tags_EmptyTag_OnUpdate_Replace (76.15s)
=== CONT  TestAccBatchJobDefinition_PlatformCapabilitiesFargate_containerPropertiesDefaults
--- PASS: TestAccBatchJobDefinition_tags_DefaultTags_updateToProviderOnly (76.27s)
=== CONT  TestAccBatchJobDefinition_tags_AddOnUpdate
--- PASS: TestAccBatchJobDefinition_tags_ComputedTag_OnUpdate_Add (76.33s)
=== CONT  TestAccBatchJobDefinition_tags_null
=== CONT  TestAccBatchJobDefinition_disappears
--- PASS: TestAccBatchJobDefinition_tags_DefaultTags_nullNonOverlappingResourceTag (76.47s)
--- PASS: TestAccBatchJobDefinition_EKSProperties_basic (37.90s)
=== CONT  TestAccBatchJobDefinition_attributes
--- PASS: TestAccBatchJobDefinition_tags_ComputedTag_OnUpdate_Replace (83.95s)
--- PASS: TestAccBatchJobDefinition_NodeProperties_basic (39.81s)
--- PASS: TestAccBatchJobDefinition_propagateTags (31.85s)
--- PASS: TestAccBatchJobDefinition_PlatformCapabilities_fargate (40.29s)
--- PASS: TestAccBatchJobDefinition_NodeProperties_advanced (59.49s)
--- PASS: TestAccBatchJobDefinition_disappears (28.35s)
--- PASS: TestAccBatchJobDefinition_tags_EmptyTag_OnCreate (106.39s)
--- PASS: TestAccBatchJobDefinition_tags_EmptyTag_OnUpdate_Add (107.55s)
--- PASS: TestAccBatchJobDefinition_PlatformCapabilities_ec2 (33.05s)
--- PASS: TestAccBatchJobDefinition_PlatformCapabilitiesFargate_containerPropertiesDefaults (34.16s)
--- PASS: TestAccBatchJobDefinition_tags_ComputedTag_OnCreate (38.28s)
--- PASS: TestAccBatchJobDefinition_tags_DefaultTags_nonOverlapping (114.21s)
--- PASS: TestAccBatchJobDefinition_tags_DefaultTags_overlapping (114.28s)
--- PASS: TestAccBatchJobDefinition_tags_null (39.22s)
--- PASS: TestAccBatchJobDefinition_tags_AddOnUpdate (45.63s)
--- PASS: TestAccBatchJobDefinition_tags (125.80s)
--- PASS: TestAccBatchJobDefinition_tags_DefaultTags_providerOnly (134.62s)
--- PASS: TestAccBatchJobDefinition_attributes (55.17s)
--- PASS: TestAccBatchJobDefinition_ContainerProperties_minorUpdate (91.26s)
--- PASS: TestAccBatchJobDefinition_ContainerProperties_advanced (95.85s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/batch      155.527s

@jar-b
Copy link
Member

jar-b commented Aug 7, 2024

Thanks for your contribution, @aristosvo! 👍

@jar-b jar-b added the crash Results from or addresses a Terraform crash or kernel panic. label Aug 7, 2024
@jar-b jar-b merged commit 6ed0de6 into hashicorp:main Aug 7, 2024
44 checks passed
@github-actions github-actions bot added this to the v5.62.0 milestone Aug 7, 2024
Copy link

github-actions bot commented Aug 9, 2024

This functionality has been released in v5.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 9, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. service/batch Issues and PRs that pertain to the batch service.
Projects
None yet
2 participants