Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Changing display_name in identitystore_group should not force identitystore_group replacement. #39415

Closed
jylitalo opened this issue Sep 20, 2024 · 4 comments · Fixed by #39416
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/identitystore Issues and PRs that pertain to the identitystore service.
Milestone

Comments

@jylitalo
Copy link
Contributor

jylitalo commented Sep 20, 2024

Description

It should be possible to change identitystore_group's display_name with modify instead of destroy/apply.

Affected Resource(s) and/or Data Source(s)

  • aws_identitystore_group

Potential Terraform Configuration

Right now terraform claims that change in display_name forces replacement, even though group_id and identity_store_id are the only fields that are needed as keys in `resourceGroupUpdate()` function.
This is probably due to `ForceNew: true,` at https://github.com/hashicorp/terraform-provider-aws/blob/dd90468c8aec95815afca8e1aaa2b6d17d2098d2/internal/service/identitystore/group.go#L49C5-L49C24

References

You can change identitystore_group name with aws identitystore update-group --identity-store-id d-... --group-id ...-...-...-...-... --operations '[{ "AttributePath": "DisplayName","AttributeValue": "NewName" }]'

Would you like to implement a fix?

No

@jylitalo jylitalo added the enhancement Requests to existing resources that expand the functionality or scope. label Sep 20, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added service/identitystore Issues and PRs that pertain to the identitystore service. needs-triage Waiting for first response or review from a maintainer. labels Sep 20, 2024
@jylitalo jylitalo changed the title [Enhancement]: Changing display_name in identitystore_group should not force new identitystore_group. [Enhancement]: Changing display_name in identitystore_group should not force identitystore_group replacement. Sep 20, 2024
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Sep 20, 2024
@alex-gunning
Copy link

Thank you for submitting something! This is a major issue for my company as well!

Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.69.0 milestone Sep 25, 2024
Copy link

This functionality has been released in v5.69.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/identitystore Issues and PRs that pertain to the identitystore service.
Projects
None yet
3 participants