New Resource: aws_network_acl_association

aws/provider.go

@@ -374,6 +374,7 @@ func Provider() terraform.ResourceProvider {
  "aws_main_route_table_association": resourceAwsMainRouteTableAssociation(),
  "aws_nat_gateway": resourceAwsNatGateway(),
  "aws_network_acl": resourceAwsNetworkAcl(),
+ "aws_network_acl_association": resourceAwsNetworkAclAssociation(),
  "aws_default_network_acl": resourceAwsDefaultNetworkAcl(),
  "aws_network_acl_rule": resourceAwsNetworkAclRule(),
  "aws_network_interface": resourceAwsNetworkInterface(),

aws/resource_aws_network_acl_association.go

@@ -0,0 +1,140 @@
+package aws
+
+import (
+ "fmt"
+ "log"
+ "time"
+
+ "github.com/aws/aws-sdk-go/aws"
+ "github.com/aws/aws-sdk-go/aws/awserr"
+ "github.com/aws/aws-sdk-go/service/ec2"
+ "github.com/hashicorp/terraform/helper/resource"
+ "github.com/hashicorp/terraform/helper/schema"
+)
+
+func resourceAwsNetworkAclAssociation() *schema.Resource {
+ return &schema.Resource{
+ Create: resourceAwsNetworkAclAssociationCreate,
+ Read: resourceAwsNetworkAclAssociationRead,
+ Update: resourceAwsNetworkAclAssociationUpdate,
+ Delete: resourceAwsNetworkAclAssociationDelete,
+
+ Schema: map[string]*schema.Schema{
+ "subnet_id": &schema.Schema{
+ Type: schema.TypeString,
+ Required: true,
+ },
+
+ "network_acl_id": &schema.Schema{
+ Type: schema.TypeString,
+ Required: true,
+ },
+ },
+ }
+}
+
+func resourceAwsNetworkAclAssociationCreate(d *schema.ResourceData, meta interface{}) error {
+ conn := meta.(*AWSClient).ec2conn
+
+ naclId := d.Get("network_acl_id").(string)
+ subnetId := d.Get("subnet_id").(string)
+
+ log.Printf(
+ "[INFO] Creating network acl association: %s => %s",
+ subnetId,
+ naclId)
+
+ association, err_association := findNetworkAclAssociation(subnetId, conn)
+ if err_association != nil {
+ return fmt.Errorf("Failed to create acl %s with nacl %s: %s", d.Id(), naclId, err_association)
+ }
+
+ associationOpts := ec2.ReplaceNetworkAclAssociationInput{
+ AssociationId: association.NetworkAclAssociationId,
+ NetworkAclId: aws.String(naclId),
+ }
+
+ var err error
+ err = resource.Retry(5*time.Minute, func() *resource.RetryError {
+ _, err = conn.ReplaceNetworkAclAssociation(&associationOpts)
+ if err != nil {
+ if awsErr, ok := err.(awserr.Error); ok {
+ if awsErr != nil {
+ return resource.RetryableError(awsErr)
+ }
+ }
+ return resource.NonRetryableError(err)
+ }
+ return nil
+ })
+ if err != nil {
+ return err
+ }
+
+ // Set the ID and return
+ d.SetId(naclId)
+ log.Printf("[INFO] Association ID: %s", d.Id())
+
+ return resourceAwsNetworkAclAssociationRead(d, meta)
+}
+
+func resourceAwsNetworkAclAssociationRead(d *schema.ResourceData, meta interface{}) error {
+ conn := meta.(*AWSClient).ec2conn
+
+ // Inspect that the association exists
+ subnetId := d.Get("subnet_id").(string)
+ _, err_association := findNetworkAclAssociation(subnetId, conn)
+ if err_association != nil {
+ log.Printf("[INFO] Association for %s was not found.", subnetId)
+ d.SetId("")
+ return nil
+ }
+
+ return nil
+}
+
+func resourceAwsNetworkAclAssociationUpdate(d *schema.ResourceData, meta interface{}) error {
+ conn := meta.(*AWSClient).ec2conn
+
+ naclId := d.Get("network_acl_id").(string)
+ subnetId := d.Get("subnet_id").(string)
+
+ log.Printf(
+ "[INFO] Creating network acl association: %s => %s",
+ subnetId,
+ naclId)
+
+ association, err_association := findNetworkAclAssociation(subnetId, conn)
+ if err_association != nil {
+ return fmt.Errorf("Failed to update acl %s with subnet %s: %s", d.Id(), naclId, err_association)
+ }
+
+ req := &ec2.ReplaceNetworkAclAssociationInput{
+ AssociationId: association.NetworkAclAssociationId,
+ NetworkAclId: aws.String(naclId),
+ }
+ resp, err := conn.ReplaceNetworkAclAssociation(req)
+
+ if err != nil {
+ ec2err, ok := err.(awserr.Error)
+ if ok && ec2err.Code() == "InvalidAssociationID.NotFound" {
+ // Not found, so just create a new one
+ return resourceAwsNetworkAclAssociationCreate(d, meta)
+ }
+
+ return err
+ }
+
+ // Update the ID
+ d.SetId(*resp.NewAssociationId)
+ log.Printf("[INFO] Association ID: %s", d.Id())
+
+ return resourceAwsNetworkAclAssociationRead(d, meta)
+}
+
+func resourceAwsNetworkAclAssociationDelete(d *schema.ResourceData, meta interface{}) error {
+
+ log.Printf("[INFO] Do nothing on network acl associatioØ destroy phase: %s", d.Id())
+
+ return nil
+}

aws/resource_aws_network_acl_association_test.go

@@ -0,0 +1,69 @@
+package aws
+
+import (
+ "fmt"
+ "testing"
+
+ "github.com/hashicorp/terraform/helper/resource"
+ "github.com/hashicorp/terraform/terraform"
+)
+
+func TestAccAWSNetworkAclAssociation(t *testing.T) {
+
+ resource.Test(t, resource.TestCase{
+ PreCheck: func() { testAccPreCheck(t) },
+ IDRefreshName: "aws_network_acl.bar",
+ Providers: testAccProviders,
+ CheckDestroy: testAccCheckAWSNetworkAclDestroy,
+ Steps: []resource.TestStep{
+ {
+ Config: testAccAWSNetworkAclAssoc,
+ Check: resource.ComposeAggregateTestCheckFunc(
+ testCheckAwsRMNetworkAclAssocExists("aws_network_acl_association.test"),
+ ),
+ },
+ },
+ })
+}
+
+func testCheckAwsRMNetworkAclAssocExists(name string) resource.TestCheckFunc {
+ return func(s *terraform.State) error {
+
+ _, ok := s.RootModule().Resources[name]
+ if !ok {
+ return fmt.Errorf("Not found: %s", name)
+ }
+
+ return nil
+ }
+}
+
+const testAccAWSNetworkAclAssoc = `
+resource "aws_vpc" "testespvpc" {
+ cidr_block = "10.1.0.0/16"
+ tags {
+ Name = "testAccAWSNetworkAclEsp"
+ }
+}
+
+ resource "aws_network_acl" "acl_a" {
+ vpc_id = "${aws_vpc.testespvpc.id}"
+
+ tags {
+ Name = "terraform test"
+ }
+ }
+
+ resource "aws_subnet" "sunet_a" {
+ vpc_id = "${aws_vpc.testespvpc.id}"
+ cidr_block = "10.0.33.0/24"
+ tags {
+ Name = "terraform test"
+ }
+ }
+
+ resource "aws_network_acl_association" "test" {
+ network_acl_id = "${aws_network_acl.acl_a.id}"
+ subnet_id = "${aws_subnet.subnet_a.id}"
+ }
+}`

website/aws.erb

@@ -1405,6 +1405,10 @@
  <a href="/docs/providers/aws/r/network_acl.html">aws_network_acl</a>
  </li>
 
+ <li<%= sidebar_current("docs-aws-resource-network-acl-assoc") %>>
+ <a href="/docs/providers/aws/r/network_acl_assoc.html">aws_network_acl_association</a>
+ </li>
+
  <li<%= sidebar_current("docs-aws-resource-network-acl-rule") %>>
  <a href="/docs/providers/aws/r/network_acl_rule.html">aws_network_acl_rule</a>
  </li>

website/docs/r/network_acl_assoc.html.markdown

@@ -0,0 +1,36 @@
+---
+layout: "aws"
+page_title: "AWS: aws_network_acl_association"
+sidebar_current: "docs-aws-resource-network-acl-association"
+description: |-
+ Provides an network ACL association resource.
+---
+
+# aws\_network\_acl\_association
+
+Provides an network ACL association resource. You might set up network ACLs associate to your subnet.
+
+## Example Usage
+
+```hcl
+resource "aws_network_acl_association" "main" {
+ network_acl_id = "${aws_network_acl.main.id}"
+ subnet_id = "${aws_subnet.main.id}"
+}
+```
+
+## Argument Reference
+
+The following arguments are supported:
+
+* `network_acl_id` - (Required) The ID of the network acl .
+* `subnet_id` - (Required) The ID of the associated Subnet.
+
+## Attributes Reference
+
+The following attributes are exported:
+
+* `id` - The ID of the network ACL
+* `network_acl_id` - The ID of the network ACL
+* `subnet_id` - The ID of the subnet id
+