Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Tag Support to API Gateway VPC Link Resource #10561

Merged
merged 7 commits into from
Nov 4, 2019
Merged

Add Tag Support to API Gateway VPC Link Resource #10561

merged 7 commits into from
Nov 4, 2019

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Oct 19, 2019 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #8744

Release note for CHANGELOG:

- resource/resource_aws_api_gateway_vpc_link: Add `tags` argument.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSAPIGatewayVpcLink_'

=== RUN   TestAccAWSAPIGatewayVpcLink_basic
=== PAUSE TestAccAWSAPIGatewayVpcLink_basic
=== CONT  TestAccAWSAPIGatewayVpcLink_basic
--- PASS: TestAccAWSAPIGatewayVpcLink_basic (786.64s)
=== RUN   TestAccAWSAPIGatewayVpcLink_tags
=== PAUSE TestAccAWSAPIGatewayVpcLink_tags
=== CONT  TestAccAWSAPIGatewayVpcLink_tags
--- PASS: TestAccAWSAPIGatewayVpcLink_tags (857.83s)
=== RUN   TestAccAWSAPIGatewayVpcLink_importBasic
=== PAUSE TestAccAWSAPIGatewayVpcLink_importBasic
=== CONT  TestAccAWSAPIGatewayVpcLink_importBasic
--- PASS: TestAccAWSAPIGatewayVpcLink_importBasic (946.88s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	955.390s

...

@DrFaust92 DrFaust92 requested a review from a team October 19, 2019 22:28
@ghost ghost added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 19, 2019
@ewbankkit
Copy link
Contributor

Relates #8744.

@ewbankkit ewbankkit mentioned this pull request Oct 20, 2019
Closed
@DrFaust92 DrFaust92 force-pushed the tag-support-api-gateway-vpc-link branch from ddcacbb to 3ec9b5e Compare November 2, 2019 11:19
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/apigateway Issues and PRs that pertain to the apigateway service. labels Nov 4, 2019
@bflad bflad added this to the v2.35.0 milestone Nov 4, 2019
bflad
bflad approved these changes Nov 4, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @DrFaust92 🚀

--- PASS: TestAccAWSAPIGatewayVpcLink_basic (700.66s)
--- PASS: TestAccAWSAPIGatewayVpcLink_tags (726.60s)

@bflad bflad merged commit 840ba76 into hashicorp:master Nov 4, 2019
bflad added a commit that referenced this pull request Nov 4, 2019
@bflad
Update CHANGELOG for #10561
4e3f47a
bflad added a commit that referenced this pull request Nov 4, 2019
@bflad
provider: Ensure hashibot labeling for apigateway catches aws_api_gat…
3018727 
…eway_vpc_link

Reference: #10561
bflad added a commit that referenced this pull request Nov 4, 2019
@bflad
Various hashibot labeling fixes/additions (#10732)
f5b1da3 
* provider: Hashibot issue/PR matching for CloudTrail should not include trailing underscore

Reference: #10730

The CloudTrail Trail resource is named just `aws_cloudtrail`.

* provider: Hashibot pull request labeling for route53resolver should include underscore

Reference: #10348

* provider: Add missing pull request labeling for qldb

Reference: #10394

* provider: Fix hashibot pull request labeling for athena

Reference: #10609

* provider: Ensure hashibot labeling for apigateway catches aws_api_gateway_vpc_link

Reference: #10561
@ghost
Copy link

ghost commented Nov 7, 2019

This has been released in version 2.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@DrFaust92 DrFaust92 deleted the tag-support-api-gateway-vpc-link branch November 9, 2019 12:47
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/apigateway Issues and PRs that pertain to the apigateway service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.35.0
Development

Successfully merging this pull request may close these issues.
3 participants
@DrFaust92 @ewbankkit @bflad