Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attributes for aws_transfer_user resource #11483

Conversation

teraken0509
Copy link
Contributor

@teraken0509 teraken0509 commented Jan 5, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11281

Release note for CHANGELOG:

Add home_directory_type and home_directory_mappings attributes for aws_transfer_user resource

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSTransferUser_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSTransferUser_ -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSTransferUser_basic
=== PAUSE TestAccAWSTransferUser_basic
=== RUN   TestAccAWSTransferUser_modifyWithOptions
=== PAUSE TestAccAWSTransferUser_modifyWithOptions
=== RUN   TestAccAWSTransferUser_disappears
=== PAUSE TestAccAWSTransferUser_disappears
=== RUN   TestAccAWSTransferUser_UserName_Validation
=== PAUSE TestAccAWSTransferUser_UserName_Validation
=== RUN   TestAccAWSTransferUser_homeDirectoryMappings
=== PAUSE TestAccAWSTransferUser_homeDirectoryMappings
=== CONT  TestAccAWSTransferUser_basic
=== CONT  TestAccAWSTransferUser_UserName_Validation
=== CONT  TestAccAWSTransferUser_homeDirectoryMappings
=== CONT  TestAccAWSTransferUser_modifyWithOptions
=== CONT  TestAccAWSTransferUser_disappears
--- PASS: TestAccAWSTransferUser_UserName_Validation (16.74s)
--- PASS: TestAccAWSTransferUser_disappears (40.76s)
--- PASS: TestAccAWSTransferUser_basic (43.77s)
--- PASS: TestAccAWSTransferUser_homeDirectoryMappings (69.97s)
--- PASS: TestAccAWSTransferUser_modifyWithOptions (105.03s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	105.116s
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/flatmap	0.013s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/keyvaluetags	0.118s [no tests to run]

@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/L Managed by automation to categorize the size of a PR. service/transfer Issues and PRs that pertain to the transfer service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 5, 2020
@teraken0509 teraken0509 force-pushed the feature/add-attribute-for-aws_transfer_user-resource branch from b06b21b to 3c89dd7 Compare January 10, 2020 05:06
@ghost ghost added the documentation Introduces or discusses updates to documentation. label Jan 10, 2020
@teraken0509 teraken0509 marked this pull request as ready for review January 10, 2020 05:07
@teraken0509 teraken0509 requested a review from a team January 10, 2020 05:07
@alexlance
Copy link

LGTM, can we get this into a release soon?

@ewbankkit
Copy link
Contributor

@teraken0509 I'm going to close this as your work has been pulled into #13459. Thank you for the contribution here.

@ewbankkit ewbankkit closed this Jun 8, 2020
@ghost
Copy link

ghost commented Jul 9, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 9, 2020
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/transfer Issues and PRs that pertain to the transfer service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_transfer_user should provide home-directory-mappings option.
4 participants