Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] New package for Autoscaling tags functionality #13508

Closed
wants to merge 11 commits into from

Conversation

ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #10688.
Relates #10689.
Relates #9049.
Relates #6375.

WIP of an implementation of Autoscaling service tagging functionality similar to that for other AWS services in the keyvaluetags package, but without code generation.

Release note for CHANGELOG:

TODO

Output from acceptance testing:

TODO

@ewbankkit ewbankkit requested a review from a team May 26, 2020 21:50
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 26, 2020
@ewbankkit

This comment has been minimized.

@ewbankkit
Copy link
Contributor Author

TODO

After #13515, tags is also of type schema.TypeSet, so the SetSchema/ListSchema distinction needs to be rethought.
Also, in resourcetags.New, the []interface{} case should be collapsed into the *schema.Set case.

@ewbankkit
Copy link
Contributor Author

Replaced by #13868.

@ewbankkit ewbankkit closed this Jun 22, 2020
@ewbankkit ewbankkit deleted the td-autoscaling-tags branch June 22, 2020 15:26
@ghost
Copy link

ghost commented Jul 22, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 22, 2020
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants