aws_route: Retry if route not found after creating it

[alewando]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #13138

Release note for CHANGELOG:

When creating route, retry until route is visible (respecting configured timeout)

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

[alewando]

When resourceAwsRouteFindRoute() returns a nil value (ie: route not found), it was being wrapped as a resource.RetryableError(nil) value. The lack of an non-nil err value inside RetryableError was causing the Retry logic to treat at is if it were and immediate timeout, and not executing any retries.
This pull request puts an actual error inside RetryableError, thus triggering the expected retries.

[ewbankkit]

@alewando Thanks for the contribution.
Could you please make the same change to the destination_ipv6_cidr_block block?
Relates: #13409.

[alewando]

Thanks for identifying that, @ewbankkit! The PR was updated to also implement the fix for destination_ipv6_cidr_block.

[bflad]

Thank you for this fix, @alewando 🚀

Output from acceptance testing:

--- PASS: TestAccAWSRoute_basic (56.69s)
--- PASS: TestAccAWSRoute_changeCidr (43.84s)
--- PASS: TestAccAWSRoute_changeRouteTable (48.75s)
--- PASS: TestAccAWSRoute_disappears (29.82s)
--- PASS: TestAccAWSRoute_doesNotCrashWithVPCEndpoint (40.48s)
--- PASS: TestAccAWSRoute_ipv6Support (41.10s)
--- PASS: TestAccAWSRoute_ipv6ToInstance (101.37s)
--- PASS: TestAccAWSRoute_ipv6ToInternetGateway (35.51s)
--- PASS: TestAccAWSRoute_ipv6ToNetworkInterface (122.20s)
--- PASS: TestAccAWSRoute_ipv6ToPeeringConnection (38.36s)
--- PASS: TestAccAWSRoute_noopdiff (72.92s)
--- PASS: TestAccAWSRoute_TransitGatewayID_DestinationCidrBlock (259.74s)

[ghost]

This has been released in version 2.67.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!