resource/aws_elasticache_replication_group: Add MultiAZ support

[pcantea]

Closes #13706

Add multi_az_enabled parameter to aws_elasticache_replication_group

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #13706

Release note for CHANGELOG:

resource/aws_elasticache_replication_group: Add `multi_az` argument 

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

[sc250024]

Possible to get this merged please? 🙏

[Type1J]

Please assign a reviewer to this PR, and get this PR merged. I'm stuck with hacks until then that I've been having to defend in code reviews.

[ankithriday]

Need this merged, don't want to have to do the provisioner workaround

[ppapishe]

hope this gets merged soon so that we do not have to use in-efficient workarounds

[bflad]

Hi @goodspellar 👋 Apologies for the delayed review here and thank you for the contribution. Overall this is looking good.

This was going to be looked at next week as part of our freshly updated Roadmap, but to jump ahead and give you something actionable now -- it looks like the only thing might be to create new testing (functions and configurations) instead of modifying the existing testing. Copy-paste-modify if fine/encouraged. This helps us ensure there are no regressions with existing functionality before we release it.

Please reach out if you have any questions or do not have time to adjust this. Should hopefully be a quick merge after that change. 👍

[pcantea]

@bflad Thanks for the review, sorry it took me so long to get around to it, I have some free time this week to work on this. I updated the TestAccAWSElasticacheReplicationGroup_multiAzInVpc test because, as the name implies, it tests multi-az support. I will create new tests for the other two I updated, however, for the first one would you still like me to create a new test or can I update the existing?

[metroshica]

Could we get a review on this? Seems like it's a pretty popular request.

[sc250024]

Seriously, almost 8 months now.

[ghost]

This has been released in version 3.26.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!