Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource: aws_elasticsearch_package #13920

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions aws/provider.go
Original file line number Diff line number Diff line change
Expand Up @@ -592,6 +592,7 @@ func Provider() terraform.ResourceProvider {
"aws_elastic_beanstalk_environment": resourceAwsElasticBeanstalkEnvironment(),
"aws_elasticsearch_domain": resourceAwsElasticSearchDomain(),
"aws_elasticsearch_domain_policy": resourceAwsElasticSearchDomainPolicy(),
"aws_elasticsearch_package": resourceAwsElasticsearchPackage(),
"aws_elastictranscoder_pipeline": resourceAwsElasticTranscoderPipeline(),
"aws_elastictranscoder_preset": resourceAwsElasticTranscoderPreset(),
"aws_elb": resourceAwsElb(),
Expand Down
148 changes: 148 additions & 0 deletions aws/resource_aws_elasticsearch_package.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,148 @@
package aws

import (
"fmt"
"log"

"github.com/aws/aws-sdk-go/aws"
elasticsearch "github.com/aws/aws-sdk-go/service/elasticsearchservice"
"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
"github.com/hashicorp/terraform-plugin-sdk/helper/validation"
)

func resourceAwsElasticsearchPackage() *schema.Resource {
return &schema.Resource{
Create: resourceAwsElasticsearchPackageCreate,
Read: resourceAwsElasticsearchPackageRead,
Delete: resourceAwsElasticsearchPackageDelete,

Schema: map[string]*schema.Schema{
"name": {
Type: schema.TypeString,
Required: true,
ForceNew: true,
ValidateFunc: validation.StringLenBetween(3, 28),
},
"type": {
Type: schema.TypeString,
Required: true,
ForceNew: true,
ValidateFunc: validation.StringInSlice([]string{
elasticsearch.PackageTypeTxtDictionary,
}, false),
},
"description": {
Type: schema.TypeString,
Optional: true,
ForceNew: true,
},
"source": {
Type: schema.TypeList,
MaxItems: 1,
Required: true,
ForceNew: true,
Elem: &schema.Resource{
Schema: map[string]*schema.Schema{
"s3_bucket_name": {
Type: schema.TypeString,
Required: true,
ValidateFunc: validation.StringIsNotEmpty,
},
"s3_key": {
Type: schema.TypeString,
Required: true,
ValidateFunc: validation.StringIsNotEmpty,
},
},
},
},
},
}
}

func resourceAwsElasticsearchPackageCreate(d *schema.ResourceData, meta interface{}) error {
conn := meta.(*AWSClient).esconn

name := d.Get("name").(string)
source := d.Get("source").([]interface{})[0].(map[string]interface{})

input := &elasticsearch.CreatePackageInput{
PackageName: aws.String(name),
PackageType: aws.String(d.Get("type").(string)),
PackageDescription: aws.String(d.Get("description").(string)),
PackageSource: &elasticsearch.PackageSource{
S3BucketName: aws.String(source["s3_bucket_name"].(string)),
S3Key: aws.String(source["s3_key"].(string)),
},
}

out, err := conn.CreatePackage(input)
if err != nil {
return fmt.Errorf("Error creating Elasticsearch Package %s: %s", name, err)
}

d.SetId(aws.StringValue(out.PackageDetails.PackageID))

return resourceAwsElasticsearchPackageRead(d, meta)
}

func resourceAwsElasticsearchPackageRead(d *schema.ResourceData, meta interface{}) error {
conn := meta.(*AWSClient).esconn

details, err := getElasticsearchPackage(conn, d.Id())
if err != nil {
if isAWSErr(err, "ResourceNotFoundException", "") {
log.Printf("[WARN] ElasticSearch Package (%s) not found, removing from state", d.Id())
d.SetId("")
return nil
}

return fmt.Errorf("Error reading ElasticSearch Package: %s", err)
}

if details == nil {
log.Printf("[WARN] ElasticSearch Package (%s) not found, removing from state", d.Id())
d.SetId("")
return nil
}

d.SetId(aws.StringValue(details.PackageID))
d.Set("name", details.PackageName)
d.Set("description", details.PackageDescription)
d.Set("type", details.PackageType)

return nil
}

func resourceAwsElasticsearchPackageDelete(d *schema.ResourceData, meta interface{}) error {
conn := meta.(*AWSClient).esconn

input := &elasticsearch.DeletePackageInput{PackageID: aws.String(d.Id())}
_, err := conn.DeletePackage(input)
if err != nil {
return fmt.Errorf("Error deleting Elasticsearch Package: %v", err)
}

return nil
}

func getElasticsearchPackage(conn *elasticsearch.ElasticsearchService, packageID string) (*elasticsearch.PackageDetails, error) {
input := &elasticsearch.DescribePackagesInput{
Filters: []*elasticsearch.DescribePackagesFilter{
{
Name: aws.String("PackageID"),
Value: []*string{aws.String(packageID)},
},
},
}
output, err := conn.DescribePackages(input)
if err != nil {
return nil, err
}

if output == nil || len(output.PackageDetailsList) == 0 {
return nil, nil
}

return output.PackageDetailsList[0], nil
}
138 changes: 138 additions & 0 deletions aws/resource_aws_elasticsearch_package_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,138 @@
package aws

import (
"fmt"
"testing"

elasticsearch "github.com/aws/aws-sdk-go/service/elasticsearchservice"
"github.com/hashicorp/terraform-plugin-sdk/helper/acctest"
"github.com/hashicorp/terraform-plugin-sdk/helper/resource"
"github.com/hashicorp/terraform-plugin-sdk/terraform"
)

func TestAccAWSElasticsearchPackage_basic(t *testing.T) {
rString := acctest.RandString(7)
prefix := "tf-acctest-espackage"
name := fmt.Sprintf("%s-%s", prefix, rString)
resourceName := "aws_elasticsearch_package.test"

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { testAccPreCheck(t) },
Providers: testAccProviders,
CheckDestroy: testAccCheckAWSElasticsearchPackageDestroy,
Steps: []resource.TestStep{
{
Config: testAccAWSElasticsearchPackageConfig_basic(name),
Check: resource.ComposeTestCheckFunc(
testAccCheckAWSElasticsearchPackageExists(resourceName),
resource.TestCheckResourceAttr(resourceName, "name", name),
resource.TestCheckResourceAttr(resourceName, "type", elasticsearch.PackageTypeTxtDictionary),
resource.TestCheckResourceAttr(resourceName, "description", "terraform acctest"),
resource.TestCheckResourceAttr(resourceName, "source.0.s3_bucket_name", name+"-bucket"),
resource.TestCheckResourceAttr(resourceName, "source.0.s3_key", "synonyms.txt"),
),
},
},
})
}

func TestAccAWSElasticsearchPackage_disappears(t *testing.T) {
rString := acctest.RandString(7)
prefix := "tf-acctest-espackage"
name := fmt.Sprintf("%s-%s", prefix, rString)
resourceName := "aws_elasticsearch_package.test"

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { testAccPreCheck(t) },
Providers: testAccProviders,
CheckDestroy: testAccCheckAWSElasticsearchPackageDestroy,
Steps: []resource.TestStep{
{
Config: testAccAWSElasticsearchPackageConfig_basic(name),
Check: resource.ComposeTestCheckFunc(
testAccCheckAWSElasticsearchPackageExists(resourceName),
testAccCheckResourceDisappears(testAccProvider, resourceAwsElasticsearchPackage(), resourceName),
),
ExpectNonEmptyPlan: true,
},
},
})
}

func testAccCheckAWSElasticsearchPackageExists(resourceName string) resource.TestCheckFunc {
return func(s *terraform.State) error {
rs, ok := s.RootModule().Resources[resourceName]
if !ok {
return fmt.Errorf("Not found: %s", resourceName)
}

if rs.Primary.ID == "" {
return fmt.Errorf("No Elasticsearch Package ID is set")
}

conn := testAccProvider.Meta().(*AWSClient).esconn

details, err := getElasticsearchPackage(conn, rs.Primary.ID)
if err != nil {
return err
}

if details == nil {
return fmt.Errorf("Elasticsearch Package (%s) not found", rs.Primary.ID)
}

return nil
}
}

func testAccCheckAWSElasticsearchPackageDestroy(s *terraform.State) error {
conn := testAccProvider.Meta().(*AWSClient).esconn

for _, rs := range s.RootModule().Resources {
if rs.Type != "aws_elasticsearch_package" {
continue
}

details, err := getElasticsearchPackage(conn, rs.Primary.ID)

if isAWSErr(err, "ResourceNotFoundException", "") {
continue
}

if err != nil {
return err
}

if details == nil {
continue
}

return fmt.Errorf("Elasticsearch Package (%s) still exists", rs.Primary.ID)
}

return nil
}

func testAccAWSElasticsearchPackageConfig_basic(name string) string {
return fmt.Sprintf(`
resource "aws_s3_bucket" "test" {
bucket = "%[1]s-bucket"
}

resource "aws_s3_bucket_object" "test" {
bucket = "${aws_s3_bucket.test.bucket}"
key = "synonyms.txt"
content = "foo, bar"
}

resource "aws_elasticsearch_package" "test" {
name = "%[1]s"
type = "TXT-DICTIONARY"
description = "terraform acctest"
source {
s3_bucket_name = "${aws_s3_bucket.test.bucket}"
s3_key = "${aws_s3_bucket_object.test.key}"
}
}
`, name)
}
3 changes: 3 additions & 0 deletions website/aws.erb
Original file line number Diff line number Diff line change
Expand Up @@ -1664,6 +1664,9 @@
<li>
<a href="/docs/providers/aws/r/elasticsearch_domain_policy.html">aws_elasticsearch_domain_policy</a>
</li>
<li>
<a href="/docs/providers/aws/r/elasticsearch_package.html">aws_elasticsearch_package</a>
</li>
</ul>
</li>
</ul>
Expand Down
57 changes: 57 additions & 0 deletions website/docs/r/elasticsearch_package.html.markdown
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
---
subcategory: 'ElasticSearch'
layout: 'aws'
page_title: 'AWS: aws_elasticsearch_package'
description: |-
Terraform resource for managing an AWS Elasticsearch Package.
---

# Resource: aws_elasticsearch_package

Manages an AWS Elasticsearch Package.

## Example Usage

### Basic Usage

```hcl
resource "aws_s3_bucket" "example" {
bucket = "foo-bucket"
}

resource "aws_s3_bucket_object" "example" {
bucket = "${aws_s3_bucket.example.bucket}"
key = "synonyms.txt"
content = "foo, bar"
}

resource "aws_elasticsearch_package" "example" {
name = "synonyms"
type = "TXT-DICTIONARY"

source {
s3_bucket_name = "${aws_s3_bucket.example.bucket}"
s3_key = "${aws_s3_bucket_object.example.key}"
}
}
```

## Argument Reference

The following arguments are supported:

* `name` - (Required) Unique name for the package.
* `type` - (Required) Type of the package. Currently supports only `TXT-DICTIONARY`.
* `description` - (Optional) Description of the package.
* `source` - (Required) S3 bucket and key for the package. See below.

**source** supports the following attributes:

* `s3_bucket_name` - (Required) Name of the bucket containing the package.
* `s3_key` - (Required) Key (file name) of the package.

## Attributes Reference

In addition to all arguments above, the following attributes are exported:

* `id` - The ID of the package.