Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/sagemaker_notebook_instance - lifecycle_config_name, root_access, and default_code_repository allow updating + refactor tests #15385

Merged
merged 19 commits into from
Oct 22, 2020
Merged

r/sagemaker_notebook_instance - lifecycle_config_name, root_access, and default_code_repository allow updating + refactor tests #15385

merged 19 commits into from
Oct 22, 2020

Commits on Oct 20, 2020

  1. move some waiters to their own package 

    add validation to `role_arn`, `instance_type`

`lifecycle_config_name` and `root_access` change doesnt recreate.

refactor tests
    @DrFaust92
    DrFaust92 committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    74dc757 View commit details
    Browse the repository at this point in the history

  2. standardize tags test 

    remove custom check funcs and replace with regular attribute checks
    @DrFaust92
    DrFaust92 committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    75bd34d View commit details
    Browse the repository at this point in the history

  3. lifecycle config remove test 

    fix tags test
add kms test
add more checks
    @DrFaust92
    DrFaust92 committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    52a302a View commit details
    Browse the repository at this point in the history

  4. lifecycle config remove test 

    fix tags test
add kms test
add more checks
    @DrFaust92
    DrFaust92 committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    fcb0495 View commit details
    Browse the repository at this point in the history

  5. fix tags test - the last one!

    @DrFaust92
    DrFaust92 committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    258ac05 View commit details
    Browse the repository at this point in the history

  6. fix subnet check

    @DrFaust92
    DrFaust92 committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    d1a67f3 View commit details
    Browse the repository at this point in the history

  7. refactor to be uniform with other tests

    @DrFaust92
    DrFaust92 committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    b46dbd6 View commit details
    Browse the repository at this point in the history

  8. allow updating default code repo

    @DrFaust92
    DrFaust92 committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    e145cb3 View commit details
    Browse the repository at this point in the history

  9. fix volume test config

    @DrFaust92
    DrFaust92 committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    1f89750 View commit details
    Browse the repository at this point in the history

  10. recreate instance for volume size to smaller size

    @DrFaust92
    DrFaust92 committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    ad97ba9 View commit details
    Browse the repository at this point in the history

  11. really fix volume config

    @DrFaust92
    DrFaust92 committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    c69bea5 View commit details
    Browse the repository at this point in the history

  12. update volume fix

    @DrFaust92
    DrFaust92 committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    699523d View commit details
    Browse the repository at this point in the history

  13. add igw

    @DrFaust92
    DrFaust92 committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    ee900e0 View commit details
    Browse the repository at this point in the history

  14. rebase

    @DrFaust92
    DrFaust92 committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    40d8bf4 View commit details
    Browse the repository at this point in the history

  15. fix

    @DrFaust92
    DrFaust92 committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    4c3aec5 View commit details
    Browse the repository at this point in the history

  16. use t3 instance for tests

    @DrFaust92
    DrFaust92 committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    9adfea2 View commit details
    Browse the repository at this point in the history

  17. fix waiter

    @DrFaust92
    DrFaust92 committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    6d31567 View commit details
    Browse the repository at this point in the history

  18. remove igw

    @DrFaust92
    DrFaust92 committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    9444b73 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2020

  1. Apply suggestions from code review 

    Revert to t2

Co-authored-by: Dirk Avery <[email protected]>
    @DrFaust92 @YakDriver
    DrFaust92 and YakDriver authored Oct 22, 2020
    Configuration menu
    Copy the full SHA
    e1ec08f View commit details
    Browse the repository at this point in the history