resource/aws_route53_resolver_firewall_rule_group: Add new resource

[gazoakley]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #18520

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSRoute53ResolverFirewallRuleGroup_'                       
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRoute53ResolverFirewallRuleGroup_ -timeout 180m
=== RUN   TestAccAWSRoute53ResolverFirewallRuleGroup_basic
=== PAUSE TestAccAWSRoute53ResolverFirewallRuleGroup_basic
=== RUN   TestAccAWSRoute53ResolverFirewallRuleGroup_disappears
=== PAUSE TestAccAWSRoute53ResolverFirewallRuleGroup_disappears
=== RUN   TestAccAWSRoute53ResolverFirewallRuleGroup_tags
=== PAUSE TestAccAWSRoute53ResolverFirewallRuleGroup_tags
=== CONT  TestAccAWSRoute53ResolverFirewallRuleGroup_basic
=== CONT  TestAccAWSRoute53ResolverFirewallRuleGroup_tags
=== CONT  TestAccAWSRoute53ResolverFirewallRuleGroup_disappears
--- PASS: TestAccAWSRoute53ResolverFirewallRuleGroup_disappears (18.43s)
--- PASS: TestAccAWSRoute53ResolverFirewallRuleGroup_basic (25.56s)
--- PASS: TestAccAWSRoute53ResolverFirewallRuleGroup_tags (61.38s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	63.040s

[github-actions]

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

• Check open pull requests with the dependencies label to view other dependency updates.
• If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
• If this pull request is for supporting a new AWS service:
  • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
  • If this pull request is already a separate pull request from the above item, you can ignore this message.

[gazoakley]

This currently branches from #18544 - if a later build deps bump gets merged this can be rebased

[gazoakley]

Thanks @ewbankkit - I've pushed a commit addressing the comments

[ewbankkit]

May need rebasing after #18544 (or subsequent) is merged.

[ewbankkit]

LGTM.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute53ResolverFirewallRuleGroup_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRoute53ResolverFirewallRuleGroup_ -timeout 180m
go: downloading github.com/aws/aws-sdk-go v1.38.11
=== RUN   TestAccAWSRoute53ResolverFirewallRuleGroup_basic
=== PAUSE TestAccAWSRoute53ResolverFirewallRuleGroup_basic
=== RUN   TestAccAWSRoute53ResolverFirewallRuleGroup_disappears
=== PAUSE TestAccAWSRoute53ResolverFirewallRuleGroup_disappears
=== RUN   TestAccAWSRoute53ResolverFirewallRuleGroup_tags
=== PAUSE TestAccAWSRoute53ResolverFirewallRuleGroup_tags
=== CONT  TestAccAWSRoute53ResolverFirewallRuleGroup_basic
=== CONT  TestAccAWSRoute53ResolverFirewallRuleGroup_tags
=== CONT  TestAccAWSRoute53ResolverFirewallRuleGroup_disappears
--- PASS: TestAccAWSRoute53ResolverFirewallRuleGroup_disappears (14.32s)
--- PASS: TestAccAWSRoute53ResolverFirewallRuleGroup_basic (19.06s)
--- PASS: TestAccAWSRoute53ResolverFirewallRuleGroup_tags (40.29s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	40.420s

[breathingdust]

LGTM 🚀 Thanks @gazoakley!

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TESTARGS='-run=TestAccAWSRoute53ResolverFirewallRuleGroup_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRoute53ResolverFirewallRuleGroup_ -timeout 180m
go: downloading github.com/aws/aws-sdk-go v1.38.12
go: downloading github.com/hashicorp/go-version v1.3.0
=== RUN   TestAccAWSRoute53ResolverFirewallRuleGroup_basic
=== PAUSE TestAccAWSRoute53ResolverFirewallRuleGroup_basic
=== RUN   TestAccAWSRoute53ResolverFirewallRuleGroup_disappears
=== PAUSE TestAccAWSRoute53ResolverFirewallRuleGroup_disappears
=== RUN   TestAccAWSRoute53ResolverFirewallRuleGroup_tags
=== PAUSE TestAccAWSRoute53ResolverFirewallRuleGroup_tags
=== CONT  TestAccAWSRoute53ResolverFirewallRuleGroup_basic
=== CONT  TestAccAWSRoute53ResolverFirewallRuleGroup_tags
=== CONT  TestAccAWSRoute53ResolverFirewallRuleGroup_disappears
--- PASS: TestAccAWSRoute53ResolverFirewallRuleGroup_disappears (14.19s)
--- PASS: TestAccAWSRoute53ResolverFirewallRuleGroup_basic (17.62s)
--- PASS: TestAccAWSRoute53ResolverFirewallRuleGroup_tags (38.94s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	41.982s

Verified Acceptance Tests in GovCloud (us-gov-west-1)

make testacc TESTARGS='-run=TestAccAWSRoute53ResolverFirewallRuleGroup_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRoute53ResolverFirewallRuleGroup_ -timeout 180m
=== RUN   TestAccAWSRoute53ResolverFirewallRuleGroup_basic
=== PAUSE TestAccAWSRoute53ResolverFirewallRuleGroup_basic
=== RUN   TestAccAWSRoute53ResolverFirewallRuleGroup_disappears
=== PAUSE TestAccAWSRoute53ResolverFirewallRuleGroup_disappears
=== RUN   TestAccAWSRoute53ResolverFirewallRuleGroup_tags
=== PAUSE TestAccAWSRoute53ResolverFirewallRuleGroup_tags
=== CONT  TestAccAWSRoute53ResolverFirewallRuleGroup_basic
=== CONT  TestAccAWSRoute53ResolverFirewallRuleGroup_tags
=== CONT  TestAccAWSRoute53ResolverFirewallRuleGroup_disappears
--- PASS: TestAccAWSRoute53ResolverFirewallRuleGroup_disappears (7.90s)
--- PASS: TestAccAWSRoute53ResolverFirewallRuleGroup_basic (10.56s)
--- PASS: TestAccAWSRoute53ResolverFirewallRuleGroup_tags (24.39s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	27.241s

[ghost]

This has been released in version 3.36.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!