Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_route53_resolver_firewall_rule_group_association: Add new resource #18731

Closed
wants to merge 0 commits into from
Closed

resource/aws_route53_resolver_firewall_rule_group_association: Add new resource #18731

wants to merge 0 commits into from

Conversation

gazoakley
Copy link
Contributor

@gazoakley gazoakley commented Apr 9, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #18520

Output from acceptance testing:

$ gaz@Gaz-MacBook-Pro terraform-provider-aws % make testacc TESTARGS='-run=TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_'                  
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_ -timeout 180m
=== RUN   TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_basic
=== PAUSE TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_basic
=== RUN   TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_name
=== PAUSE TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_name
=== RUN   TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_mutationProtection
=== PAUSE TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_mutationProtection
=== RUN   TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_priority
=== PAUSE TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_priority
=== RUN   TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_disappears
=== PAUSE TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_disappears
=== RUN   TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_tags
=== PAUSE TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_tags
=== CONT  TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_basic
=== CONT  TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_disappears
=== CONT  TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_tags
=== CONT  TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_name
=== CONT  TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_priority
=== CONT  TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_mutationProtection
--- PASS: TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_disappears (206.91s)
--- PASS: TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_basic (218.45s)
--- PASS: TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_mutationProtection (244.96s)
--- PASS: TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_tags (282.00s)
--- PASS: TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_priority (304.53s)
--- PASS: TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_name (395.29s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	399.240s

@ghost ghost added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/route53resolver Issues and PRs that pertain to the route53resolver service. labels Apr 9, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 9, 2021
@gazoakley gazoakley mentioned this pull request Apr 9, 2021
Closed
5 tasks
@gazoakley gazoakley force-pushed the f-route53resolver-firewall-rule-group-association branch 2 times, most recently from 73770fa to 8a41abc Compare April 9, 2021 21:59
@ghost ghost added the provider Pertains to the provider itself, rather than any interaction with AWS. label Apr 9, 2021
@gazoakley gazoakley force-pushed the f-route53resolver-firewall-rule-group-association branch from 8a41abc to a08c824 Compare April 10, 2021 13:59
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed size/L Managed by automation to categorize the size of a PR. labels Apr 10, 2021
@gazoakley gazoakley force-pushed the f-route53resolver-firewall-rule-group-association branch from a08c824 to d159e11 Compare April 10, 2021 20:15
@gazoakley gazoakley marked this pull request as ready for review April 10, 2021 20:31
@gazoakley gazoakley requested a review from a team as a code owner April 10, 2021 20:31
@ewbankkit ewbankkit self-assigned this Apr 16, 2021
@ewbankkit
Copy link
Contributor

@gazoakley Thanks for the contribution 👏.
I've left a couple of review items and will give it a more thorough look over once you resolve the merge conflicts.
Could you please add a CHANGELOG entry file as documented in the Contributing Guide?
Thanks.

@YakDriver YakDriver removed the needs-triage Waiting for first response or review from a maintainer. label Apr 16, 2021
@gazoakley gazoakley force-pushed the f-route53resolver-firewall-rule-group-association branch from d159e11 to 66ecdc5 Compare April 21, 2021 19:31
@gazoakley
Copy link
Contributor Author

Hi @ewbankkit - thanks for the review 👍 . I've fixed the merge conflicts and addressed the review comments

@ewbankkit
Copy link
Contributor

@gazoakley Everything seems on the right track here 👏.
If you have time, could you please add default_tags support (#7926) to the new resources (see #19084 for documentation updates on how to do this or for some examples, #18726)? If not, let us know and I can add this pre-merge.

@gazoakley gazoakley force-pushed the f-route53resolver-firewall-rule-group-association branch from 66ecdc5 to 8b6cdfc Compare April 27, 2021 18:57
ewbankkit
ewbankkit approved these changes Apr 27, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_ -timeout 180m
=== RUN   TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_basic
=== PAUSE TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_basic
=== RUN   TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_name
=== PAUSE TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_name
=== RUN   TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_mutationProtection
=== PAUSE TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_mutationProtection
=== RUN   TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_priority
=== PAUSE TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_priority
=== RUN   TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_disappears
=== PAUSE TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_disappears
=== RUN   TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_tags
=== PAUSE TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_tags
=== CONT  TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_basic
=== CONT  TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_disappears
=== CONT  TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_tags
=== CONT  TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_priority
=== CONT  TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_name
=== CONT  TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_mutationProtection
--- PASS: TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_disappears (136.95s)
--- PASS: TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_basic (150.81s)
--- PASS: TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_mutationProtection (156.45s)
--- PASS: TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_tags (193.68s)
--- PASS: TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_priority (246.86s)
--- PASS: TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_name (326.82s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	329.687s
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_ -timeout 180m
=== RUN   TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_basic
=== PAUSE TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_basic
=== RUN   TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_name
=== PAUSE TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_name
=== RUN   TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_mutationProtection
=== PAUSE TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_mutationProtection
=== RUN   TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_priority
=== PAUSE TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_priority
=== RUN   TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_disappears
=== PAUSE TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_disappears
=== RUN   TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_tags
=== PAUSE TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_tags
=== CONT  TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_basic
=== CONT  TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_disappears
=== CONT  TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_priority
=== CONT  TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_name
=== CONT  TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_mutationProtection
=== CONT  TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_basic
=== CONT  TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_tags
--- PASS: TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_basic (204.45s)
--- PASS: TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_tags (224.56s)
--- PASS: TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_disappears (172.02s)
--- PASS: TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_mutationProtection (218.30s)
--- PASS: TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_priority (285.65s)
--- PASS: TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_name (419.11s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	422.046s

@ewbankkit ewbankkit closed this Apr 29, 2021
@ewbankkit ewbankkit force-pushed the f-route53resolver-firewall-rule-group-association branch from 41778a2 to 1eadd0c Compare April 29, 2021 19:14
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels Apr 29, 2021
@ewbankkit ewbankkit mentioned this pull request Apr 29, 2021
Merged
@ewbankkit
Copy link
Contributor

@gazoakley Sorry, some sort of git mess up on my part got this one closed and I can't reopen it.
I have moved your commit into #19164 and will merge that one.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/route53resolver Issues and PRs that pertain to the route53resolver service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gazoakley @ewbankkit @YakDriver