Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tech debt: Migrate (more) s3control resources to AWS SDK for Go v2 #33416

Merged
merged 33 commits into from
Sep 12, 2023
Merged

Tech debt: Migrate (more) s3control resources to AWS SDK for Go v2 #33416

merged 33 commits into from
Sep 12, 2023

Commits on Sep 9, 2023

  1. r/aws_s3_access_point(_policy): Migrate to AWS SDK for Go v2.

    @ewbankkit
    ewbankkit committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    6da9a69 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2023

  1. (d|r)/aws_s3_account_public_access_block: Migrate to AWS SDK for Go v2.

    @ewbankkit
    ewbankkit committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    d912890 View commit details
    Browse the repository at this point in the history

  2. r/aws_s3control_multi_region_access_point(_policy): Migrate to AWS SD… 

    …K for Go v2.
    @ewbankkit
    ewbankkit committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    2e1703d View commit details
    Browse the repository at this point in the history

  3. Remove 'connForMRAP'.

    @ewbankkit
    ewbankkit committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    c24e039 View commit details
    Browse the repository at this point in the history

  4. Add 'names.S3ControlEndpointID'.

    @ewbankkit
    ewbankkit committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    2f9860e View commit details
    Browse the repository at this point in the history

  5. r/aws_s3control_storage_lens_configuration: Use 'names.S3ControlEndpo… 

    …intID' in acceptance tests.
    @ewbankkit
    ewbankkit committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    2598d82 View commit details
    Browse the repository at this point in the history

  6. Move AsyncOperation.RequestStatus constants.

    @ewbankkit
    ewbankkit committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    be33f6a View commit details
    Browse the repository at this point in the history

  7. s3control: Migrate Access Point, Account Public Access Block and MRAP… 

    … acceptance tests to AWS SDK for Go v2.
    @ewbankkit
    ewbankkit committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    cebbaae View commit details
    Browse the repository at this point in the history

  8. Acceptance test output: 

    % make testacc TESTARGS='-run=TestAccS3ControlAccessPointPolicy_\|TestAccS3ControlAccessPoint_' PKG=s3control ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 3  -run=TestAccS3ControlAccessPointPolicy_\|TestAccS3ControlAccessPoint_ -timeout 180m
=== RUN   TestAccS3ControlAccessPointPolicy_basic
=== PAUSE TestAccS3ControlAccessPointPolicy_basic
=== RUN   TestAccS3ControlAccessPointPolicy_disappears
=== PAUSE TestAccS3ControlAccessPointPolicy_disappears
=== RUN   TestAccS3ControlAccessPointPolicy_disappears_AccessPoint
=== PAUSE TestAccS3ControlAccessPointPolicy_disappears_AccessPoint
=== RUN   TestAccS3ControlAccessPointPolicy_update
=== PAUSE TestAccS3ControlAccessPointPolicy_update
=== RUN   TestAccS3ControlAccessPoint_basic
=== PAUSE TestAccS3ControlAccessPoint_basic
=== RUN   TestAccS3ControlAccessPoint_disappears
=== PAUSE TestAccS3ControlAccessPoint_disappears
=== RUN   TestAccS3ControlAccessPoint_Bucket_arn
=== PAUSE TestAccS3ControlAccessPoint_Bucket_arn
=== RUN   TestAccS3ControlAccessPoint_policy
=== PAUSE TestAccS3ControlAccessPoint_policy
=== RUN   TestAccS3ControlAccessPoint_publicAccessBlock
=== PAUSE TestAccS3ControlAccessPoint_publicAccessBlock
=== RUN   TestAccS3ControlAccessPoint_vpc
=== PAUSE TestAccS3ControlAccessPoint_vpc
=== CONT  TestAccS3ControlAccessPointPolicy_basic
=== CONT  TestAccS3ControlAccessPoint_disappears
=== CONT  TestAccS3ControlAccessPointPolicy_update
--- PASS: TestAccS3ControlAccessPoint_disappears (27.99s)
=== CONT  TestAccS3ControlAccessPoint_publicAccessBlock
--- PASS: TestAccS3ControlAccessPointPolicy_basic (32.96s)
=== CONT  TestAccS3ControlAccessPoint_vpc
--- PASS: TestAccS3ControlAccessPointPolicy_update (55.13s)
=== CONT  TestAccS3ControlAccessPoint_basic
--- PASS: TestAccS3ControlAccessPoint_publicAccessBlock (30.33s)
=== CONT  TestAccS3ControlAccessPointPolicy_disappears_AccessPoint
--- PASS: TestAccS3ControlAccessPoint_vpc (29.53s)
=== CONT  TestAccS3ControlAccessPoint_policy
--- PASS: TestAccS3ControlAccessPointPolicy_disappears_AccessPoint (26.36s)
=== CONT  TestAccS3ControlAccessPoint_Bucket_arn
--- PASS: TestAccS3ControlAccessPoint_basic (29.64s)
=== CONT  TestAccS3ControlAccessPointPolicy_disappears
=== NAME  TestAccS3ControlAccessPoint_Bucket_arn
    acctest.go:1102: skipping since no Outposts found
--- SKIP: TestAccS3ControlAccessPoint_Bucket_arn (0.55s)
--- PASS: TestAccS3ControlAccessPointPolicy_disappears (27.33s)
--- PASS: TestAccS3ControlAccessPoint_policy (70.38s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3control	137.633s
    @ewbankkit
    ewbankkit committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    a0eef42 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2023

  1. Acceptance test output: 

    % make testacc TESTARGS='-run=TestAccS3ControlMultiRegionAccessPointDataSource_\|TestAccS3ControlMultiRegionAccessPointPolicy_\|TestAccS3ControlMultiRegionAccessPoint_' PKG=s3control ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 3  -run=TestAccS3ControlMultiRegionAccessPointDataSource_\|TestAccS3ControlMultiRegionAccessPointPolicy_\|TestAccS3ControlMultiRegionAccessPoint_ -timeout 180m
=== RUN   TestAccS3ControlMultiRegionAccessPointDataSource_basic
=== PAUSE TestAccS3ControlMultiRegionAccessPointDataSource_basic
=== RUN   TestAccS3ControlMultiRegionAccessPointPolicy_basic
=== PAUSE TestAccS3ControlMultiRegionAccessPointPolicy_basic
=== RUN   TestAccS3ControlMultiRegionAccessPointPolicy_disappears_MultiRegionAccessPoint
=== PAUSE TestAccS3ControlMultiRegionAccessPointPolicy_disappears_MultiRegionAccessPoint
=== RUN   TestAccS3ControlMultiRegionAccessPointPolicy_details_policy
=== PAUSE TestAccS3ControlMultiRegionAccessPointPolicy_details_policy
=== RUN   TestAccS3ControlMultiRegionAccessPointPolicy_details_name
=== PAUSE TestAccS3ControlMultiRegionAccessPointPolicy_details_name
=== RUN   TestAccS3ControlMultiRegionAccessPoint_basic
=== PAUSE TestAccS3ControlMultiRegionAccessPoint_basic
=== RUN   TestAccS3ControlMultiRegionAccessPoint_disappears
=== PAUSE TestAccS3ControlMultiRegionAccessPoint_disappears
=== RUN   TestAccS3ControlMultiRegionAccessPoint_PublicAccessBlock
=== PAUSE TestAccS3ControlMultiRegionAccessPoint_PublicAccessBlock
=== RUN   TestAccS3ControlMultiRegionAccessPoint_name
=== PAUSE TestAccS3ControlMultiRegionAccessPoint_name
=== RUN   TestAccS3ControlMultiRegionAccessPoint_threeRegions
=== PAUSE TestAccS3ControlMultiRegionAccessPoint_threeRegions
=== CONT  TestAccS3ControlMultiRegionAccessPointDataSource_basic
=== CONT  TestAccS3ControlMultiRegionAccessPoint_basic
=== CONT  TestAccS3ControlMultiRegionAccessPointPolicy_details_policy
--- PASS: TestAccS3ControlMultiRegionAccessPoint_basic (299.67s)
=== CONT  TestAccS3ControlMultiRegionAccessPointPolicy_details_name
--- PASS: TestAccS3ControlMultiRegionAccessPointPolicy_details_policy (349.69s)
=== CONT  TestAccS3ControlMultiRegionAccessPointPolicy_disappears_MultiRegionAccessPoint
--- PASS: TestAccS3ControlMultiRegionAccessPointDataSource_basic (428.15s)
=== CONT  TestAccS3ControlMultiRegionAccessPoint_name
--- PASS: TestAccS3ControlMultiRegionAccessPointPolicy_disappears_MultiRegionAccessPoint (269.21s)
=== CONT  TestAccS3ControlMultiRegionAccessPoint_threeRegions
--- PASS: TestAccS3ControlMultiRegionAccessPointPolicy_details_name (525.99s)
=== CONT  TestAccS3ControlMultiRegionAccessPoint_PublicAccessBlock
--- PASS: TestAccS3ControlMultiRegionAccessPoint_name (464.03s)
=== CONT  TestAccS3ControlMultiRegionAccessPointPolicy_basic
--- PASS: TestAccS3ControlMultiRegionAccessPoint_threeRegions (429.66s)
=== CONT  TestAccS3ControlMultiRegionAccessPoint_disappears
--- PASS: TestAccS3ControlMultiRegionAccessPoint_PublicAccessBlock (255.27s)
--- PASS: TestAccS3ControlMultiRegionAccessPointPolicy_basic (260.83s)
--- PASS: TestAccS3ControlMultiRegionAccessPoint_disappears (241.52s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3control	1295.205s
    @ewbankkit
    ewbankkit committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    eef4563 View commit details
    Browse the repository at this point in the history

  2. Revert "(d|r)/aws_s3_account_public_access_block: Migrate to AWS SDK … 

    …for Go v2."

This reverts commit d912890.
    @ewbankkit
    ewbankkit committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    81c02ac View commit details
    Browse the repository at this point in the history

  3. Acceptance test output: 

    % make testacc TESTARGS='-run=TestAccS3ControlAccountPublicAccessBlock_serial' PKG=s3control
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 20  -run=TestAccS3ControlAccountPublicAccessBlock_serial -timeout 180m
=== RUN   TestAccS3ControlAccountPublicAccessBlock_serial
=== PAUSE TestAccS3ControlAccountPublicAccessBlock_serial
=== CONT  TestAccS3ControlAccountPublicAccessBlock_serial
=== RUN   TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock
=== RUN   TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/IgnorePublicAcls
=== RUN   TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/RestrictPublicBuckets
=== RUN   TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/DataSourceBasic
=== RUN   TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/basic
=== RUN   TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/disappears
=== RUN   TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/AccountId
=== RUN   TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/BlockPublicAcls
=== RUN   TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/BlockPublicPolicy
--- PASS: TestAccS3ControlAccountPublicAccessBlock_serial (379.37s)
    --- PASS: TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock (379.37s)
        --- PASS: TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/IgnorePublicAcls (69.80s)
        --- PASS: TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/RestrictPublicBuckets (69.54s)
        --- PASS: TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/DataSourceBasic (24.64s)
        --- PASS: TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/basic (28.09s)
        --- PASS: TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/disappears (21.91s)
        --- PASS: TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/AccountId (28.08s)
        --- PASS: TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/BlockPublicAcls (68.75s)
        --- PASS: TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/BlockPublicPolicy (68.56s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3control	384.617s
    @ewbankkit
    ewbankkit committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    6e526d1 View commit details
    Browse the repository at this point in the history

  4. Fix typos.

    @ewbankkit
    ewbankkit committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    129c051 View commit details
    Browse the repository at this point in the history

  5. s3control: Generate AWS SDK for Go v2 tagging code.

    @ewbankkit
    ewbankkit committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    d0dd209 View commit details
    Browse the repository at this point in the history

  6. Merge 'RetryWhenAWSErrCodeEqualsV2' into 'RetryWhenAWSErrCodeEquals'.

    @ewbankkit
    ewbankkit committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    120dff9 View commit details
    Browse the repository at this point in the history

  7. Merge 'RetryWhenAWSErrMessageContainsV2' into 'RetryWhenAWSErrMessage… 

    …Contains'.
    @ewbankkit
    ewbankkit committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    56f3ad5 View commit details
    Browse the repository at this point in the history

  8. r/aws_s3control_bucket(_lifecycle_configuration|_policy): Migrate to … 

    …AWS SDK for Go v2.
    @ewbankkit
    ewbankkit committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    968dbfc View commit details
    Browse the repository at this point in the history

  9. r/aws_s3control_bucket(_lifecycle_configuration|_policy): Migrate acc… 

    …eptance tests to AWS SDK for Go v2.
    @ewbankkit
    ewbankkit committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    661aaaf View commit details
    Browse the repository at this point in the history

  10. Acceptance test output: 

    % make testacc TESTARGS='-run=TestAccS3ControlBucketLifecycleConfiguration_\|TestAccS3ControlBucketPolicy_\|TestAccS3ControlBucket_' PKG=s3control ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 3  -run=TestAccS3ControlBucketLifecycleConfiguration_\|TestAccS3ControlBucketPolicy_\|TestAccS3ControlBucket_ -timeout 180m
=== RUN   TestAccS3ControlBucketLifecycleConfiguration_basic
=== PAUSE TestAccS3ControlBucketLifecycleConfiguration_basic
=== RUN   TestAccS3ControlBucketLifecycleConfiguration_disappears
=== PAUSE TestAccS3ControlBucketLifecycleConfiguration_disappears
=== RUN   TestAccS3ControlBucketLifecycleConfiguration_RuleAbortIncompleteMultipartUpload_daysAfterInitiation
=== PAUSE TestAccS3ControlBucketLifecycleConfiguration_RuleAbortIncompleteMultipartUpload_daysAfterInitiation
=== RUN   TestAccS3ControlBucketLifecycleConfiguration_RuleExpiration_date
=== PAUSE TestAccS3ControlBucketLifecycleConfiguration_RuleExpiration_date
=== RUN   TestAccS3ControlBucketLifecycleConfiguration_RuleExpiration_days
=== PAUSE TestAccS3ControlBucketLifecycleConfiguration_RuleExpiration_days
=== RUN   TestAccS3ControlBucketLifecycleConfiguration_RuleExpiration_expiredObjectDeleteMarker
    acctest.go:85: S3 on Outposts does not error or save it in the API when receiving this parameter
--- SKIP: TestAccS3ControlBucketLifecycleConfiguration_RuleExpiration_expiredObjectDeleteMarker (0.00s)
=== RUN   TestAccS3ControlBucketLifecycleConfiguration_RuleFilter_prefix
=== PAUSE TestAccS3ControlBucketLifecycleConfiguration_RuleFilter_prefix
=== RUN   TestAccS3ControlBucketLifecycleConfiguration_RuleFilter_tags
=== PAUSE TestAccS3ControlBucketLifecycleConfiguration_RuleFilter_tags
=== RUN   TestAccS3ControlBucketLifecycleConfiguration_Rule_id
=== PAUSE TestAccS3ControlBucketLifecycleConfiguration_Rule_id
=== RUN   TestAccS3ControlBucketLifecycleConfiguration_Rule_status
=== PAUSE TestAccS3ControlBucketLifecycleConfiguration_Rule_status
=== RUN   TestAccS3ControlBucketPolicy_basic
=== PAUSE TestAccS3ControlBucketPolicy_basic
=== RUN   TestAccS3ControlBucketPolicy_disappears
=== PAUSE TestAccS3ControlBucketPolicy_disappears
=== RUN   TestAccS3ControlBucketPolicy_policy
=== PAUSE TestAccS3ControlBucketPolicy_policy
=== RUN   TestAccS3ControlBucket_basic
=== PAUSE TestAccS3ControlBucket_basic
=== RUN   TestAccS3ControlBucket_disappears
=== PAUSE TestAccS3ControlBucket_disappears
=== RUN   TestAccS3ControlBucket_tags
    acctest.go:85: S3 Control Bucket resource tagging requires additional eventual consistency handling, see also: #15572
--- SKIP: TestAccS3ControlBucket_tags (0.00s)
=== CONT  TestAccS3ControlBucketLifecycleConfiguration_basic
=== CONT  TestAccS3ControlBucketLifecycleConfiguration_Rule_id
=== CONT  TestAccS3ControlBucketPolicy_policy
    acctest.go:1102: skipping since no Outposts found
--- SKIP: TestAccS3ControlBucketPolicy_policy (1.04s)
=== CONT  TestAccS3ControlBucketPolicy_disappears
=== NAME  TestAccS3ControlBucketLifecycleConfiguration_Rule_id
    acctest.go:1102: skipping since no Outposts found
--- SKIP: TestAccS3ControlBucketLifecycleConfiguration_Rule_id (1.06s)
=== CONT  TestAccS3ControlBucketPolicy_basic
=== NAME  TestAccS3ControlBucketLifecycleConfiguration_basic
    acctest.go:1102: skipping since no Outposts found
--- SKIP: TestAccS3ControlBucketLifecycleConfiguration_basic (1.14s)
=== CONT  TestAccS3ControlBucketLifecycleConfiguration_Rule_status
=== NAME  TestAccS3ControlBucketPolicy_basic
    acctest.go:1102: skipping since no Outposts found
--- SKIP: TestAccS3ControlBucketPolicy_basic (0.19s)
=== CONT  TestAccS3ControlBucket_basic
=== NAME  TestAccS3ControlBucketPolicy_disappears
    acctest.go:1102: skipping since no Outposts found
--- SKIP: TestAccS3ControlBucketPolicy_disappears (0.22s)
=== CONT  TestAccS3ControlBucketLifecycleConfiguration_RuleExpiration_days
=== NAME  TestAccS3ControlBucketLifecycleConfiguration_Rule_status
    acctest.go:1102: skipping since no Outposts found
--- SKIP: TestAccS3ControlBucketLifecycleConfiguration_Rule_status (0.20s)
=== CONT  TestAccS3ControlBucketLifecycleConfiguration_RuleFilter_tags
=== NAME  TestAccS3ControlBucket_basic
    acctest.go:1102: skipping since no Outposts found
--- SKIP: TestAccS3ControlBucket_basic (0.22s)
=== CONT  TestAccS3ControlBucketLifecycleConfiguration_RuleFilter_prefix
=== NAME  TestAccS3ControlBucketLifecycleConfiguration_RuleExpiration_days
    acctest.go:1102: skipping since no Outposts found
--- SKIP: TestAccS3ControlBucketLifecycleConfiguration_RuleExpiration_days (0.21s)
=== CONT  TestAccS3ControlBucketLifecycleConfiguration_RuleAbortIncompleteMultipartUpload_daysAfterInitiation
=== NAME  TestAccS3ControlBucketLifecycleConfiguration_RuleFilter_tags
    acctest.go:1102: skipping since no Outposts found
--- SKIP: TestAccS3ControlBucketLifecycleConfiguration_RuleFilter_tags (0.19s)
=== CONT  TestAccS3ControlBucketLifecycleConfiguration_RuleExpiration_date
=== NAME  TestAccS3ControlBucketLifecycleConfiguration_RuleFilter_prefix
    acctest.go:1102: skipping since no Outposts found
--- SKIP: TestAccS3ControlBucketLifecycleConfiguration_RuleFilter_prefix (0.19s)
=== CONT  TestAccS3ControlBucketLifecycleConfiguration_disappears
=== NAME  TestAccS3ControlBucketLifecycleConfiguration_RuleAbortIncompleteMultipartUpload_daysAfterInitiation
    acctest.go:1102: skipping since no Outposts found
--- SKIP: TestAccS3ControlBucketLifecycleConfiguration_RuleAbortIncompleteMultipartUpload_daysAfterInitiation (0.22s)
=== CONT  TestAccS3ControlBucket_disappears
=== NAME  TestAccS3ControlBucketLifecycleConfiguration_RuleExpiration_date
    acctest.go:1102: skipping since no Outposts found
--- SKIP: TestAccS3ControlBucketLifecycleConfiguration_RuleExpiration_date (0.21s)
=== NAME  TestAccS3ControlBucketLifecycleConfiguration_disappears
    acctest.go:1102: skipping since no Outposts found
--- SKIP: TestAccS3ControlBucketLifecycleConfiguration_disappears (0.20s)
=== NAME  TestAccS3ControlBucket_disappears
    acctest.go:1102: skipping since no Outposts found
--- SKIP: TestAccS3ControlBucket_disappears (0.24s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3control	7.242s
    @ewbankkit
    ewbankkit committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    9244740 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'main' into td-migrate-s3control-to-aws-sdk-v2

    @ewbankkit
    ewbankkit committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    056b9c7 View commit details
    Browse the repository at this point in the history

  12. r/aws_s3control_object_lambda_access_point: Migrate to AWS SDK for Go… 

    … v2.
    @ewbankkit
    ewbankkit committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    c1d5f8b View commit details
    Browse the repository at this point in the history

  13. r/aws_s3control_object_lambda_access_point: Migrate acceptance tests … 

    …to AWS SDK for Go v2.
    @ewbankkit
    ewbankkit committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    7f6f479 View commit details
    Browse the repository at this point in the history

  14. r/aws_s3control_object_lambda_access_point_policy: Migrate to AWS SDK… 

    … for Go v2.
    @ewbankkit
    ewbankkit committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    43b93f7 View commit details
    Browse the repository at this point in the history

  15. r/aws_s3control_object_lambda_access_point_policy: Migrate acceptance… 

    … tests to AWS SDK for Go v2.
    @ewbankkit
    ewbankkit committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    619b33f View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. Start to add AWS partition and region IDs to 'names'.

    @ewbankkit
    ewbankkit committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    0cfcbf8 View commit details
    Browse the repository at this point in the history

  2. Use 'names.USWest2RegionID'.

    @ewbankkit
    ewbankkit committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    a9a9904 View commit details
    Browse the repository at this point in the history

  3. Use 'names.USGovCloudPartitionID'.

    @ewbankkit
    ewbankkit committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    5b2709c View commit details
    Browse the repository at this point in the history

  4. s3control: Add and use 'errCodeNoSuchConfiguration'.

    @ewbankkit
    ewbankkit committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    2886253 View commit details
    Browse the repository at this point in the history

  5. r/aws_s3control_storage_lens_configuration: Use 'tfawserr.ErrHTTPStat… 

    …usCodeEquals'.
    @ewbankkit
    ewbankkit committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    84c24ab View commit details
    Browse the repository at this point in the history

  6. Acceptance test output: 

    % make testacc TESTARGS='-run=TestAccS3ControlStorageLensConfiguration_' PKG=s3control ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 2  -run=TestAccS3ControlStorageLensConfiguration_ -timeout 180m
=== RUN   TestAccS3ControlStorageLensConfiguration_basic
=== PAUSE TestAccS3ControlStorageLensConfiguration_basic
=== RUN   TestAccS3ControlStorageLensConfiguration_disappears
=== PAUSE TestAccS3ControlStorageLensConfiguration_disappears
=== RUN   TestAccS3ControlStorageLensConfiguration_tags
=== PAUSE TestAccS3ControlStorageLensConfiguration_tags
=== RUN   TestAccS3ControlStorageLensConfiguration_update
=== PAUSE TestAccS3ControlStorageLensConfiguration_update
=== RUN   TestAccS3ControlStorageLensConfiguration_advancedMetrics
=== PAUSE TestAccS3ControlStorageLensConfiguration_advancedMetrics
=== CONT  TestAccS3ControlStorageLensConfiguration_basic
=== CONT  TestAccS3ControlStorageLensConfiguration_update
--- PASS: TestAccS3ControlStorageLensConfiguration_basic (24.01s)
=== CONT  TestAccS3ControlStorageLensConfiguration_tags
--- PASS: TestAccS3ControlStorageLensConfiguration_update (50.70s)
=== CONT  TestAccS3ControlStorageLensConfiguration_disappears
--- PASS: TestAccS3ControlStorageLensConfiguration_disappears (17.65s)
=== CONT  TestAccS3ControlStorageLensConfiguration_advancedMetrics
--- PASS: TestAccS3ControlStorageLensConfiguration_tags (58.32s)
--- PASS: TestAccS3ControlStorageLensConfiguration_advancedMetrics (38.19s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3control	111.576s
    @ewbankkit
    ewbankkit committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    7b805c5 View commit details
    Browse the repository at this point in the history

  7. s3control: Migrate sweepers to AWS SDK for Go v2.

    @ewbankkit
    ewbankkit committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    553d913 View commit details
    Browse the repository at this point in the history

  8. r/aws_s3control_multi_region_access_point: Add 'details.region.bucket… 

    …_account_id' argument.
    @ewbankkit
    ewbankkit committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    54a8645 View commit details
    Browse the repository at this point in the history

  9. Acceptance test output: 

    % make testacc TESTARGS='-run=TestAccS3ControlMultiRegionAccessPoint_basic' PKG=s3control
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 20  -run=TestAccS3ControlMultiRegionAccessPoint_basic -timeout 180m
=== RUN   TestAccS3ControlMultiRegionAccessPoint_basic
=== PAUSE TestAccS3ControlMultiRegionAccessPoint_basic
=== CONT  TestAccS3ControlMultiRegionAccessPoint_basic
--- PASS: TestAccS3ControlMultiRegionAccessPoint_basic (297.80s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3control	303.040s
    @ewbankkit
    ewbankkit committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    86f2350 View commit details
    Browse the repository at this point in the history