Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: FindScheduledAction in aws_appautoscaling #34382

Merged
merged 9 commits into from
Mar 18, 2024
Merged

Fix: FindScheduledAction in aws_appautoscaling #34382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
56df82e
Fix FindScheduledAction in aws_appautoscaling to distinguish same-nam…
colinfish-toast Nov 14, 2023
b72b677
Add changelog file
colinfish-toast Nov 14, 2023
2ae76ec
Merge branch 'main' into HEAD
ewbankkit Mar 18, 2024
a939474
Tweak CHANGELOG entry.
ewbankkit Mar 18, 2024
cfe936d
r/aws_appautoscaling_scheduled_action: Tidy up.
ewbankkit Mar 18, 2024
13b930a
r/aws_appautoscaling_scheduled_action: Tidy up acceptance tests.
ewbankkit Mar 18, 2024
b961f9b
Reduce visibility.
ewbankkit Mar 18, 2024
02a02e5
Add 'TestAccAppAutoScalingScheduledAction_disappears'.
ewbankkit Mar 18, 2024
ac57a54
r/aws_appautoscaling_scheduled_action: Fix acceptance tests.
ewbankkit Mar 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/34382.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
resource/aws_appautoscaling_scheduled_action: Read correct resource by using `scalable_dimension` as an additional filter
```
13 changes: 13 additions & 0 deletions internal/service/appautoscaling/exports_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
// Copyright (c) HashiCorp, Inc.
// SPDX-License-Identifier: MPL-2.0

package appautoscaling

// Exports for use in tests only.
var (
ResourcePolicy = resourcePolicy
ResourceScheduledAction = resourceScheduledAction
ResourceTarget = resourceTarget

FindScheduledActionByFourPartKey = findScheduledActionByFourPartKey
)
51 changes: 0 additions & 51 deletions internal/service/appautoscaling/find.go
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions internal/service/appautoscaling/policy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ const (
ResNamePolicy = "Policy"
)

// @SDKResource("aws_appautoscaling_policy")
func ResourcePolicy() *schema.Resource {
// @SDKResource("aws_appautoscaling_policy", name="Scaling Policy")
func resourcePolicy() *schema.Resource {
return &schema.Resource{
CreateWithoutTimeout: resourcePolicyCreate,
ReadWithoutTimeout: resourcePolicyRead,
Expand Down
Loading
Loading