Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/security_group: improve PR #1587 to fix issue #2069 #3628

Closed
wants to merge 2 commits into from
Closed

r/security_group: improve PR #1587 to fix issue #2069 #3628

wants to merge 2 commits into from

Commits on Mar 5, 2018

  1. Fix a few obvious lint issues

    Sander van Harmelen committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    1cfbe4a View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2018

  1. Improve PR #1587 and with that fix issue #2069 

    The logic in PR #1587 has some flaws with regards to how the security group API works in relation with TF.

The problem will not show itself when you manage everything properly from TF, but when someone makes a manual change directly in AWS you could be hit by the problem described in issue #2069.

This PR aims to fix that problem. As for the code itself, it does look like it’s not really DRY, but if you look closely the code is slightly different every time. So making an abstraction seems questionable in this case…
    Sander van Harmelen committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    ad1ef30 View commit details
    Browse the repository at this point in the history