Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apigatewayv2: Retry on ConflictException: Unable to complete operation due to concurrent modification errors #37902

Merged
merged 4 commits into from
Jun 10, 2024

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Jun 10, 2024

Description

Restores the service-wide retry on ConflictException removed during AWS SDK for Go v2 migration (#36490).
Consciously retains the change made in #37732 as that also adds a custom timeout to a single resource's delete.

Relations

Closes #37897.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccAPIGatewayV2Route_' PKG=apigatewayv2 ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/apigatewayv2/... -v -count 1 -parallel 3  -run=TestAccAPIGatewayV2Route_ -timeout 360m
=== RUN   TestAccAPIGatewayV2Route_basic
=== PAUSE TestAccAPIGatewayV2Route_basic
=== RUN   TestAccAPIGatewayV2Route_disappears
=== PAUSE TestAccAPIGatewayV2Route_disappears
=== RUN   TestAccAPIGatewayV2Route_authorizer
=== PAUSE TestAccAPIGatewayV2Route_authorizer
=== RUN   TestAccAPIGatewayV2Route_jwtAuthorization
=== PAUSE TestAccAPIGatewayV2Route_jwtAuthorization
=== RUN   TestAccAPIGatewayV2Route_model
=== PAUSE TestAccAPIGatewayV2Route_model
=== RUN   TestAccAPIGatewayV2Route_requestParameters
=== PAUSE TestAccAPIGatewayV2Route_requestParameters
=== RUN   TestAccAPIGatewayV2Route_simpleAttributes
=== PAUSE TestAccAPIGatewayV2Route_simpleAttributes
=== RUN   TestAccAPIGatewayV2Route_target
=== PAUSE TestAccAPIGatewayV2Route_target
=== RUN   TestAccAPIGatewayV2Route_updateRouteKey
=== PAUSE TestAccAPIGatewayV2Route_updateRouteKey
=== CONT  TestAccAPIGatewayV2Route_basic
=== CONT  TestAccAPIGatewayV2Route_requestParameters
=== CONT  TestAccAPIGatewayV2Route_jwtAuthorization
--- PASS: TestAccAPIGatewayV2Route_basic (11.84s)
=== CONT  TestAccAPIGatewayV2Route_model
=== CONT  TestAccAPIGatewayV2Route_target
--- PASS: TestAccAPIGatewayV2Route_model (11.71s)
--- PASS: TestAccAPIGatewayV2Route_requestParameters (24.47s)
=== CONT  TestAccAPIGatewayV2Route_updateRouteKey
--- PASS: TestAccAPIGatewayV2Route_target (12.04s)
=== CONT  TestAccAPIGatewayV2Route_authorizer
--- PASS: TestAccAPIGatewayV2Route_updateRouteKey (18.00s)
=== CONT  TestAccAPIGatewayV2Route_simpleAttributes
--- PASS: TestAccAPIGatewayV2Route_jwtAuthorization (44.61s)
=== CONT  TestAccAPIGatewayV2Route_disappears
--- PASS: TestAccAPIGatewayV2Route_disappears (9.61s)
--- PASS: TestAccAPIGatewayV2Route_simpleAttributes (23.40s)
--- PASS: TestAccAPIGatewayV2Route_authorizer (51.22s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apigatewayv2	91.094s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. generators Relates to code generators. size/M Managed by automation to categorize the size of a PR. labels Jun 10, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 10, 2024
@ewbankkit ewbankkit merged commit 148c46d into main Jun 10, 2024
54 checks passed
@ewbankkit ewbankkit deleted the b-apigatewayv2-ConflictException branch June 10, 2024 15:18
@github-actions github-actions bot added this to the v5.54.0 milestone Jun 10, 2024
github-actions bot pushed a commit that referenced this pull request Jun 10, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 14, 2024
Copy link

This functionality has been released in v5.54.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
generators Relates to code generators. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API Gateway v2 integration & route: ConflictException due to concurrent modification
1 participant