d/aws_efs_file_system: Document 'file_system_id' attribute

[acmcelwee]

Description

This attribute already exists on the data source, but the documentation was simply missing that attribute.

References

• Relevant attribute in data source schema

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[acmcelwee]

You know, as I re-read these docs, I see above that it says This data source exports the following attributes in addition to the arguments above:.

Some AWS resources/data-sources fully lay out all attributes in the Attribute Reference section - example. Maybe what would be more useful is a removal of the statement This data source exports the following attributes in addition to the arguments above: and ensure that the Attribute Reference section covers the exhaustive list.

Thoughts?

[justinretzolk]

Hey @acmcelwee 👋 Thank you for taking the time to put this PR together! As you've mentioned, it looks like file_system_id is indeed documented in the argument section. The pattern our documentation follows is to split arguments (things that you can supply a value to in your configuration) and attributes (read-only values). This holds true in the aws_autoscaling_group data source that you linked to; you may only supply a value to the name argument, while the rest are read-only attributes.

[github-actions]

Welcome @acmcelwee 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃