-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dms: Fix failing acceptance tests #39756
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
% make testacc TESTARGS='-run=TestAccDMSReplicationTask_basic' PKG=dms make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.23.2 test ./internal/service/dms/... -v -count 1 -parallel 20 -run=TestAccDMSReplicationTask_basic -timeout 360m 2024/10/16 14:29:29 Initializing Terraform AWS Provider... === RUN TestAccDMSReplicationTask_basic === PAUSE TestAccDMSReplicationTask_basic === CONT TestAccDMSReplicationTask_basic === RUN TestAccDMSReplicationTask_basic/full-load === PAUSE TestAccDMSReplicationTask_basic/full-load === RUN TestAccDMSReplicationTask_basic/cdc === PAUSE TestAccDMSReplicationTask_basic/cdc === RUN TestAccDMSReplicationTask_basic/full-load-and-cdc === PAUSE TestAccDMSReplicationTask_basic/full-load-and-cdc === CONT TestAccDMSReplicationTask_basic/full-load === CONT TestAccDMSReplicationTask_basic/full-load-and-cdc === CONT TestAccDMSReplicationTask_basic/cdc --- PASS: TestAccDMSReplicationTask_basic (0.00s) --- PASS: TestAccDMSReplicationTask_basic/full-load (1314.47s) --- PASS: TestAccDMSReplicationTask_basic/cdc (1449.90s) --- PASS: TestAccDMSReplicationTask_basic/full-load-and-cdc (1512.57s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/dms 1517.662s
% make testacc TESTARGS='-run=TestAccDMSReplicationConfig_basic' PKG=dms make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.23.2 test ./internal/service/dms/... -v -count 1 -parallel 20 -run=TestAccDMSReplicationConfig_basic -timeout 360m 2024/10/16 15:11:59 Initializing Terraform AWS Provider... === RUN TestAccDMSReplicationConfig_basic === PAUSE TestAccDMSReplicationConfig_basic === CONT TestAccDMSReplicationConfig_basic === RUN TestAccDMSReplicationConfig_basic/full-load === PAUSE TestAccDMSReplicationConfig_basic/full-load === RUN TestAccDMSReplicationConfig_basic/cdc === PAUSE TestAccDMSReplicationConfig_basic/cdc === RUN TestAccDMSReplicationConfig_basic/full-load-and-cdc === PAUSE TestAccDMSReplicationConfig_basic/full-load-and-cdc === CONT TestAccDMSReplicationConfig_basic/full-load === CONT TestAccDMSReplicationConfig_basic/full-load-and-cdc === CONT TestAccDMSReplicationConfig_basic/cdc --- PASS: TestAccDMSReplicationConfig_basic (0.00s) --- PASS: TestAccDMSReplicationConfig_basic/cdc (53.75s) --- PASS: TestAccDMSReplicationConfig_basic/full-load (53.76s) --- PASS: TestAccDMSReplicationConfig_basic/full-load-and-cdc (53.77s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/dms 58.812s
% make testacc TESTARGS='-run=TestAccDMSReplicationInstance_engineVersion' PKG=dms make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.23.2 test ./internal/service/dms/... -v -count 1 -parallel 20 -run=TestAccDMSReplicationInstance_engineVersion -timeout 360m 2024/10/16 15:19:11 Initializing Terraform AWS Provider... === RUN TestAccDMSReplicationInstance_engineVersion === PAUSE TestAccDMSReplicationInstance_engineVersion === CONT TestAccDMSReplicationInstance_engineVersion --- PASS: TestAccDMSReplicationInstance_engineVersion (1953.99s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/dms 1959.030s
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
tests
PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
service/dms
Issues and PRs that pertain to the dms service.
prioritized
Part of the maintainer teams immediate focus. To be addressed within the current quarter.
labels
Oct 16, 2024
jar-b
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
prioritized
Part of the maintainer teams immediate focus. To be addressed within the current quarter.
service/dms
Issues and PRs that pertain to the dms service.
tests
PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes some failing DMS acceptance tests:
Output from Acceptance Testing