Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/namevaluesfilters: fix generator source path #39757

Merged
merged 2 commits into from
Oct 17, 2024
Merged

internal/namevaluesfilters: fix generator source path #39757

merged 2 commits into from
Oct 17, 2024

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Oct 16, 2024

Description

Fixes the path to the source generator file in the generated service_filters_gen.go files. Also adds missing copyright headers.

@jar-b
internal/namevaluesfilters: fix generator source path
6f27c4e 
Fixes the path to the source generator file in the generated `service_filters_gen.go` files. Also adds missing copyright headers.
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Oct 16, 2024
@jar-b jar-b marked this pull request as ready for review October 16, 2024 23:25
@jar-b jar-b requested a review from a team as a code owner October 16, 2024 23:25
@ewbankkit
Merge branch 'main' into td-filtergen
e43747e 
# Conflicts:
#	internal/generate/namevaluesfilters/v1/file.tmpl
#	internal/namevaluesfilters/v1/service_filters_gen.go
ewbankkit
ewbankkit approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@jar-b jar-b merged commit 86059ad into main Oct 17, 2024
31 checks passed
@jar-b jar-b deleted the td-filtergen branch October 17, 2024 13:14
@github-actions github-actions bot added this to the v5.73.0 milestone Oct 17, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Oct 17, 2024
Update CHANGELOG.md for #39757
ae428c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter.
Projects
None yet
Milestone
v5.73.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jar-b @ewbankkit